From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Maxime Leroy <maxime.leroy@6wind.com>
Cc: Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Olivier Matz <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Didier Pallard" <didier.pallard@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value
Date: Tue, 17 Nov 2020 09:17:35 +0000 [thread overview]
Message-ID: <MWHPR12MB1501D74598DC12D27D351506DFE20@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAEykdvoFAJEnPL4H5y2yZW-1k2QdPOsqxkJuT-V0a6qTfXpsdg@mail.gmail.com>
Hi, Maxime
> -----Original Message-----
> From: Maxime Leroy <maxime.leroy@6wind.com>
> Sent: Tuesday, November 17, 2020 10:52
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
> Olivier Matz <olivier.matz@6wind.com>; dev@dpdk.org; Didier Pallard
> <didier.pallard@6wind.com>
> Subject: Re: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value
>
> Hi Slava,
>
> On Mon, Nov 16, 2020 at 9:03 PM Slava Ovsiienko <viacheslavo@nvidia.com>
> wrote:
> >
> > Hi, Maxime
> >
> > It seems there are some typos (see below).
> > Beside these ones - ACKed.
> >
> > > -----Original Message-----
> > > From: Maxime Leroy <maxime.leroy@6wind.com>
> > > Sent: Monday, November 16, 2020 19:03
> > > To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> > > <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> > > Olivier Matz <olivier.matz@6wind.com>
> > > Cc: dev@dpdk.org; Didier Pallard <didier.pallard@6wind.com>
> > > Subject: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned
> > > value
> > >
> > > From: Didier Pallard <didier.pallard@6wind.com>
> > >
> > > Three bugs in rx_queue_count function:
> > > - One entry may contain several segments, so 'used' must be multiplied
> > > by number of segments per entry to properly reflect the queue usage.
> > > - The number of cqes is equals to (1U << rxq->elts_n) - 1 in non mqrt
> > > mode. The range returned by rx_queue_count should be the number of
> >
> > Should it be "bullet number 3" ?
>
> This bullet is for SPRQ mode. The bullet number 3 is for MPRQ mode.
> Not sure to understand your point.
Sorry, my bad - Now I see the third bullet at the MPRQ, so - please, disregard this my point:
> > Should it be "bullet number 3" ?
With best regards, Slava
> >
> > > entries used in queue, so it ranges from 0 to max number of entries
> > > in queue, not this number minus one.
> >
> > WARNING:TYPO_SPELLING: 'acount' may be misspelled - perhaps 'account'?
> > Should it be - "to take into account?"
> > Should it be "MPRQ" ?
>
> I will fix it in V4.
>
> Thanks for the review.
>
> >
> > > - For MQRT mode, we need to take acount of the number of strd.
> > >
> > > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API")
> > > Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> > > Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >
prev parent reply other threads:[~2020-11-17 9:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:02 [dpdk-dev] [PATCH v3 0/2] net/mlx5: fixes for rx queue count calculation Maxime Leroy
2020-11-16 17:02 ` [dpdk-dev] [PATCH v3 1/2] net/mlx5: fix Rx " Maxime Leroy
2020-11-16 19:57 ` Slava Ovsiienko
2020-11-16 17:02 ` [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value Maxime Leroy
2020-11-16 20:03 ` Slava Ovsiienko
2020-11-17 8:52 ` Maxime Leroy
2020-11-17 9:17 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB1501D74598DC12D27D351506DFE20@MWHPR12MB1501.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=didier.pallard@6wind.com \
--cc=matan@nvidia.com \
--cc=maxime.leroy@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=shahafs@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).