From: "Jonas Pfefferle1" <JPF@zurich.ibm.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix vfio device reset
Date: Sat, 28 Oct 2017 12:54:20 +0200 [thread overview]
Message-ID: <OF54C5FC0A.14218344-ON002581C7.003AD241-C12581C7.003BE7A1@notes.na.collabserv.com> (raw)
In-Reply-To: <20171028062255.11910-1-jerin.jacob@caviumnetworks.com>
Jerin Jacob <jerin.jacob@caviumnetworks.com> wrote on 28/10/2017 08:22:55:
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: thomas@monjalon.net, Jerin Jacob
> <jerin.jacob@caviumnetworks.com>, Jonas Pfefferle
> <jpf@zurich.ibm.com>, Anatoly Burakov <anatoly.burakov@intel.com>
> Date: 28/10/2017 08:23
> Subject: [dpdk-dev] [PATCH] bus/pci: fix vfio device reset
>
> If the device is not capable of resetting, then Linux kernel updates
> the errno as EINVAL.
> https://urldefense.proofpoint.com/v2/url?
> u=http-3A__elixir.free-2Delectrons.com_linux_v4.
> 9_source_drivers_vfio_pci_vfio-5Fpci.c-23L887&d=DwIBAg&c=jf_iaSHvJObTbx-
> siA1ZOg&r=rOdXhRsgn8Iur7bDE0vgwvo6TC8OpoDN-pXjigIjRW0&m=V-
> sbOkvx7qxOMbwyk3n1Fb_1NCjAhl0io-
> hqldJ0r6M&s=OXV7lrxTpahVIsA3J3nCNUlLqW21nlMiQiYveAzyQhc&e=
>
> Honor the EINVAL errno value to avoid pci vfio setup failure.
>
> Fixes: f25f8f367644 ("bus/pci: check VFIO reset ioctl error")
>
> Cc: Jonas Pfefferle <jpf@zurich.ibm.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> ---
> drivers/bus/pci/linux/pci_vfio.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/
> linux/pci_vfio.c
> index 360eed380..11df64846 100644
> --- a/drivers/bus/pci/linux/pci_vfio.c
> +++ b/drivers/bus/pci/linux/pci_vfio.c
> @@ -338,8 +338,11 @@ pci_vfio_setup_device(struct rte_pci_device
> *dev, int vfio_dev_fd)
> return -1;
> }
>
> - /* Reset the device */
> - if (ioctl(vfio_dev_fd, VFIO_DEVICE_RESET)) {
> + /*
> + * Reset the device. If the device is not capable of resetting,
> + * then it updates errno as EINVAL.
> + */
> + if (ioctl(vfio_dev_fd, VFIO_DEVICE_RESET) && errno != EINVAL) {
> RTE_LOG(ERR, EAL, "Unable to reset device! Error: %d (%s)\n",
> errno, strerror(errno));
> return -1;
> --
> 2.14.3
>
Looks good to me.
Reviewed-by: Jonas Pfefferle <jpf@zurich.ibm.com>
Thanks,
Jonas
next prev parent reply other threads:[~2017-10-28 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 6:22 Jerin Jacob
2017-10-28 10:54 ` Jonas Pfefferle1 [this message]
2017-10-31 18:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF54C5FC0A.14218344-ON002581C7.003AD241-C12581C7.003BE7A1@notes.na.collabserv.com \
--to=jpf@zurich.ibm.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).