From: yao.chenghu@zte.com.cn
To: "Chen, Jing D" <jing.d.chen@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: [dpdk-dev] 答复: RE: [PATCH] net/fm10k/base: add a break statement
Date: Thu, 22 Dec 2016 14:01:13 +0800 [thread overview]
Message-ID: <OFCB2DF9D2.DE972E74-ON48258091.001FDF7A-48258091.00210E02@zte.com.cn> (raw)
In-Reply-To: <4341B239C0EFF9468EE453F9E9F4604D3C5C6866@shsmsx102.ccr.corp.intel.com>
>
> Thanks for contributing code. But there are 2 problems here.
>
> 1. You are modifying base code under 'base' directory. It assumed
> READ ONLY because
> there is another Intel team are maintaining it.
> 2. Without your change, the code won't have any negative effect.
> Yes, I appreciate your
> change to make it stronger.
>
> So, I'd to say 'NAC' for this patch.
>
Ok, thanks for your reply.
prev parent reply other threads:[~2016-12-22 6:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 3:05 [dpdk-dev] " Chenghu Yao
2016-12-22 5:22 ` Chen, Jing D
2016-12-22 6:01 ` yao.chenghu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFCB2DF9D2.DE972E74-ON48258091.001FDF7A-48258091.00210E02@zte.com.cn \
--to=yao.chenghu@zte.com.cn \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).