From: Chao CH Zhu <bjzhuc@cn.ibm.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 09/12] Remove iopl operation for IBM Power architecture
Date: Mon, 13 Oct 2014 10:33:08 +0800 [thread overview]
Message-ID: <OFD2277C48.DE4DF69D-ON48257D70.000DF62C-48257D70.000E262D@cn.ibm.com> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725821391202@IRSMSX105.ger.corp.intel.com>
OK. I'll update the patches.
Thanks for your comments!
Best Regards!
------------------------------
Chao Zhu
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Cyril Chemparathy <cchemparathy@tilera.com>, Chao CH
Zhu/China/IBM@IBMCN, "dev@dpdk.org" <dev@dpdk.org>
Date: 2014/10/07 22:45
Subject: RE: [dpdk-dev] [PATCH 09/12] Remove iopl operation for IBM
Power architecture
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cyril Chemparathy
> Sent: Monday, October 06, 2014 11:04 PM
> To: Chao Zhu; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 09/12] Remove iopl operation for IBM
Power architecture
>
> On 9/26/2014 2:36 AM, Chao Zhu wrote:
> > iopl() call is mostly for the i386 architecture. In Power
architecture.
> > It doesn't exist. This patch modified rte_eal_iopl_init() and make it
> > return -1 on Power. This means rte_config.flags will not contain
> > EAL_FLG_HIGH_IOPL flag on IBM Power architecture.
>
> Since iopl() is an x86-only thing, shouldn't the code be conditional on
> defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) instead of below?
>
> Better still, should we maybe break out an architecture specific init
> function? This function could set iopl on x86, and possibly do other
> lowlevel init things on other architectures...
Yep, that sounds like a good way to me too.
>
> > Signed-off-by: Chao Zhu <bjzhuc@cn.ibm.com>
> > ---
> > lib/librte_eal/linuxapp/eal/eal.c | 11 +++++++++++
> > 1 files changed, 11 insertions(+), 0 deletions(-)
> >
> > diff --git a/lib/librte_eal/linuxapp/eal/eal.c
b/lib/librte_eal/linuxapp/eal/eal.c
> > index 4869e7c..8cc1f21 100644
> > --- a/lib/librte_eal/linuxapp/eal/eal.c
> > +++ b/lib/librte_eal/linuxapp/eal/eal.c
> > @@ -50,7 +50,10 @@
> > #include <errno.h>
> > #include <sys/mman.h>
> > #include <sys/queue.h>
> > +/* Power architecture doesn't have this header file */
> > +#ifndef RTE_ARCH_PPC_64
> > #include <sys/io.h>
> > +#endif
> >
> > #include <rte_common.h>
> > #include <rte_debug.h>
> > @@ -1019,11 +1022,19 @@ rte_eal_mcfg_complete(void)
> >
> > /*
> > * Request iopl privilege for all RPL, returns 0 on success
> > + *
> > + * Power architecture doesn't have iopl function, so this function
> > + * return -1 on Power architecture, because this function is only
used
> > + * in rte_eal_init to add EAL_FLG_HIGH_IOPL to rte_config.flags.
> > */
> > static int
> > rte_eal_iopl_init(void)
> > {
> > +#ifndef RTE_ARCH_PPC_64
> > return iopl(HIGHEST_RPL);
> > +#else
> > + return -1;
> > +#endif
> > }
> >
> > /* Launch threads, called at application init(). */
next prev parent reply other threads:[~2014-10-13 2:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:36 [dpdk-dev] [PATCH 00/12] Patches for DPDK to support " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 01/12] Add compiling definations for IBM " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 02/12] Add atomic operations " Chao Zhu
2014-09-29 6:16 ` Hemant
2014-09-29 6:41 ` Chao CH Zhu
2014-10-16 0:39 ` Ananyev, Konstantin
2014-10-16 3:14 ` Chao CH Zhu
2014-10-16 9:42 ` Richardson, Bruce
2014-10-16 11:04 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB97725821393F5D@IRSMSX105.ger.corp.intel.com>
2014-10-16 10:59 ` Ananyev, Konstantin
2014-09-26 9:36 ` [dpdk-dev] [PATCH 03/12] Add byte order " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 04/12] Add CPU cycle " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 05/12] Add prefetch operation " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 06/12] Add spinlock " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 07/12] Add vector memcpy " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 08/12] Add CPU flag checking " Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 09/12] Remove iopl operation " Chao Zhu
2014-10-06 22:03 ` Cyril Chemparathy
2014-10-07 14:46 ` Ananyev, Konstantin
2014-10-13 2:33 ` Chao CH Zhu [this message]
2014-09-26 9:36 ` [dpdk-dev] [PATCH 10/12] Add cache size define for IBM Power Architecture Chao Zhu
2014-09-29 6:21 ` Hemant
2014-09-26 9:36 ` [dpdk-dev] [PATCH 11/12] Add huge page sizes for IBM Power architecture Chao Zhu
2014-09-26 9:36 ` [dpdk-dev] [PATCH 12/12] Add memory support for IBM Power Architecture Chao Zhu
2014-11-13 10:24 ` [dpdk-dev] [PATCH 00/12] Patches for DPDK to support Power architecture Thomas Monjalon
2014-11-13 10:31 ` Chao Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFD2277C48.DE4DF69D-ON48257D70.000DF62C-48257D70.000E262D@cn.ibm.com \
--to=bjzhuc@cn.ibm.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).