From: Alan Elder <alan.elder@microsoft.com>
To: Long Li <longli@microsoft.com>, stephen <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata
Date: Fri, 9 Feb 2024 15:40:40 +0000 [thread overview]
Message-ID: <PA4PR83MB05268F5F948A9B2F0BF7B4CF974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com> (raw)
In-Reply-To: <PH7PR21MB326314E44A430F41B7050B52CE4B2@PH7PR21MB3263.namprd21.prod.outlook.com>
-----Original Message-----
From: Long Li <longli@microsoft.com>
Sent: Friday, February 9, 2024 1:14 AM
To: stephen <stephen@networkplumber.org>; Alan Elder <alan.elder@microsoft.com>
Cc: dev@dpdk.org
Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata
>
> Most of this driver came from FreeBSD. Did you look there to make sure
> naming is the same. I.e would be good to be able to have same code in
> both places as much as possible.
I hadn't looked, but have now - the FreeBSD code does not suffer from the same issue as it uses a series of MACROs to convert between formats.
Agree it seems sensible to keep the same code structure, so I will update the patch to follow the same style as FreeBSD code.
prev parent reply other threads:[~2024-02-09 15:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 14:12 [PATCH] " Alan Elder
2024-02-08 14:42 ` [PATCH v2] " Alan Elder
2024-02-08 17:54 ` Stephen Hemminger
2024-02-09 1:13 ` Long Li
2024-02-09 15:40 ` Alan Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PA4PR83MB05268F5F948A9B2F0BF7B4CF974B2@PA4PR83MB0526.EURPRD83.prod.outlook.com \
--to=alan.elder@microsoft.com \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).