From: "Loftus, Ciara" <ciara.loftus@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/af_xdp: use bpf link for XDP programs
Date: Fri, 22 Oct 2021 10:29:47 +0000 [thread overview]
Message-ID: <PH0PR11MB4791E8BE530EAA907765BF128E809@PH0PR11MB4791.namprd11.prod.outlook.com> (raw)
In-Reply-To: <caf673e3-f9b0-35bb-3065-f8359ec2ea13@intel.com>
>
> On 10/14/2021 10:50 AM, Ciara Loftus wrote:
> > --- a/drivers/net/af_xdp/compat.h
> > +++ b/drivers/net/af_xdp/compat.h
> > @@ -2,9 +2,11 @@
> > * Copyright(c) 2020 Intel Corporation.
> > */
> >
> > +#include <bpf/bpf.h>
> > #include <bpf/xsk.h>
> > #include <linux/version.h>
> > #include <poll.h>
> > +#include <xdp/filter.h>
>
> Hi Ciara,
>
> I am getting build error because xdp/filter.h is missing [1], where
> that header should be?
> And should the meson recognize the missing header/library and behave
> according, or is the build error expected?
My mistake. This header shouldn't be included. Thank you for catching this.
It was to provide the macros BPF_MOV64_IMM and BPF_EXIT_INSN but we can derive these from the bpf/bph.h header and remove this dependency. I will implement this in the v2.
PS I noticed the PMD will not initialize since the "fix max Rx packet length" series. Probably an incorrect value for max_rx_pktlen in the PMD. I will look into it and provide a patch.
Thanks,
Ciara
>
>
> [1]
> In file included from ../drivers/net/af_xdp/rte_eth_af_xdp.c:42:
> ../drivers/net/af_xdp/compat.h:9:10: fatal error: xdp/filter.h: No such file or
> directory
> 9 | #include <xdp/filter.h>
> |
next prev parent reply other threads:[~2021-10-22 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 9:50 Ciara Loftus
2021-10-19 13:14 ` Ferruh Yigit
2021-10-22 10:29 ` Loftus, Ciara [this message]
2021-10-22 10:42 ` [dpdk-dev] [PATCH v2] " Ciara Loftus
2021-11-02 16:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB4791E8BE530EAA907765BF128E809@PH0PR11MB4791.namprd11.prod.outlook.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maciej.fijalkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).