From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Shijith Thotton <sthotton@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [PATCH v4] app/eventdev: add crypto producer mode
Date: Tue, 15 Feb 2022 16:46:31 +0000 [thread overview]
Message-ID: <PH0PR11MB482452FDB9480CAC87B9DCE9E8349@PH0PR11MB4824.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR18MB44298C13BD874A3E60BAD896D9349@SJ0PR18MB4429.namprd18.prod.outlook.com>
Hi Shijith,
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Tuesday, February 15, 2022 9:39 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Subject: RE: [PATCH v4] app/eventdev: add crypto producer mode
>
> Hi Abhinandan,
>
> >>
> >> In crypto producer mode, producer core enqueues cryptodev with
> >> software generated crypto ops and worker core dequeues crypto
> >> completion events from the eventdev. Event crypto metadata used for
> >> above processing is pre- populated in each crypto session.
> >>
> >> Parameter --prod_type_cryptodev can be used to enable crypto producer
> >> mode. Parameter --crypto_adptr_mode can be set to select the crypto
> >> adapter mode, 0 for OP_NEW and 1 for OP_FORWARD.
> >>
> >> This mode can be used to measure the performance of crypto adapter.
> >>
> >> Example:
> >> ./dpdk-test-eventdev -l 0-2 -w <EVENTDEV> -w <CRYPTODEV> -- \
> >> --prod_type_cryptodev --crypto_adptr_mode 1 --test=perf_atq \
> >> --stlist=a --wlcores 1 --plcores 2
> >>
> >> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> >> ---
> >
> ><SNIP>
> >Reposting your comments from previous patch:
> >I tried adding support for software adapter implementation, but is
> >getting a crash in sw_event PMD after some packets. I have posted the
> >respective changes
> >here: https://urldefense.proofpoint.com/v2/url?u=https-
> >3A__patchwork.dpdk.org_project_dpdk_patch_0677cbafa5145f1b9f64dd0
> 07594e
> >033f2d9ab8a.1644337310.git.sthotton-
> >40marvell.com_&d=DwIFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=G9w4KsPaQ
> LACBf
> >GCL35PtiRH996yqJDxAZwrWegU2qQ&m=sMNIOpMhfpihE2tsEnuoFNOZNb
> V5fctS
> >mXD33o-
> >7RC1A1o2s6on3bh2npzmlCR4e&s=xitJsdeoR3OqFEkVzPdJMVrU3xbkF3Qs0
> x2k2Pgi
> >jeE&e=
> >Please take it forward.
> >
> >Command used to test is:
> >dpdk-test-eventdev -l 0-8 -s 0xf0 --vdev=event_sw0 --vdev="crypto_null" --
> \
> > --prod_type_cryptodev --crypto_adptr_mode 1 --test=perf_queue --
> stlist=a \
> > --wlcores 1 --plcores 2
> >
> >I tried to get the above command working with your patches. As you
> >mentioned, I see a crash! If I change the --test to any other queue, I
> >see a totally irrelevant
>
> I have mentioned the same in my previous message. The crash is in event_sw
> PMD.
>
> Thread 10 "lcore-worker-7" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7ffff3767400 (LWP 1140492)] 0x00005555569f2c8a in
> sw_event_schedule ()
> (gdb) bt
> #0 0x00005555569f2c8a in sw_event_schedule ()
> #1 0x0000555556a05e3d in sw_sched_service_func ()
> #2 0x000055555632ada3 in service_runner_func ()
> #3 0x0000555555749b4b in eal_thread_loop.cold ()
> #4 0x00007ffff7a0f609 in start_thread (arg=<optimized out>) at
> pthread_create.c:477
> #5 0x00007ffff7936293 in clone () at
> ../sysdeps/unix/sysv/linux/x86_64/clone.S:95
>
> So requested to take it forward as I'm not well versed in SW PMD
> implementation.
I can't take it forward. Please check with PMD maintainer.
>
> >error message:
> >error: pipeline_opt_check() Invalid producer type 'Event crypto
> >adapter' valid producer 'Ethdev Rx Adapter'
> >error: main() invalid command line argument
> >
>
> Looks like, the test used is pipeline (from the log). Only --prod_type_ethdev
> is supported by the pipeline test. Similar error can be found for all other
> modes.
>
> Refer doc/guides/tools/testeventdev.rst for the list of supported options for
> each test.
>
> >I think, running a test with minimal configuration like sw_event, sw
> >adapter & null cryptodev without any vendor specific HW is very
> >important to acknowledge a patch. Later, this code will be a reference
> >for adding performance test for any specific HW.
> >Right now, I can't think of any other options to see a working test.
> >If you know any other ways to test this code, please let me.
> >
>
> Please let me know if any change is needed in the application side. I will take
> a look.
Right now, the app is not working as expected.
Please debug and fix the issue.
>
> Thanks,
> Shijith
next prev parent reply other threads:[~2022-02-15 16:46 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 19:53 [PATCH] " Shijith Thotton
2021-12-21 8:51 ` [PATCH v2] " Shijith Thotton
2021-12-30 11:56 ` Gujjar, Abhinandan S
2022-01-03 6:04 ` Shijith Thotton
2022-01-03 8:46 ` Gujjar, Abhinandan S
2022-01-03 9:14 ` Shijith Thotton
2022-01-04 15:28 ` Aaron Conole
2022-01-04 15:49 ` [EXT] " Shijith Thotton
2022-01-04 10:30 ` [PATCH v3] " Shijith Thotton
2022-01-21 12:25 ` Jerin Jacob
2022-01-23 16:56 ` Gujjar, Abhinandan S
2022-01-23 18:44 ` Gujjar, Abhinandan S
2022-01-24 6:09 ` Shijith Thotton
2022-01-24 6:59 ` Shijith Thotton
2022-01-25 14:15 ` Gujjar, Abhinandan S
2022-01-25 13:39 ` Gujjar, Abhinandan S
2022-02-08 17:00 ` Shijith Thotton
2022-02-14 15:26 ` Jerin Jacob
2022-02-14 15:31 ` Gujjar, Abhinandan S
2022-02-08 16:33 ` [PATCH v4] " Shijith Thotton
2022-02-15 6:03 ` Gujjar, Abhinandan S
2022-02-15 16:08 ` Shijith Thotton
2022-02-15 16:46 ` Gujjar, Abhinandan S [this message]
2022-02-15 16:56 ` [PATCH v5] " Shijith Thotton
2022-02-16 4:47 ` Gujjar, Abhinandan S
2022-02-16 7:08 ` Shijith Thotton
2022-02-16 7:49 ` Gujjar, Abhinandan S
2022-02-16 8:44 ` Jerin Jacob
2022-02-16 8:54 ` Jerin Jacob
2022-02-17 5:33 ` Gujjar, Abhinandan S
2022-02-21 13:10 ` Van Haaren, Harry
2022-02-22 7:03 ` Shijith Thotton
2022-02-23 9:02 ` Gujjar, Abhinandan S
2022-02-23 10:02 ` Shijith Thotton
2022-02-23 10:13 ` Van Haaren, Harry
2022-02-23 16:33 ` Gujjar, Abhinandan S
2022-02-23 17:02 ` Shijith Thotton
2022-02-17 6:56 ` [EXT] " Akhil Goyal
2022-02-18 12:00 ` Shijith Thotton
2022-02-18 12:11 ` [PATCH v6] " Shijith Thotton
2022-02-24 4:46 ` [PATCH v7] " Shijith Thotton
2022-02-24 6:18 ` Gujjar, Abhinandan S
2022-02-24 7:58 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB482452FDB9480CAC87B9DCE9E8349@PH0PR11MB4824.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).