From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Power, Ciara" <ciara.power@intel.com>, "Ji, Kai" <kai.ji@intel.com>
Subject: RE: [PATCH v2] crypto/qat: fix NULL algorithm digest placement
Date: Mon, 26 Jun 2023 18:20:54 +0000 [thread overview]
Message-ID: <PH0PR11MB501310AC77DDF1CE0098663B9F26A@PH0PR11MB5013.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230623135105.1377882-1-ciara.power@intel.com>
> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Friday, June 23, 2023 3:51 PM
> To: dev@dpdk.org
> Cc: Power, Ciara <ciara.power@intel.com>; Ji, Kai <kai.ji@intel.com>
> Subject: [PATCH v2] crypto/qat: fix NULL algorithm digest placement
>
> QAT HW generates bytes of 0x00 digest, even when a digest of len 0 is
> requested for NULL. This caused test failures when the test vector had digest len
> 0, as the buffer has unexpected changed bytes.
>
> By placing the digest into the cookie for NULL authentication, the buffer
> remains unchanged as expected, and the digest is placed to the side, as it won't
> be used anyway.
>
> Fixes: db0e952a5c01 ("crypto/qat: add NULL capability")
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
> v2: added fixes line as this was a bug
> ---
> --
> 2.25.1
Acked-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
next prev parent reply other threads:[~2023-06-26 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 14:40 [PATCH] crypto/qat: modify " Ciara Power
2023-06-23 13:51 ` [PATCH v2] crypto/qat: fix " Ciara Power
2023-06-26 18:20 ` Kusztal, ArkadiuszX [this message]
2023-07-03 14:19 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB501310AC77DDF1CE0098663B9F26A@PH0PR11MB5013.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).