From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Subject: RE: [EXT] [RFC PATCH] cryptodev: add basic asymmetric crypto capability structs
Date: Tue, 17 May 2022 11:33:42 +0000 [thread overview]
Message-ID: <PH0PR11MB5013CAD76C4EC7124274D7099FCE9@PH0PR11MB5013.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB448425BDF6A4888EBA963739D8CF9@CO6PR18MB4484.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday, May 16, 2022 8:55 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Subject: RE: [EXT] [RFC PATCH] cryptodev: add basic asymmetric crypto
> capability structs
>
> Hi Arek,
>
> Are you planning for a formal patch for adding asym capabilities?
[Arek] - Yes, I will send one in next few days. But I wanted to have some part of patches initially accepted as I need to reflect API changes there.
>
> > This commit adds basic structs to handle asymmetric crypto capability.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > lib/cryptodev/rte_crypto_asym.h | 47
> +++++++++++++++++++++++++++++++++
> > lib/cryptodev/rte_cryptodev.h | 8 ++++++
> > 2 files changed, 55 insertions(+)
> >
> > diff --git a/lib/cryptodev/rte_crypto_asym.h
> > b/lib/cryptodev/rte_crypto_asym.h index cd24d4b07b..2d58fffee5 100644
> > --- a/lib/cryptodev/rte_crypto_asym.h
> > +++ b/lib/cryptodev/rte_crypto_asym.h
> > @@ -386,6 +386,26 @@ struct rte_crypto_rsa_op_param {
> > */
> > };
> >
> > +struct rte_crypto_rsa_capability {
> > + uint64_t padding_type;
> > + /* Supported padding */
> > + union {
> > + uint64_t hash;
> > + /* Supported hash functions, at least one
> > + * shall be supported */
> > + uint64_t mgf;
> > + /* Supported masdk generation functions,
> > + * at least one shall be supported */
> > + } padding;
> > + uint32_t max_key_len;
> > + /* Maximum supported key length */
> > + uint8_t sign_message;
> > + /* If zero input should contain message digest,
> > + * otherwise it should be plain message */
> > + uint8_t pkcs_plain_padding;
> > + /* PKCS1_5 padding without algorithm identifier */ };
> > +
> > /**
> > * Diffie-Hellman Operations params.
> > * @note:
> > @@ -416,6 +436,19 @@ struct rte_crypto_dh_op_param {
> > */
> > };
> >
> > +struct rte_crypto_dh_capability {
> > + union {
> > + uint32_t group_size;
> > + /**< Maximum size of underliying mod group */
> > + uint64_t curves;
> > + /**< Supported elliptic curve ids */
> > + /* uint64_t fixed_groups; ? */
> > + /**< Supported fixed groups */
> > + /* uint8_t custom_curves; ? */
> > + /**< Supported custom curves */
> > + };
> > +};
> > +
> > /**
> > * DSA Operations params
> > *
> > @@ -484,6 +517,13 @@ struct rte_crypto_ecdsa_op_param {
> > */
> > };
> >
> > +struct rte_crypto_ecdsa_capability {
> > + uint64_t curves;
> > + /**< Supported elliptic curve ids */
> > + /* uint8_t custom_curves; ? */
> > + /**< Supported custom curves */
> > +};
> > +
> > /**
> > * Structure for EC point multiplication operation param
> > */
> > @@ -498,6 +538,13 @@ struct rte_crypto_ecpm_op_param {
> > /**< Scalar to multiply the input point */ };
> >
> > +struct rte_crypto_ecpm_capability {
> > + uint64_t curves;
> > + /**< Supported elliptic curve ids */
> > + /* uint8_t custom_curves; ? */
> > + /**< Supported custom curves */
> > +};
> > +
> > /**
> > * Asymmetric crypto transform data
> > *
> > diff --git a/lib/cryptodev/rte_cryptodev.h
> > b/lib/cryptodev/rte_cryptodev.h index 45d33f4a50..79026dbb80 100644
> > --- a/lib/cryptodev/rte_cryptodev.h
> > +++ b/lib/cryptodev/rte_cryptodev.h
> > @@ -176,6 +176,14 @@ struct rte_cryptodev_asymmetric_xform_capability {
> > /**< Range of modulus length supported by modulus based
> xform.
> > * Value 0 mean implementation default
> > */
> > + struct rte_crypto_ecdsa_capability ecdsa;
> > + /**< ECDSA capability */
> > + struct rte_crypto_ecpm_capability ecpm;
> > + /**< ECPM capability */
> > + struct rte_crypto_rsa_capability rsa;
> > + /**< RSA capability */
> > + struct rte_crypto_dh_capability dh;
> > + /**< DH capability */
> > };
> > };
> >
> > --
> > 2.30.2
prev parent reply other threads:[~2022-05-17 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 14:05 Arek Kusztal
2022-05-16 18:54 ` [EXT] " Akhil Goyal
2022-05-17 11:33 ` Kusztal, ArkadiuszX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5013CAD76C4EC7124274D7099FCE9@PH0PR11MB5013.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).