From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Akhil Goyal <gakhil@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves
Date: Tue, 17 May 2022 11:45:51 +0000 [thread overview]
Message-ID: <PH0PR11MB5013E1A18A38CBF1B53FE8BD9FCE9@PH0PR11MB5013.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB4484CA48B39F46D5C1AA9613D8CF9@CO6PR18MB4484.namprd18.prod.outlook.com>
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Monday, May 16, 2022 8:58 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Subject: RE: [EXT] [PATCH] cryptodev: add support for 25519 and 448 curves
>
> > This commit adds support for following elliptic curves:
> > 1) Curve25519
> > 2) Curve448
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > lib/cryptodev/rte_crypto_asym.h | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/cryptodev/rte_crypto_asym.h
> > b/lib/cryptodev/rte_crypto_asym.h index cd24d4b07b..775b2f6277 100644
> > --- a/lib/cryptodev/rte_crypto_asym.h
> > +++ b/lib/cryptodev/rte_crypto_asym.h
> > @@ -48,6 +48,8 @@ enum rte_crypto_ec_group {
> > RTE_CRYPTO_EC_GROUP_SECP256R1 = 23,
> > RTE_CRYPTO_EC_GROUP_SECP384R1 = 24,
> > RTE_CRYPTO_EC_GROUP_SECP521R1 = 25,
> > + RTE_CRYPTO_EC_GROUP_CURVE25519 = 29,
> > + RTE_CRYPTO_EC_GROUP_CURVE448 = 30,
> > };
> >
> > /**
> > @@ -180,9 +182,17 @@ typedef rte_crypto_param rte_crypto_uint;
> > */
> > struct rte_crypto_ec_point {
> > rte_crypto_param x;
> > - /**< X coordinate */
> > + /**<
> > + * X coordinate
> > + * For curve25519 and curve448 - little-endian integer
> > + * otherwise, big-endian integer
> > + */
> > rte_crypto_param y;
> > - /**< Y coordinate */
> > + /**<
> > + * Y coordinate
> > + * For curve25519 and curve448 - little-endian integer
> > + * otherwise, big-endian integer
> > + */
> Can you give reference of the document which specify this endianness?
[Arek] - sure, I may give rfc reference here, but if it will go into crypodev in this form I am not yet sure.
These curves could be used with DH, but cannot be used with ECDSA. Even with DH it may be that we will go with separate {dh_op, ecdh_op, x25519_op, x448_op} but this would make TLS group reference pointless, and we would not add Montgomery/Edwards curves at all as an enum.
>
> And if it is implicit as per the protocol, do we need to add explicit comments
> here?
next prev parent reply other threads:[~2022-05-17 11:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 13:43 Arek Kusztal
2022-05-16 18:57 ` [EXT] " Akhil Goyal
2022-05-17 11:45 ` Kusztal, ArkadiuszX [this message]
2022-05-26 16:38 ` Akhil Goyal
2022-05-31 14:33 ` Kusztal, ArkadiuszX
2022-05-31 14:40 ` Akhil Goyal
2022-05-31 14:42 ` Kusztal, ArkadiuszX
2022-05-31 15:25 ` Akhil Goyal
2022-05-31 15:39 ` Kusztal, ArkadiuszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5013E1A18A38CBF1B53FE8BD9FCE9@PH0PR11MB5013.namprd11.prod.outlook.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).