DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Walsh, Conor" <conor.walsh@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] dma/ioat: remove printf within ioat driver
Date: Tue, 7 Feb 2023 10:47:35 +0000	[thread overview]
Message-ID: <PH0PR11MB520707131CEF812F7EFEB283FFDB9@PH0PR11MB5207.namprd11.prod.outlook.com> (raw)
In-Reply-To: <Y90/VfGiSCa/h9je@bricha3-MOBL.ger.corp.intel.com>

> On Fri, Feb 03, 2023 at 04:35:14PM +0000, Conor Walsh wrote:
> > rte_log should be used instead of printf within the drivers this patch
> > changes a printf within the ioat dma driver's start function to an rte log.
> > The printfs within ioat's dump function will be retained.
> >
> > Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> > ---
> 
> One little nit below, but with that fixed
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Thanks for the ack!

> 
> >  drivers/dma/ioat/ioat_dmadev.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/dma/ioat/ioat_dmadev.c
> b/drivers/dma/ioat/ioat_dmadev.c
> > index 5906eb45aa..3fe50ea4a4 100644
> > --- a/drivers/dma/ioat/ioat_dmadev.c
> > +++ b/drivers/dma/ioat/ioat_dmadev.c
> > @@ -146,9 +146,9 @@ ioat_dev_start(struct rte_dma_dev *dev)
> >  	/* Prime the status register to be set to the last element. */
> >  	ioat->status = ioat->ring_addr + ((ioat->qcfg.nb_desc - 1) *
> DESC_SZ);
> >
> > -	printf("IOAT.status: %s [0x%"PRIx64"]\n",
> > -			chansts_readable[ioat->status &
> IOAT_CHANSTS_STATUS],
> > -			ioat->status);
> > +	IOAT_PMD_DEBUG("channel status - %s [0x%"PRIx64"]\n",
> > +		       chansts_readable[ioat->status &
> IOAT_CHANSTS_STATUS],
> > +		       ioat->status);
> >
> 
> This whitespace change should not be needed, and we use only tabs for
> indent, not spaces. This should be a one-line change.

I will send a v2 with only a single line change.

Thanks,
Conor.

> 
> >  	if ((ioat->regs->chansts & IOAT_CHANSTS_STATUS) ==
> IOAT_CHANSTS_HALTED) {
> >  		IOAT_PMD_WARN("Device HALTED on start, attempting to
> recover\n");
> > --
> > 2.25.1
> >

next prev parent reply	other threads:[~2023-02-07 10:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-03 16:35 Conor Walsh
2023-02-03 17:07 ` Bruce Richardson
2023-02-07 10:47   ` Walsh, Conor [this message]
2023-02-07 10:48 ` [PATCH v2] " Conor Walsh
2023-02-20  0:38   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR11MB520707131CEF812F7EFEB283FFDB9@PH0PR11MB5207.namprd11.prod.outlook.com \
    --to=conor.walsh@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).