From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: "Kundapura, Ganapati" <ganapati.kundapura@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Cc: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>,
"vfialko@marvell.com" <vfialko@marvell.com>
Subject: RE: [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events
Date: Wed, 7 Dec 2022 06:55:41 +0000 [thread overview]
Message-ID: <PH0PR11MB5832372F81D5DB23CA3D73C7E81A9@PH0PR11MB5832.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221207064945.1665368-3-ganapati.kundapura@intel.com>
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> -----Original Message-----
> From: Kundapura, Ganapati <ganapati.kundapura@intel.com>
> Sent: Wednesday, December 7, 2022 12:20 PM
> To: dev@dpdk.org; jerinj@marvell.com; Naga Harish K, S V
> <s.v.naga.harish.k@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; vfialko@marvell.com
> Subject: [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing
> events
>
> Events enqueued to eventdev from the beginning of the circular buffer.
> This leads to invalid or already freed events getting enqueued to eventdev
> from the circular buffer.
>
> Fixed by enqueuing the events to eventdev from the head pointer of circular
> buffer.
>
> Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
>
> Signed-off-by: Ganapati Kundapura <ganapati.kundapura@intel.com>
> ---
> v2:
> * Updated subject line in commit message
>
> diff --git a/lib/eventdev/rte_event_crypto_adapter.c
> b/lib/eventdev/rte_event_crypto_adapter.c
> index eaff577..c08984b 100644
> --- a/lib/eventdev/rte_event_crypto_adapter.c
> +++ b/lib/eventdev/rte_event_crypto_adapter.c
> @@ -669,7 +669,7 @@ eca_circular_buffer_flush_to_evdev(struct
> event_crypto_adapter *adapter,
> else
> return 0; /* buffer empty */
>
> - nb_ops_flushed = eca_ops_enqueue_burst(adapter, ops, n);
> + nb_ops_flushed = eca_ops_enqueue_burst(adapter, &ops[*headp],
> n);
> bufp->count -= nb_ops_flushed;
> if (!bufp->count) {
> *headp = 0;
> --
> 2.6.4
next prev parent reply other threads:[~2022-12-07 6:55 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 17:10 [PATCH v1 1/5] eventdev/event_crypto: process event port's impl rel cap Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 2/5] eventdev/crypto: wrong crypto enqueue count stats Ganapati Kundapura
2022-12-01 6:07 ` Naga Harish K, S V
2022-12-01 6:56 ` Kundapura, Ganapati
2022-11-30 17:10 ` [PATCH v1 3/5] eventdev/crypto: wrong offset used while flushing events Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 4/5] eventdev/crypto: overflow in circular buffer Ganapati Kundapura
2022-11-30 17:10 ` [PATCH v1 5/5] eventdev/crypto: add all failed events to " Ganapati Kundapura
2022-12-01 6:46 ` [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Ganapati Kundapura
2022-12-01 6:46 ` [PATCH v2 2/5] eventdev/crypto: fix wrong crypto enqueue count stats Ganapati Kundapura
2022-12-05 11:34 ` [EXT] " Volodymyr Fialko
2022-12-07 5:40 ` Gujjar, Abhinandan S
2022-12-01 6:46 ` [PATCH v2 3/5] eventdev/crypto: fix wrong offset used while flushing events Ganapati Kundapura
2022-12-05 11:35 ` [EXT] " Volodymyr Fialko
2022-12-06 16:17 ` Gujjar, Abhinandan S
2022-12-01 6:46 ` [PATCH v2 4/5] eventdev/crypto: fix overflow in circular buffer Ganapati Kundapura
2022-12-05 11:37 ` [EXT] " Volodymyr Fialko
2022-12-06 16:25 ` Gujjar, Abhinandan S
2022-12-07 6:53 ` Kundapura, Ganapati
2022-12-01 6:46 ` [PATCH v2 5/5] eventdev/crypto: add all failed events to " Ganapati Kundapura
2022-12-05 11:37 ` [EXT] " Volodymyr Fialko
2022-12-06 16:37 ` Gujjar, Abhinandan S
2022-12-01 13:20 ` [EXT] [PATCH v2 1/5] eventdev/event_crypto: process event port's impl rel cap Volodymyr Fialko
2022-12-06 15:44 ` Gujjar, Abhinandan S
2022-12-07 6:53 ` Kundapura, Ganapati
2022-12-07 6:49 ` [PATCH v3 " Ganapati Kundapura
2022-12-07 6:49 ` [PATCH v3 2/5] eventdev/crypto: fix wrong crypto enqueue count stats Ganapati Kundapura
2022-12-07 6:55 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 3/5] eventdev/crypto: fix wrong offset used while flushing events Ganapati Kundapura
2022-12-07 6:55 ` Gujjar, Abhinandan S [this message]
2022-12-07 6:49 ` [PATCH v3 4/5] eventdev/crypto: fix overflow in circular buffer Ganapati Kundapura
2022-12-07 7:04 ` Gujjar, Abhinandan S
2022-12-07 6:49 ` [PATCH v3 5/5] eventdev/crypto: fix failed events Ganapati Kundapura
2022-12-07 6:56 ` Gujjar, Abhinandan S
2023-01-12 12:59 ` Jerin Jacob
2022-12-07 6:54 ` [PATCH v3 1/5] eventdev/event_crypto: process event port's impl rel cap Gujjar, Abhinandan S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5832372F81D5DB23CA3D73C7E81A9@PH0PR11MB5832.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=dev@dpdk.org \
--cc=ganapati.kundapura@intel.com \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=vfialko@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).