From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Shijith Thotton <sthotton@marvell.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"anoobj@marvell.com" <anoobj@marvell.com>
Subject: RE: [PATCH v1] test/event_crypto_adapter: fix runtime parameter test
Date: Tue, 18 Apr 2023 03:11:04 +0000 [thread overview]
Message-ID: <PH0PR11MB583281E206EC20735B9031E8E89D9@PH0PR11MB5832.namprd11.prod.outlook.com> (raw)
In-Reply-To: <056734d7f296b5f6d8db11c3d1fb1b6fda11231b.1681752950.git.sthotton@marvell.com>
> -----Original Message-----
> From: Shijith Thotton <sthotton@marvell.com>
> Sent: Monday, April 17, 2023 11:22 PM
> To: jerinj@marvell.com; Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org;
> pbhagavatula@marvell.com; stable@dpdk.org; anoobj@marvell.com; Gujjar,
> Abhinandan S <abhinandan.gujjar@intel.com>
> Subject: [PATCH v1] test/event_crypto_adapter: fix runtime parameter test
>
> The runtime parameters for the crypto adapter are applicable only for devices
> without an internal port. To accommodate this, the UT has been updated to
> skip the test for checking the runtime parameters if the API to set runtime
> parameters is not supported.
>
> Fixes: 04ed18cd41f1 ("eventdev/crypto: support runtime set/get
> parameters")
>
> Signed-off-by: Shijith Thotton <sthotton@marvell.com>
> ---
Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> app/test/test_event_crypto_adapter.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 264d6f731e..24f66be69f 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -275,7 +275,7 @@ test_crypto_adapter_stats(void) static int
> test_crypto_adapter_params(void)
> {
> - int err;
> + int err, rc;
> struct rte_event_crypto_adapter_runtime_params in_params;
> struct rte_event_crypto_adapter_runtime_params out_params;
> uint32_t cap;
> @@ -303,6 +303,10 @@ test_crypto_adapter_params(void)
> /* Case 1: Get the default value of mbufs processed by adapter */
> err =
> rte_event_crypto_adapter_runtime_params_get(TEST_ADAPTER_ID,
> &out_params);
> + if (err == -ENOTSUP) {
> + rc = TEST_SKIPPED;
> + goto queue_pair_del;
> + }
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>
> /* Case 2: Set max_nb = 32 (=BATCH_SEIZE) */ @@ -370,11 +374,13
> @@ test_crypto_adapter_params(void)
> TEST_ASSERT(in_params.max_nb == out_params.max_nb, "Expected
> %u got %u",
> in_params.max_nb, out_params.max_nb);
>
> + rc = TEST_SUCCESS;
> +queue_pair_del:
> err = rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID,
> TEST_CDEV_ID, TEST_CDEV_QP_ID);
> TEST_ASSERT_SUCCESS(err, "Failed to delete add queue pair\n");
>
> - return TEST_SUCCESS;
> + return rc;
> }
>
> static int
> --
> 2.25.1
next prev parent reply other threads:[~2023-04-18 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 17:52 Shijith Thotton
2023-04-18 2:43 ` Anoob Joseph
2023-04-18 3:11 ` Gujjar, Abhinandan S [this message]
2023-05-18 7:15 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB583281E206EC20735B9031E8E89D9@PH0PR11MB5832.namprd11.prod.outlook.com \
--to=abhinandan.gujjar@intel.com \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=stable@dpdk.org \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).