From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH 2/2] app/pdump: handle SIGTERM and SIGHUP
Date: Tue, 27 Feb 2024 09:59:37 +0000 [thread overview]
Message-ID: <PH0PR11MB5877C7AE36E24803E6FBA856FF592@PH0PR11MB5877.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240226205143.66702-3-stephen@networkplumber.org>
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> + sigaction(SIGHUP, NULL, &origaction);
Why do we need this ? Can't be this direct sigaction(SIGHUP, &action, NULL) without a below if code?
Can you please explain how this works.
> + if (origaction.sa_handler == SIG_DFL)
> + sigaction(SIGHUP, &action, NULL);
>
Other changes looks ok to me.
Regards,
Reshma
next prev parent reply other threads:[~2024-02-27 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 20:49 [PATCH 0/2] dumpcap,pdump handle cleanup signals Stephen Hemminger
2024-02-26 20:49 ` [PATCH 1/2] app/dumpcap: handle SIGTERM and SIGHUP Stephen Hemminger
2024-02-26 20:49 ` [PATCH 2/2] app/pdump: " Stephen Hemminger
2024-02-27 9:59 ` Pattan, Reshma [this message]
2024-02-27 18:09 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5877C7AE36E24803E6FBA856FF592@PH0PR11MB5877.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).