From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Shijith Thotton <sthotton@marvell.com>,
"timothy.mcdaniel@intel.com" <timothy.mcdaniel@intel.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"sachin.saxena@nxp.com" <sachin.saxena@nxp.com>,
"mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
"liangma@liangbit.com" <liangma@liangbit.com>,
"peter.mccarthy@intel.com" <peter.mccarthy@intel.com>,
"harry.van.haaren@intel.com" <harry.van.haaren@intel.com>,
"erik.g.carrillo@intel.com" <erik.g.carrillo@intel.com>,
"abhinandan.gujjar@intel.com" <abhinandan.gujjar@intel.com>,
"s.v.naga.harish.k@intel.com" <s.v.naga.harish.k@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH v4 0/3] Introduce event link profiles
Date: Fri, 29 Sep 2023 09:27:12 +0000 [thread overview]
Message-ID: <PH0PR18MB408622CE89C8A373121B8BE5DEC0A@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1NHXS7tfnPhSviLOSRPMC2jfwQu6v1oBOwPtAC+34vf+A@mail.gmail.com>
> On Thu, Sep 28, 2023 at 3:42 PM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> + @Thomas Monjalon @David Marchand @Aaron Conole @Michael
> Santana
>
> There is CI failure in apply stage[1] where it is taking main tree
> commit. Not sure why it is taking main tree?
>
> Pavan,
>
> Could you resend this series again to give one more chance to CI.
>
>
> [1]
> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_patch_20230928101205.4352-2D2-
> 2Dpbhagavatula-
> 40marvell.com_&d=DwIFaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKC
> MVsB-fmvgGV3o-g_fjLhk5Pupi9ijohpc&m=s0pyfDe0ZocDrutPG-
> dljjgkODjEcIJ2NEAbull1QXuFTK1wlg4H42nArfxOqW29&s=h8P-
> KWtqiKfO0rinRfnUMFHtuGEFZp2fku5fG6xu3uY&e=
>
>
The CI script which decides the tree to run tests on needs an update when
a series contains a spec change followed by driver implementation,
I submitted the following patch to ci@dpdk.org
https://patches.dpdk.org/project/ci/patch/20230929083443.9925-1-pbhagavatula@marvell.com/
>
> >
> > A collection of event queues linked to an event port can be associated
> > with unique identifier called as a link profile, multiple such profiles
> > can be configured based on the event device capability using the function
> > `rte_event_port_profile_links_set` which takes arguments similar to
> > `rte_event_port_link` in addition to the profile identifier.
> >
> > The maximum link profiles that are supported by an event device is
> > advertised through the structure member
> > `rte_event_dev_info::max_profiles_per_port`.
> >
> > By default, event ports are configured to use the link profile 0 on
> > initialization.
> >
> > Once multiple link profiles are set up and the event device is started, the
> > application can use the function `rte_event_port_profile_switch` to change
> > the currently active profile on an event port. This effects the next
> > `rte_event_dequeue_burst` call, where the event queues associated with
> the
> > newly active link profile will participate in scheduling.
> >
> > Rudementary work flow would something like:
> >
> > Config path:
> >
> > uint8_t lq[4] = {4, 5, 6, 7};
> > uint8_t hq[4] = {0, 1, 2, 3};
> >
> > if (rte_event_dev_info.max_profiles_per_port < 2)
> > return -ENOTSUP;
> >
> > rte_event_port_profile_links_set(0, 0, hq, NULL, 4, 0);
> > rte_event_port_profile_links_set(0, 0, lq, NULL, 4, 1);
> >
> > Worker path:
> >
> > empty_high_deq = 0;
> > empty_low_deq = 0;
> > is_low_deq = 0;
> > while (1) {
> > deq = rte_event_dequeue_burst(0, 0, &ev, 1, 0);
> > if (deq == 0) {
> > /**
> > * Change link profile based on work activity on current
> > * active profile
> > */
> > if (is_low_deq) {
> > empty_low_deq++;
> > if (empty_low_deq == MAX_LOW_RETRY) {
> > rte_event_port_profile_switch(0, 0, 0);
> > is_low_deq = 0;
> > empty_low_deq = 0;
> > }
> > continue;
> > }
> >
> > if (empty_high_deq == MAX_HIGH_RETRY) {
> > rte_event_port_profile_switch(0, 0, 1);
> > is_low_deq = 1;
> > empty_high_deq = 0;
> > }
> > continue;
> > }
> >
> > // Process the event received.
> >
> > if (is_low_deq++ == MAX_LOW_EVENTS) {
> > rte_event_port_profile_switch(0, 0, 0);
> > is_low_deq = 0;
> > }
> > }
> >
> > An application could use heuristic data of load/activity of a given event
> > port and change its active profile to adapt to the traffic pattern.
> >
> > An unlink function `rte_event_port_profile_unlink` is provided to
> > modify the links associated to a profile, and
> > `rte_event_port_profile_links_get` can be used to retrieve the links
> > associated with a profile.
> >
> > Using Link profiles can reduce the overhead of linking/unlinking and
> > waiting for unlinks in progress in fast-path and gives applications
> > the ability to switch between preset profiles on the fly.
> >
> > v4 Changes:
> > ----------
> > - Address review comments (Jerin).
> >
> > v3 Changes:
> > ----------
> > - Rebase to next-eventdev
> > - Rename testcase name to match API.
> >
> > v2 Changes:
> > ----------
> > - Fix compilation.
> >
> > Pavan Nikhilesh (3):
> > eventdev: introduce link profiles
> > event/cnxk: implement event link profiles
> > test/event: add event link profile test
> >
> > app/test/test_eventdev.c | 117 +++++++++++
> > config/rte_config.h | 1 +
> > doc/guides/eventdevs/cnxk.rst | 1 +
> > doc/guides/eventdevs/features/cnxk.ini | 3 +-
> > doc/guides/eventdevs/features/default.ini | 1 +
> > doc/guides/prog_guide/eventdev.rst | 40 ++++
> > doc/guides/rel_notes/release_23_11.rst | 14 +-
> > drivers/common/cnxk/roc_nix_inl_dev.c | 4 +-
> > drivers/common/cnxk/roc_sso.c | 18 +-
> > drivers/common/cnxk/roc_sso.h | 8 +-
> > drivers/common/cnxk/roc_sso_priv.h | 4 +-
> > drivers/event/cnxk/cn10k_eventdev.c | 45 +++--
> > drivers/event/cnxk/cn10k_worker.c | 11 ++
> > drivers/event/cnxk/cn10k_worker.h | 1 +
> > drivers/event/cnxk/cn9k_eventdev.c | 74 ++++---
> > drivers/event/cnxk/cn9k_worker.c | 22 +++
> > drivers/event/cnxk/cn9k_worker.h | 2 +
> > drivers/event/cnxk/cnxk_eventdev.c | 37 ++--
> > drivers/event/cnxk/cnxk_eventdev.h | 10 +-
> > lib/eventdev/eventdev_pmd.h | 59 +++++-
> > lib/eventdev/eventdev_private.c | 9 +
> > lib/eventdev/eventdev_trace.h | 32 +++
> > lib/eventdev/eventdev_trace_points.c | 12 ++
> > lib/eventdev/rte_eventdev.c | 150 +++++++++++---
> > lib/eventdev/rte_eventdev.h | 231 ++++++++++++++++++++++
> > lib/eventdev/rte_eventdev_core.h | 6 +-
> > lib/eventdev/rte_eventdev_trace_fp.h | 8 +
> > lib/eventdev/version.map | 4 +
> > 28 files changed, 814 insertions(+), 110 deletions(-)
> >
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2023-09-29 9:27 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 14:26 [RFC " pbhagavatula
2023-08-09 14:26 ` [RFC 1/3] eventdev: introduce " pbhagavatula
2023-08-18 10:27 ` Jerin Jacob
2023-08-09 14:26 ` [RFC 2/3] event/cnxk: implement event " pbhagavatula
2023-08-09 14:26 ` [RFC 3/3] test/event: add event link profile test pbhagavatula
2023-08-09 19:45 ` [RFC 0/3] Introduce event link profiles Mattias Rönnblom
2023-08-10 5:17 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-08-12 5:52 ` Mattias Rönnblom
2023-08-14 11:29 ` Pavan Nikhilesh Bhagavatula
2023-08-25 18:44 ` [PATCH " pbhagavatula
2023-08-25 18:44 ` [PATCH 1/3] eventdev: introduce " pbhagavatula
2023-08-25 18:44 ` [PATCH 2/3] event/cnxk: implement event " pbhagavatula
2023-08-25 18:44 ` [PATCH 3/3] test/event: add event link profile test pbhagavatula
2023-08-31 20:44 ` [PATCH v2 0/3] Introduce event link profiles pbhagavatula
2023-08-31 20:44 ` [PATCH v2 1/3] eventdev: introduce " pbhagavatula
2023-09-20 4:22 ` Jerin Jacob
2023-08-31 20:44 ` [PATCH v2 2/3] event/cnxk: implement event " pbhagavatula
2023-08-31 20:44 ` [PATCH v2 3/3] test/event: add event link profile test pbhagavatula
2023-09-21 10:28 ` [PATCH v3 0/3] Introduce event link profiles pbhagavatula
2023-09-21 10:28 ` [PATCH v3 1/3] eventdev: introduce " pbhagavatula
2023-09-27 15:23 ` Jerin Jacob
2023-09-21 10:28 ` [PATCH v3 2/3] event/cnxk: implement event " pbhagavatula
2023-09-27 15:29 ` Jerin Jacob
2023-09-21 10:28 ` [PATCH v3 3/3] test/event: add event link profile test pbhagavatula
2023-09-27 14:56 ` [PATCH v3 0/3] Introduce event link profiles Jerin Jacob
2023-09-28 10:12 ` [PATCH v4 " pbhagavatula
2023-09-28 10:12 ` [PATCH v4 1/3] eventdev: introduce " pbhagavatula
2023-10-03 6:55 ` Jerin Jacob
2023-09-28 10:12 ` [PATCH v4 2/3] event/cnxk: implement event " pbhagavatula
2023-09-28 10:12 ` [PATCH v4 3/3] test/event: add event link profile test pbhagavatula
2023-09-28 14:45 ` [PATCH v4 0/3] Introduce event link profiles Jerin Jacob
2023-09-29 9:27 ` Pavan Nikhilesh Bhagavatula [this message]
2023-10-03 7:51 ` [PATCH v5 " pbhagavatula
2023-10-03 7:51 ` [PATCH v5 1/3] eventdev: introduce " pbhagavatula
2023-10-03 7:51 ` [PATCH v5 2/3] event/cnxk: implement event " pbhagavatula
2023-10-03 7:51 ` [PATCH v5 3/3] test/event: add event link profile test pbhagavatula
2023-10-03 9:47 ` [PATCH v6 0/3] Introduce event link profiles pbhagavatula
2023-10-03 9:47 ` [PATCH v6 1/3] eventdev: introduce " pbhagavatula
2023-10-03 9:47 ` [PATCH v6 2/3] event/cnxk: implement event " pbhagavatula
2023-10-03 9:47 ` [PATCH v6 3/3] test/event: add event link profile test pbhagavatula
2023-10-03 10:36 ` [PATCH v6 0/3] Introduce event link profiles Jerin Jacob
2023-10-03 14:12 ` Bruce Richardson
2023-10-03 15:17 ` Jerin Jacob
2023-10-03 15:32 ` [EXT] " Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB408622CE89C8A373121B8BE5DEC0A@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=abhinandan.gujjar@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=liangma@liangbit.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=peter.mccarthy@intel.com \
--cc=s.v.naga.harish.k@intel.com \
--cc=sachin.saxena@nxp.com \
--cc=sthotton@marvell.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).