From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
To: "Yan, Zhirun" <zhirun.yan@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [24.11 PATCH v3 1/5] graph: add support for node specific errors
Date: Mon, 26 Feb 2024 07:49:59 +0000 [thread overview]
Message-ID: <PH0PR18MB4086B44FD6CE994EAE52887FDE5A2@PH0PR18MB4086.namprd18.prod.outlook.com> (raw)
In-Reply-To: <SN7PR11MB677559FE8167DCBAB300320985552@SN7PR11MB6775.namprd11.prod.outlook.com>
> > -----Original Message-----
> > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > Sent: Thursday, February 22, 2024 8:24 PM
> > To: jerinj@marvell.com; ndabilpuram@marvell.com;
> kirankumark@marvell.com;
> > Yan, Zhirun <zhirun.yan@intel.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> > Subject: [24.11 PATCH v3 1/5] graph: add support for node specific errors
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Add ability for Nodes to advertise error counters
> > during registration.
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> > v2 Changes:
> > - Fix compilation.
> > v3 Changes:
> > - Resend as 1/5 didn't make it through.
> >
> > doc/guides/prog_guide/graph_lib.rst | 22 +-
> > .../prog_guide/img/anatomy_of_a_node.svg | 329 +++++--
> > .../prog_guide/img/graph_mem_layout.svg | 921 +++++++++++++-----
> > lib/graph/graph_private.h | 1 +
> > lib/graph/node.c | 37 +-
> > lib/graph/rte_graph.h | 7 +
> > 6 files changed, 1016 insertions(+), 301 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/graph_lib.rst
> > b/doc/guides/prog_guide/graph_lib.rst
> > index ad09bdfe26..018900caea 100644
> > --- a/doc/guides/prog_guide/graph_lib.rst
> > +++ b/doc/guides/prog_guide/graph_lib.rst
> > @@ -21,6 +21,7 @@ Features of the Graph library are:
> > - Nodes as plugins.
> > - Support for out of tree nodes.
> > - Inbuilt nodes for packet processing.
> > +- Node specific error counts.
> > - Multi-process support.
> > - Low overhead graph walk and node enqueue.
> > - Low overhead statistics collection infrastructure.
> > @@ -124,6 +125,18 @@ Source nodes are static nodes created using
> > ``RTE_NODE_REGISTER`` by passing
> > While performing the graph walk, the ``process()`` function of all the source
> > nodes will be called first. So that these nodes can be used as input nodes for
> a
> > graph.
> >
> > +nb_errors:
> > +^^^^^^^^^^
> > +
> > +The number of errors that this node can report. The ``err_desc[]`` stores the
> > error
> > +descriptions which will later be propagated to stats.
> > +
> > +err_desc[]:
> > +^^^^^^^^^^^
> > +
> > +The dynamic array to store the error descriptions that will be reported by
> this
> > +node.
>
> If there are no more detail infos reported by node, why not reuse the node-
> >name directly.
>
The nodes can describe the errors they encounter in detail, and depending on how
complex the node is it can have multiple kinds of errors.
> > +
> > Node creation and registration
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > * Node implementer creates the node by implementing ops and attributes
> of
> > @@ -141,13 +154,13 @@ Link the Nodes to create the graph topology
> > Topology after linking the nodes
> >
> > Once nodes are available to the program, Application or node public API
> > -functions can links them together to create a complex packet processing
> graph.
> > +functions can link them together to create a complex packet processing
> graph.
> >
> > There are multiple different types of strategies to link the nodes.
> >
> > Method (a):
> > ^^^^^^^^^^^
> > -Provide the ``next_nodes[]`` at the node registration time. See ``struct
> > rte_node_register::nb_edges``.
> > +Provide the ``next_nodes[]`` at the node registration time. See ``struct
> > rte_node_register::nb_edges``.
>
> No need to change this line.
prev parent reply other threads:[~2024-02-26 7:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 16:26 [PATCH " pbhagavatula
2024-02-21 16:26 ` [PATCH 2/5] graph: add node fastpath error counters pbhagavatula
2024-02-21 16:26 ` [PATCH 3/5] graph: add stats for node specific errors pbhagavatula
2024-02-21 16:26 ` [PATCH 4/5] node: add error stats for ip4 lookup node pbhagavatula
2024-02-21 16:26 ` [PATCH 5/5] node: add error stats for ip4 reassembly node pbhagavatula
2024-02-22 5:36 ` [24.11 PATCH v2 1/5] graph: add support for node specific errors pbhagavatula
2024-02-22 5:36 ` [24.11 PATCH v2 2/5] graph: add node fastpath error counters pbhagavatula
2024-02-22 5:36 ` [24.11 PATCH v2 3/5] graph: add stats for node specific errors pbhagavatula
2024-02-22 5:36 ` [24.11 PATCH v2 4/5] node: add error stats for ip4 lookup node pbhagavatula
2024-02-22 5:36 ` [24.11 PATCH v2 5/5] node: add error stats for ip4 reassembly node pbhagavatula
2024-02-22 12:23 ` [24.11 PATCH v3 1/5] graph: add support for node specific errors pbhagavatula
2024-02-22 12:23 ` [24.11 PATCH v3 2/5] graph: add node fastpath error counters pbhagavatula
2024-02-23 7:15 ` Yan, Zhirun
2024-02-22 12:23 ` [24.11 PATCH v3 3/5] graph: add stats for node specific errors pbhagavatula
2024-02-22 12:23 ` [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node pbhagavatula
2024-02-23 7:18 ` Yan, Zhirun
2024-02-26 7:46 ` Pavan Nikhilesh Bhagavatula
2024-02-22 12:23 ` [24.11 PATCH v3 5/5] node: add error stats for ip4 reassembly node pbhagavatula
2024-02-23 7:13 ` [24.11 PATCH v3 1/5] graph: add support for node specific errors Yan, Zhirun
2024-02-26 7:49 ` Pavan Nikhilesh Bhagavatula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4086B44FD6CE994EAE52887FDE5A2@PH0PR18MB4086.namprd18.prod.outlook.com \
--to=pbhagavatula@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).