From: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>,
fengchengwen <fengchengwen@huawei.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>
Subject: RE: [EXT] Re: [PATCH] app/testpmd: add command to get Tx queue used count
Date: Mon, 29 Jan 2024 11:59:36 +0000 [thread overview]
Message-ID: <PH0PR18MB44090B7B6AF72731DF8D5224C17E2@PH0PR18MB4409.namprd18.prod.outlook.com> (raw)
In-Reply-To: <b1d4bcac-b9dc-47f4-88b3-eacc2c58d9a4@amd.com>
>>
>> ---------------------------------------------------------------------
>> - Please doc this command in
>> doc/guides/testpmd_app_ug/testpmd_funcs.rst
>>
>
> Thanks, will update in next version
>
>>
>> Also why not extend "show port rxq xxx" command to support txq ?
>
> txq and rxq are different directions, so extended "show port " command to support txq similar to rxq command. Could you please give more details if I missed something here.
>
There is an existing "show port <port_id> rxq <queue_id> desc used count" command, which is for Rx.
As you are adding support for Tx, instead of adding it as a new command, existing 'cmd_show_rx_queue_desc_used_count_parsed()' can be extended to support both Rx and Tx.
You can check 'cmd_show_rx_tx_desc_status_parsed()' as sample.
This also helps to have a unified syntax for Rx and Tx, as your version is slightly diverging from the Rx one.
And please update 'cmd_help_long_parsed()' help string with relevant change.
>>> Thanks Ferruh, will update unified command for Rx/Tx in next version.
next prev parent reply other threads:[~2024-01-29 11:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 12:18 skoteshwar
2024-01-25 13:01 ` fengchengwen
2024-01-29 6:37 ` [EXT] " Satha Koteswara Rao Kottidi
2024-01-29 11:55 ` Ferruh Yigit
2024-01-29 11:59 ` Satha Koteswara Rao Kottidi [this message]
2024-02-01 13:52 ` [PATCH v2] app/testpmd: command to get descriptor " skoteshwar
2024-02-06 23:10 ` Ferruh Yigit
2024-02-07 17:04 ` [PATCH v3] " skoteshwar
2024-02-07 18:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB44090B7B6AF72731DF8D5224C17E2@PH0PR18MB4409.namprd18.prod.outlook.com \
--to=skoteshwar@marvell.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).