From: Shijith Thotton <sthotton@marvell.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [EXT] Re: [PATCH v3 0/5] mbuf dynamic field expansion
Date: Thu, 29 Sep 2022 04:51:53 +0000 [thread overview]
Message-ID: <PH0PR18MB44258E3388F55E75FA6AF1C9D9579@PH0PR18MB4425.namprd18.prod.outlook.com> (raw)
In-Reply-To: <YzRDhLmvuLL0x6wn@platinum>
Hi Olivier,
Thanks for the review.
>On Wed, Sep 21, 2022 at 07:26:16PM +0530, Shijith Thotton wrote:
>> This is a continuation of the discussions[1] to add mbuf physical address field to
>dynamic field.
>> Previous version was to add PA field to dynamic field area based on the EAL
>IOVA mode option. It was
>> deemed unsafe as some components could still use the PA field without
>checking IOVA mode and there
>> are drivers which need PA to work. One suggestion was to make the IOVA mode
>check at compile time so
>> that drivers which need PA can be disabled during build. This series adds this
>new meson build
>> options. Second patch adds mbuf PA field to dynamic field on such builds. Last
>two patches enable
>> Marvell cnxk PMDs and software PMDs in IOVA as VA build as they work without
>PA field.
>
>Thank you for this patchset.
>
>To be honnest, initially I was really reserved to remove the use of
>buf_iova for some specific platforms.
>
>But what made me change my mind is that the removal if buf_iova will
>likely happen in the long-term future. It looks there is a consensus on
>this. I think your patchset is a good way to prepare this transition.
>
>What is missing, I think, is a good description of the problem you are
>solving:
>
>- more space for dynamic mbuf fields -> why? can you give more detail about
> this need?
Idea was to let app/lib use an additional 8-bytes of dynamic area.
>- increase performance -> you previously said that it was not your point,
> but if we move the next field into the first cache line, I think this
> has to be highlighted. Out of curiosity, did you made measurements?
>
I'm yet to do it. I will update, once I have the numbers.
>>
>> 1. https://urldefense.proofpoint.com/v2/url?u=https-
>3A__inbox.dpdk.org_dev_57d2ab7fff672716d37ba4078e2e3bb2db126607.1656605
>763.git.sthotton-
>40marvell.com_&d=DwIBAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=G9w4KsPaQLACBf
>GCL35PtiRH996yqJDxAZwrWegU2qQ&m=O9JeIb0lfExyVnC8dV3WUADowh165KkS
>3s9JrmAjLwj8Uw5Iyb0tqSQ9YvQWpbIc&s=DaHEYGwUqUmAFmQ9Jkj8jGnOS4aw8
>iZ8Tcww-jPTdFE&e= .
>>
>> v3:
>> * Cleared use of buf_iova from cnxk PMD.
>>
>> v2:
>> * Used RTE_IOVA_AS_VA instread of rte_is_iova_as_va_build().
>> * Moved mbuf next pointer to first cacheline if RTE_IOVA_AS_VA = 1.
>>
>> Shijith Thotton (5):
>> build: add meson option to configure IOVA mode as VA
>> mbuf: add second dynamic field member for VA only build
>> lib: move mbuf next pointer to first cache line
>> drivers: mark Marvell cnxk PMDs work with IOVA as VA
>> drivers: mark software PMDs work with IOVA as VA
>>
>> app/test-bbdev/test_bbdev_perf.c | 2 +-
>> app/test-crypto-perf/cperf_test_common.c | 5 +--
>> app/test/test_bpf.c | 2 +-
>> app/test/test_dmadev.c | 33 ++++++--------
>> app/test/test_mbuf.c | 12 +++---
>> app/test/test_pcapng.c | 2 +-
>> config/arm/meson.build | 8 +++-
>> config/meson.build | 1 +
>> drivers/common/cnxk/meson.build | 1 +
>> drivers/crypto/armv8/meson.build | 1 +
>> drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 4 +-
>> drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 2 +-
>> drivers/crypto/cnxk/meson.build | 2 +
>> drivers/crypto/ipsec_mb/meson.build | 1 +
>> drivers/crypto/null/meson.build | 1 +
>> drivers/crypto/openssl/meson.build | 1 +
>> drivers/dma/cnxk/meson.build | 1 +
>> drivers/dma/skeleton/meson.build | 1 +
>> drivers/event/cnxk/meson.build | 1 +
>> drivers/event/dsw/meson.build | 1 +
>> drivers/event/opdl/meson.build | 1 +
>> drivers/event/skeleton/meson.build | 1 +
>> drivers/event/sw/meson.build | 1 +
>> drivers/mempool/bucket/meson.build | 1 +
>> drivers/mempool/cnxk/meson.build | 1 +
>> drivers/mempool/ring/meson.build | 1 +
>> drivers/mempool/stack/meson.build | 1 +
>> drivers/meson.build | 6 +++
>> drivers/net/af_packet/meson.build | 1 +
>> drivers/net/af_xdp/meson.build | 2 +
>> drivers/net/bonding/meson.build | 1 +
>> drivers/net/cnxk/cn10k_tx.h | 55 +++++++-----------------
>> drivers/net/cnxk/cn9k_tx.h | 55 +++++++-----------------
>> drivers/net/cnxk/cnxk_ethdev.h | 1 -
>> drivers/net/cnxk/meson.build | 1 +
>> drivers/net/failsafe/meson.build | 1 +
>> drivers/net/memif/meson.build | 1 +
>> drivers/net/null/meson.build | 1 +
>> drivers/net/pcap/meson.build | 1 +
>> drivers/net/ring/meson.build | 1 +
>> drivers/net/tap/meson.build | 1 +
>> drivers/raw/cnxk_bphy/meson.build | 1 +
>> drivers/raw/cnxk_gpio/meson.build | 1 +
>> drivers/raw/skeleton/meson.build | 1 +
>> lib/eal/linux/eal.c | 7 +++
>> lib/mbuf/rte_mbuf.c | 8 ++--
>> lib/mbuf/rte_mbuf.h | 17 +++++---
>> lib/mbuf/rte_mbuf_core.h | 55 ++++++++++++++++++------
>> lib/mbuf/rte_mbuf_dyn.c | 2 +
>> lib/meson.build | 3 ++
>> lib/vhost/vhost.h | 2 +-
>> lib/vhost/vhost_crypto.c | 54 +++++++++++++++++------
>> meson_options.txt | 2 +
>> 53 files changed, 220 insertions(+), 150 deletions(-)
>>
>> --
>> 2.25.1
>>
next prev parent reply other threads:[~2022-09-29 4:52 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 16:25 [PATCH] mbuf: add mbuf physical address field to dynamic field Shijith Thotton
2022-06-30 16:45 ` Stephen Hemminger
2022-07-01 12:16 ` Shijith Thotton
2022-07-01 12:24 ` Shijith Thotton
2022-07-03 7:31 ` Morten Brørup
2022-07-04 14:00 ` Bruce Richardson
2022-08-03 15:34 ` [EXT] " Shijith Thotton
2022-08-29 15:16 ` [PATCH v1 0/4] mbuf dynamic field expansion Shijith Thotton
2022-09-07 13:43 ` [PATCH v2 0/5] " Shijith Thotton
2022-09-21 9:43 ` David Marchand
2022-09-21 14:01 ` [EXT] " Shijith Thotton
2022-09-21 13:56 ` [PATCH v3 " Shijith Thotton
2022-09-21 13:56 ` [PATCH v3 1/5] build: add meson option to configure IOVA mode as VA Shijith Thotton
2022-09-28 12:52 ` Olivier Matz
2022-09-29 5:48 ` [EXT] " Shijith Thotton
2022-09-21 13:56 ` [PATCH v3 2/5] mbuf: add second dynamic field member for VA only build Shijith Thotton
2022-09-28 7:24 ` Thomas Monjalon
2022-09-28 12:52 ` Olivier Matz
2022-09-28 19:33 ` Thomas Monjalon
2022-09-28 19:48 ` Stephen Hemminger
2022-09-29 6:13 ` [EXT] " Shijith Thotton
2022-09-28 12:52 ` Olivier Matz
2022-09-21 13:56 ` [PATCH v3 3/5] lib: move mbuf next pointer to first cache line Shijith Thotton
2022-09-21 14:07 ` Morten Brørup
2022-09-28 12:52 ` Olivier Matz
2022-09-29 6:14 ` [EXT] " Shijith Thotton
2022-09-21 13:56 ` [PATCH v3 4/5] drivers: mark Marvell cnxk PMDs work with IOVA as VA Shijith Thotton
2022-09-28 12:53 ` Olivier Matz
2022-09-29 6:19 ` [EXT] " Shijith Thotton
2022-09-29 7:44 ` Olivier Matz
2022-09-29 8:10 ` Shijith Thotton
2022-10-07 20:17 ` Olivier Matz
2022-10-07 20:22 ` [EXT] " Shijith Thotton
2022-09-21 13:56 ` [PATCH v3 5/5] drivers: mark software " Shijith Thotton
2022-09-28 5:41 ` [PATCH v3 0/5] mbuf dynamic field expansion Shijith Thotton
2022-09-28 12:52 ` Olivier Matz
2022-09-29 4:51 ` Shijith Thotton [this message]
2022-10-07 13:50 ` Thomas Monjalon
2022-10-07 19:35 ` [EXT] " Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 0/7] " Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 1/7] mbuf: add API to get and set mbuf physical address Shijith Thotton
2022-10-07 20:16 ` Olivier Matz
2022-10-07 20:20 ` [EXT] " Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 2/7] test/dma: use API to get mbuf data " Shijith Thotton
2022-10-07 20:17 ` Olivier Matz
2022-10-07 19:30 ` [PATCH v4 3/7] build: add meson option to configure IOVA mode as PA Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 4/7] mbuf: add second dynamic field member Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 5/7] lib: move mbuf next pointer to first cache line Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 6/7] drivers: mark cnxk PMDs work with IOVA as PA disabled Shijith Thotton
2022-10-07 19:30 ` [PATCH v4 7/7] drivers: mark software " Shijith Thotton
2022-10-07 20:19 ` [PATCH v4 0/7] mbuf dynamic field expansion Olivier Matz
2022-10-07 21:02 ` [PATCH v5 " Shijith Thotton
2022-10-07 21:02 ` [PATCH v5 1/7] mbuf: add API to get and set mbuf physical address Shijith Thotton
2022-10-07 21:20 ` Stephen Hemminger
2022-10-07 21:02 ` [PATCH v5 2/7] test/dma: use API to get mbuf data " Shijith Thotton
2022-10-07 21:02 ` [PATCH v5 3/7] build: add meson option to configure IOVA mode as PA Shijith Thotton
2022-10-07 21:02 ` [PATCH v5 4/7] mbuf: add second dynamic field member Shijith Thotton
2022-10-07 21:02 ` [PATCH v5 5/7] lib: move mbuf next pointer to first cache line Shijith Thotton
2022-10-07 21:22 ` Stephen Hemminger
2022-10-07 21:30 ` [EXT] " Shijith Thotton
2022-10-07 21:02 ` [PATCH v5 6/7] drivers: mark cnxk PMDs work with IOVA as PA disabled Shijith Thotton
2022-10-07 21:02 ` [PATCH v5 7/7] drivers: mark software " Shijith Thotton
2022-10-09 9:34 ` [PATCH v5 0/7] mbuf dynamic field expansion Thomas Monjalon
2022-09-07 13:43 ` [PATCH v2 1/5] build: add meson option to configure IOVA mode as VA Shijith Thotton
2022-09-07 15:31 ` Stephen Hemminger
2022-09-07 15:38 ` Bruce Richardson
2022-09-07 21:33 ` Morten Brørup
2022-09-07 13:43 ` [PATCH v2 2/5] mbuf: add second dynamic field member for VA only build Shijith Thotton
2022-09-07 13:43 ` [PATCH v2 3/5] lib: move mbuf next pointer to first cache line Shijith Thotton
2022-09-07 13:43 ` [PATCH v2 4/5] drivers: mark Marvell cnxk PMDs work with IOVA as VA Shijith Thotton
2022-09-07 13:43 ` [PATCH v2 5/5] drivers: mark software " Shijith Thotton
2022-08-29 15:16 ` [PATCH v1 1/4] build: add meson option to configure IOVA mode " Shijith Thotton
2022-08-29 18:18 ` Morten Brørup
2022-08-30 8:32 ` Bruce Richardson
2022-08-29 15:16 ` [PATCH v1 2/4] mbuf: add second dynamic field member for VA only build Shijith Thotton
2022-08-29 18:32 ` Morten Brørup
2022-08-30 8:35 ` Bruce Richardson
2022-08-30 8:41 ` [EXT] " Pavan Nikhilesh Bhagavatula
2022-08-30 13:22 ` Honnappa Nagarahalli
2022-09-07 13:55 ` Shijith Thotton
2022-08-29 15:16 ` [PATCH v1 3/4] drivers: mark Marvell cnxk PMDs work with IOVA as VA Shijith Thotton
2022-08-29 15:16 ` [PATCH v1 4/4] drivers: mark software " Shijith Thotton
2022-08-30 13:07 ` [PATCH] mbuf: add mbuf physical address field to dynamic field Ferruh Yigit
2022-09-12 13:19 ` [EXT] " Shijith Thotton
2022-06-30 16:55 ` Bruce Richardson
2022-07-01 9:48 ` Olivier Matz
2022-07-01 11:53 ` Slava Ovsiienko
2022-07-01 12:01 ` [EXT] " Shijith Thotton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB44258E3388F55E75FA6AF1C9D9579@PH0PR18MB4425.namprd18.prod.outlook.com \
--to=sthotton@marvell.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).