From: Shijith Thotton <sthotton@marvell.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
David Christensen <drc@linux.vnet.ibm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXT] [PATCH v5 1/5] examples/l3fwd: fix port group mask generation
Date: Mon, 17 Oct 2022 12:05:49 +0000 [thread overview]
Message-ID: <PH0PR18MB4425D32F72D17F2EF5125AE8D9299@PH0PR18MB4425.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20221011101207.4489-1-pbhagavatula@marvell.com>
[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]
>
>Fix port group mask generation in altivec, vec_any_eq returns
>0 or 1 while port_groupx4 expects comparison mask result.
>
>Fixes: 2193b7467f7a ("examples/l3fwd: optimize packet processing on powerpc")
>Cc: stable@dpdk.org
>
>Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Shijith Thotton <sthotton@marvell.com>
>---
> v5 Changes:
> - Fix compilation errors.
>
> v4 Changes:
> - Fix missing `rte_free`.
>
> v3 Changes:
> - PPC optimize port mask generation.
> - Fix aarch32 compilation.
>
> v2 Changes:
> - Fix PPC, RISC-V, aarch32 compilation.
>
> examples/common/altivec/port_group.h | 11 ++++++++---
> 1 file changed, 8 insertions(+), 3 deletions(-)
>
>diff --git a/examples/common/altivec/port_group.h
>b/examples/common/altivec/port_group.h
>index 5e209b02fa..1c05bc025a 100644
>--- a/examples/common/altivec/port_group.h
>+++ b/examples/common/altivec/port_group.h
>@@ -26,12 +26,17 @@ port_groupx4(uint16_t pn[FWDSTEP + 1], uint16_t *lp,
> uint16_t u16[FWDSTEP + 1];
> uint64_t u64;
> } *pnum = (void *)pn;
>-
>+ __vector unsigned long long result;
>+ const __vector unsigned int perm_mask = {0x00204060, 0x80808080,
>+ 0x80808080, 0x80808080};
> int32_t v;
>
>- v = vec_any_eq(dp1, dp2);
>-
>+ dp1 = (__vector unsigned short)vec_cmpeq(dp1, dp2);
>+ dp1 = vec_mergeh(dp1, dp1);
>+ result = (__vector unsigned long long)vec_vbpermq(
>+ (__vector unsigned char)dp1, (__vector unsigned
>char)perm_mask);
>
>+ v = result[1];
> /* update last port counter. */
> lp[0] += gptbl[v].lpv;
>
>--
>2.25.1
[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 14616 bytes --]
next prev parent reply other threads:[~2022-10-17 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 9:44 [PATCH " pbhagavatula
2022-09-02 9:18 ` [PATCH v2 " pbhagavatula
2022-09-08 18:33 ` David Christensen
2022-09-09 5:56 ` [EXT] " Pavan Nikhilesh Bhagavatula
2022-09-11 18:12 ` [PATCH v3 " pbhagavatula
2022-10-11 9:08 ` [PATCH v4 " pbhagavatula
2022-10-11 10:12 ` [PATCH v5 " pbhagavatula
2022-10-17 12:05 ` Shijith Thotton [this message]
2022-10-20 16:15 ` [EXT] " Pavan Nikhilesh Bhagavatula
2022-10-25 16:05 ` [PATCH v6 " pbhagavatula
2022-10-31 14:52 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4425D32F72D17F2EF5125AE8D9299@PH0PR18MB4425.namprd18.prod.outlook.com \
--to=sthotton@marvell.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).