From: Anoob Joseph <anoobj@marvell.com>
To: Ciara Power <ciara.power@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
Akhil Goyal <gakhil@marvell.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>,
Declan Doherty <declan.doherty@intel.com>
Subject: RE: [EXT] [PATCH v2 3/4] crypto: add asym session user data API
Date: Mon, 31 Jan 2022 14:46:30 +0000 [thread overview]
Message-ID: <PH0PR18MB4672CC4927B56D5E7B2EEF98DF259@PH0PR18MB4672.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220124150339.280090-4-ciara.power@intel.com>
Hi Ciara,
Minor nits inline.
Acked-by: Anoob Joseph <anoobj@marvell.com>
Thanks,
Anoob
> -----Original Message-----
> From: Ciara Power <ciara.power@intel.com>
> Sent: Monday, January 24, 2022 8:34 PM
> To: dev@dpdk.org
> Cc: roy.fan.zhang@intel.com; Akhil Goyal <gakhil@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; mdr@ashroe.eu; Ciara Power
> <ciara.power@intel.com>; Declan Doherty <declan.doherty@intel.com>
> Subject: [EXT] [PATCH v2 3/4] crypto: add asym session user data API
>
> External Email
>
> ----------------------------------------------------------------------
> A user data field is added to the asymmetric session structure.
> Relevant API added to get/set the field.
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> ---
> v2: Corrected order of version map entries.
> ---
> app/test/test_cryptodev_asym.c | 2 +-
> lib/cryptodev/cryptodev_pmd.h | 4 ++-
> lib/cryptodev/rte_cryptodev.c | 39 ++++++++++++++++++++++++++---
> lib/cryptodev/rte_cryptodev.h | 34 ++++++++++++++++++++++++-
> lib/cryptodev/rte_cryptodev_trace.h | 3 ++-
> lib/cryptodev/version.map | 2 ++
> 6 files changed, 76 insertions(+), 8 deletions(-)
>
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
> index f93f39af42..a81d6292f6 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
> @@ -897,7 +897,7 @@ testsuite_setup(void)
> }
>
> ts_params->session_mpool =
> rte_cryptodev_asym_session_pool_create(
> - "test_asym_sess_mp", TEST_NUM_SESSIONS * 2, 0,
> + "test_asym_sess_mp", TEST_NUM_SESSIONS * 2, 0, 0,
> SOCKET_ID_ANY);
>
> TEST_ASSERT_NOT_NULL(ts_params->session_mpool,
> diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h
> index 2d12505d3c..a0f7bb0c05 100644
> --- a/lib/cryptodev/cryptodev_pmd.h
> +++ b/lib/cryptodev/cryptodev_pmd.h
> @@ -636,7 +636,9 @@ __extension__ struct rte_cryptodev_asym_session {
> /**< Session driver ID. */
> uint8_t max_priv_session_sz;
> /**< size of private session data used when creating mempool */
> - uint8_t padding[6];
> + uint16_t user_data_sz;
> + /**< session user data will be placed after sess_data */
[Anoob] The formatting of comments is slightly inconsistent here. Like "Session driver ID." v/s "session user data.." For the line you are adding do you mind making S capital? Same comment below as well.
> + uint8_t padding[4];
> uint8_t sess_private_data[0];
> };
>
> diff --git a/lib/cryptodev/rte_cryptodev.c b/lib/cryptodev/rte_cryptodev.c index
> c10b9bf05f..2a591930de 100644
> --- a/lib/cryptodev/rte_cryptodev.c
> +++ b/lib/cryptodev/rte_cryptodev.c
> @@ -210,6 +210,8 @@ struct rte_cryptodev_sym_session_pool_private_data {
> struct rte_cryptodev_asym_session_pool_private_data {
> uint8_t max_priv_session_sz;
> /**< size of private session data used when creating mempool */
> + uint16_t user_data_sz;
> + /**< session user data will be placed after sess_private_data */
> };
>
> int
> @@ -1803,7 +1805,7 @@ rte_cryptodev_sym_session_pool_create(const char
> *name, uint32_t nb_elts,
>
next prev parent reply other threads:[~2022-01-31 14:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-24 15:03 [PATCH v2 0/4] crypto: improve asym session usage Ciara Power
2022-01-24 15:03 ` [PATCH v2 1/4] crypto: use single buffer for asymmetric session Ciara Power
2022-01-27 11:03 ` Zhang, Roy Fan
2022-01-24 15:03 ` [PATCH v2 2/4] crypto: hide asym session structure Ciara Power
2022-01-27 11:04 ` Zhang, Roy Fan
2022-01-24 15:03 ` [PATCH v2 3/4] crypto: add asym session user data API Ciara Power
2022-01-27 11:05 ` Zhang, Roy Fan
2022-01-31 14:46 ` Anoob Joseph [this message]
2022-01-24 15:03 ` [PATCH v2 4/4] crypto: modify return value for asym session create Ciara Power
2022-01-27 11:06 ` Zhang, Roy Fan
2022-01-31 14:35 ` [EXT] " Anoob Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4672CC4927B56D5E7B2EEF98DF259@PH0PR18MB4672.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=ciara.power@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=mdr@ashroe.eu \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).