From: Anoob Joseph <anoobj@marvell.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: Ashwin Sekhar T K <asekhar@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
Akhil Goyal <gakhil@marvell.com>,
Gagandeep Singh <g.singh@nxp.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
Kai Ji <kai.ji@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Matan Azrad <matan@nvidia.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>,
Fan Zhang <fanzhang.oss@gmail.com>
Subject: RE: [PATCH] cryptodev: increase default max nb queue pairs
Date: Tue, 10 Jan 2023 07:07:20 +0000 [thread overview]
Message-ID: <PH0PR18MB4672E4F96687052BF74BE030DFFF9@PH0PR18MB4672.namprd18.prod.outlook.com> (raw)
In-Reply-To: <AS8PR08MB708029FE620B78BDE138140C9EFF9@AS8PR08MB7080.eurprd08.prod.outlook.com>
Hi Ruifeng,
> Crypto device has devargs "max_nb_queue_pairs" which can be used to change
> queue pairs limit at init time.
> Then no need to increase the default value?
Yes. Thanks for the pointer. This field would suffice for the issue that I'm trying to fix.
Thanks,
Anoob
> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Tuesday, January 10, 2023 12:12 PM
> To: Anoob Joseph <anoobj@marvell.com>; Akhil Goyal <gakhil@marvell.com>;
> Gagandeep Singh <g.singh@nxp.com>; hemant.agrawal@nxp.com; Kai Ji
> <kai.ji@intel.com>; Pablo de Lara <pablo.de.lara.guarch@intel.com>; Matan
> Azrad <matan@nvidia.com>; Zhangfei Gao <zhangfei.gao@linaro.org>; Fan
> Zhang <fanzhang.oss@gmail.com>
> Cc: Ashwin Sekhar T K <asekhar@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; dev@dpdk.org; nd <nd@arm.com>
> Subject: [EXT] RE: [PATCH] cryptodev: increase default max nb queue pairs
>
> External Email
>
> ----------------------------------------------------------------------
> > -----Original Message-----
> > From: Anoob Joseph <anoobj@marvell.com>
> > Sent: Wednesday, January 4, 2023 3:30 PM
> > To: Akhil Goyal <gakhil@marvell.com>; Ruifeng Wang
> > <Ruifeng.Wang@arm.com>; Gagandeep Singh <g.singh@nxp.com>;
> > hemant.agrawal@nxp.com; Kai Ji <kai.ji@intel.com>; Pablo de Lara
> > <pablo.de.lara.guarch@intel.com>; Matan Azrad <matan@nvidia.com>;
> > Zhangfei Gao <zhangfei.gao@linaro.org>; Fan Zhang
> > <fanzhang.oss@gmail.com>
> > Cc: Ashwin Sekhar T K <asekhar@marvell.com>; jerinj@marvell.com;
> > dev@dpdk.org
> > Subject: [PATCH] cryptodev: increase default max nb queue pairs
> >
> > Increase default maximum number of queue pairs to 64. For sw crypto
> > PMDs, the number of queue pairs can be increased as required. The
> > default value (which is set to 8), prevents usage of sw cryptodev PMDs with
> larger number of cores.
> >
> > Application would be allowed to specify the number of queue pairs it
> > wishes to use. Only the upper bound is changed from 8 to 64.
> >
> > Allow PMDs such as crypto_armv8 to run on larger number of cores.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> > lib/cryptodev/cryptodev_pmd.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/cryptodev/cryptodev_pmd.h
> > b/lib/cryptodev/cryptodev_pmd.h index
> > 0020102eb7..913a8f3623 100644
> > --- a/lib/cryptodev/cryptodev_pmd.h
> > +++ b/lib/cryptodev/cryptodev_pmd.h
> > @@ -29,7 +29,7 @@ extern "C" {
> > #include "rte_cryptodev.h"
> >
> >
> > -#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS 8
> > +#define RTE_CRYPTODEV_PMD_DEFAULT_MAX_NB_QUEUE_PAIRS 64
> >
> > #define RTE_CRYPTODEV_PMD_NAME_ARG ("name")
> > #define RTE_CRYPTODEV_PMD_MAX_NB_QP_ARG
> ("max_nb_queue_pairs")
>
> Crypto device has devargs "max_nb_queue_pairs" which can be used to change
> queue pairs limit at init time.
> Then no need to increase the default value?
>
> > --
> > 2.25.1
prev parent reply other threads:[~2023-01-10 7:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 7:30 Anoob Joseph
2023-01-04 10:58 ` Zhang, Fan
2023-01-10 6:41 ` Ruifeng Wang
2023-01-10 7:07 ` Anoob Joseph [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4672E4F96687052BF74BE030DFFF9@PH0PR18MB4672.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=Ruifeng.Wang@arm.com \
--cc=asekhar@marvell.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=kai.ji@intel.com \
--cc=matan@nvidia.com \
--cc=nd@arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).