patches for DPDK stable branches
 help / color / mirror / Atom feed

From: Anoob Joseph <anoobj@marvell.com>
To: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Cc: Akhil Goyal <gakhil@marvell.com>,
	"roy.fan.zhang@intel.com" <roy.fan.zhang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] [PATCH] test/crypto: fix warnings for optimization=1 build
Date: Mon, 13 Jun 2022 05:02:34 +0000	[thread overview]
Message-ID: <PH0PR18MB4672E6D4F51196F7A129B389DFAB9@PH0PR18MB4672.namprd18.prod.outlook.com> (raw)
In-Reply-To: <872fbb13ed0df67f7dedbf3db340464bb7391af1.1654898453.git.rahul.lakkireddy@chelsio.com>

Hi Rahul,

Please see inline.

Thanks,
Anoob

> -----Original Message-----
> From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> Sent: Saturday, June 11, 2022 3:40 AM
> To: dev@dpdk.org
> Cc: Akhil Goyal <gakhil@marvell.com>; roy.fan.zhang@intel.com;
> stable@dpdk.org
> Subject: [EXT] [PATCH] test/crypto: fix warnings for optimization=1 build
> 
> External Email
> 
> ----------------------------------------------------------------------
> Skip IPSec ESN and antireplay cases, if there are no packets. Fixes following
> warning when using optimization=1 build flag with GCC 11.
> 
> ../app/test/test_cryptodev.c: In function ‘test_ipsec_pkt_replay’:
> ../app/test/test_cryptodev.c:10074:15: warning: ‘td_outb’ may be used
> uninitialized [-Wmaybe-uninitialized]
>          ret = test_ipsec_proto_process(td_outb, td_inb, nb_pkts, true,
> 
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                                         &flags);
>                                         ~~~~~~~
> ../app/test/test_cryptodev.c:9150:1: note: by argument 1 of type ‘const
> struct ipsec_test_data[]’ to ‘test_ipsec_proto_process’ declared here
> test_ipsec_proto_process(const struct ipsec_test_data td[],
> ^~~~~~~~~~~~~~~~~~~~~~~~
> ../app/test/test_cryptodev.c:10056:32: note: ‘td_outb’ declared here
>          struct ipsec_test_data td_outb[IPSEC_TEST_PACKETS_MAX];
>                                 ^~~~~~~
> 
> Fixes: d02c6bfcb99a ("test/crypto: add ESN and antireplay cases")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> ---
>  app/test/test_cryptodev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> 524019ce0e..47ce3d8420 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -10058,6 +10058,9 @@ test_ipsec_pkt_replay(const void *test_data,
> const uint64_t esn[],
>  	struct ipsec_test_flags flags;
>  	uint32_t i = 0, ret = 0;
> 
> +	if (nb_pkts == 0)
> +		return TEST_SKIPPED;
> +

[Anoob] nb_pkts == 0 would indicate a badly written test case. Might be better to return TEST_FAILED in that case.
 
>  	memset(&flags, 0, sizeof(flags));
>  	flags.antireplay = true;
> 
> --
> 2.27.0

next prev parent reply	other threads:[~2022-06-13  5:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 22:09 Rahul Lakkireddy
2022-06-13  5:02 ` Anoob Joseph [this message]
2022-06-13  9:52 ` [PATCH v2] " Rahul Lakkireddy
2022-06-13  9:54   ` [EXT] " Anoob Joseph
2022-06-15 15:08   ` Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB4672E6D4F51196F7A129B389DFAB9@PH0PR18MB4672.namprd18.prod.outlook.com \
    --to=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).