From: Anoob Joseph <anoobj@marvell.com>
To: Akhil Goyal <gakhil@marvell.com>,
Declan Doherty <declan.doherty@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Ciara Power <ciara.power@intel.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Archana Muniganti <marchana@marvell.com>,
Tejasree Kondoj <ktejasree@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Gagandeep Singh <g.singh@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4 1/5] test/crypto: add lookaside IPsec tests
Date: Thu, 23 Sep 2021 04:48:09 +0000 [thread overview]
Message-ID: <PH0PR18MB4672F3F9E887EDE085B6A1A5DFA39@PH0PR18MB4672.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB44848AAD545B160DA2FD7074D8A19@CO6PR18MB4484.namprd18.prod.outlook.com>
Hi Akhil,
Thanks for the review. Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, September 21, 2021 9:38 PM
> To: Anoob Joseph <anoobj@marvell.com>; Declan Doherty
> <declan.doherty@intel.com>; Fan Zhang <roy.fan.zhang@intel.com>;
> Konstantin Ananyev <konstantin.ananyev@intel.com>; Ciara Power
> <ciara.power@intel.com>
> Cc: Anoob Joseph <anoobj@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Archana Muniganti <marchana@marvell.com>;
> Tejasree Kondoj <ktejasree@marvell.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Radu Nicolau <radu.nicolau@intel.com>;
> Gagandeep Singh <g.singh@nxp.com>; dev@dpdk.org
> Subject: RE: [PATCH v4 1/5] test/crypto: add lookaside IPsec tests
>
> Hi Anoob,
> Few minor comments, Please see inline.
> Apart from that,
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> >
> Update title as
> Test/crypto: add lookaside IPsec cases.
[Anoob] Will update so in v5
>
> > +static int
> > +security_proto_supported(enum rte_security_session_action_type
> action,
> > + enum rte_security_session_protocol proto);
> > +
> > +static int
> > +dev_configure_and_start(uint64_t ff_disable);
> > +
>
> Do we really need to forward declare?
[Anoob] I've kept 'ipsec_proto_testsuite_setup' close to other rte_security test suite setups. The function, dev_configure_and_start() is defined later but I need to use it to enable SECURITY before doing capability check. Only other option is to move around code.
>
> > static struct rte_mbuf *
> > setup_test_string(struct rte_mempool *mpool,
> > const char *string, size_t len, uint8_t blocksize) @@ -753,6
> > +763,43 @@ crypto_gen_testsuite_setup(void)
> >
> > #ifdef RTE_LIB_SECURITY
> > static int
> > +ipsec_proto_testsuite_setup(void)
> > +{
> > + struct crypto_testsuite_params *ts_params = &testsuite_params;
> > + struct crypto_unittest_params *ut_params = &unittest_params;
> > + struct rte_cryptodev_info dev_info;
> > + int ret = 0;
> > +
> > + rte_cryptodev_info_get(ts_params->valid_devs[0], &dev_info);
> > +
> > + if (!(dev_info.feature_flags & RTE_CRYPTODEV_FF_SECURITY)) {
> > + RTE_LOG(INFO, USER1, "Feature flag requirements for IPsec
> > Proto "
> > + "testsuite not met\n");
> > + return TEST_SKIPPED;
> > + }
> > +
> > + /* Reconfigure to enable security */
>
> Update comment like
> /*Reconfigure to enable security and disable crypto */ BTW, shouldn't this be
> dev_configure_and_start(0) Why is sym and asym disabled here?
[Anoob] Will update the comments in v5. Sym & asym are not required for security tests. But then, I can keep ff_disable as 0. It won't affect anything.
>
> > +
> dev_configure_and_start(RTE_CRYPTODEV_FF_SYMMETRIC_CRYPT
> O
> > |
> > +
> RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO);
>
> Return value not taken care here.
[Anoob] Will fix in v5.
>
>
> > +
> > + /* Set action type */
> > + ut_params->type =
> > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL;
> > +
> > + if (security_proto_supported(
> > +
> > RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL,
> > + RTE_SECURITY_PROTOCOL_IPSEC) < 0) {
> > + RTE_LOG(INFO, USER1, "Capability requirements for IPsec
> > Proto "
> > + "test not met\n");
> > + ret = TEST_SKIPPED;
> > + }
> > +
> > + /* Stop the device */
> > + rte_cryptodev_stop(ts_params->valid_devs[0]);
>
> Add a comment that the device will be started again in ut_setup_security()
[Anoob] Will update so in v5.
>
> > +
> > + ret = test_ipsec_post_process(ut_params->ibuf, &td[i],
> > + res_d_tmp, silent);
> > + if (ret != TEST_SUCCESS)
> > + goto crypto_op_free;
> > +
> > + rte_crypto_op_free(ut_params->op);
> > + ut_params->op = NULL;
> > +
> > + rte_pktmbuf_free(ut_params->ibuf);
> > + ut_params->ibuf = NULL;
> > + }
> > +
> > +crypto_op_free:
> > + rte_crypto_op_free(ut_params->op);
> > + ut_params->op = NULL;
> > +
> > + rte_pktmbuf_free(ut_params->ibuf);
> > + ut_params->ibuf = NULL;
> > +
>
> Above four lines are getting executed again in the success cases.
[Anoob] rte_crypto_op_free() has a NULL check. So executing this for success cases is alright. I believe UT already does it this way for certain cases. If you check PDCP test cases, it has a free in the test case and there would be one free in ut_teardown() also.
next prev parent reply other threads:[~2021-09-23 4:48 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 10:43 [dpdk-dev] [PATCH 21.11 0/3] Add " Anoob Joseph
2021-07-29 10:43 ` [dpdk-dev] [PATCH 21.11 1/3] test/crypto: add " Anoob Joseph
2021-07-29 10:43 ` [dpdk-dev] [PATCH 21.11 2/3] test/crypto: add combined mode tests Anoob Joseph
2021-07-29 10:43 ` [dpdk-dev] [PATCH 21.11 3/3] test/crypto: add lookaside IPsec ICV corrupt test case Anoob Joseph
2021-08-11 9:45 ` [dpdk-dev] [PATCH v2 0/4] Add lookaside IPsec tests Anoob Joseph
2021-08-11 9:45 ` [dpdk-dev] [PATCH v2 1/4] test/crypto: add " Anoob Joseph
2021-08-11 9:45 ` [dpdk-dev] [PATCH v2 2/4] test/crypto: add combined mode tests Anoob Joseph
2021-08-11 9:45 ` [dpdk-dev] [PATCH v2 3/4] test/crypto: add lookaside IPsec ICV corrupt test case Anoob Joseph
2021-08-11 9:45 ` [dpdk-dev] [PATCH v2 4/4] test/crypto: add IV gen tests Anoob Joseph
2021-09-03 4:46 ` [dpdk-dev] [PATCH v3 0/5] Add lookaside IPsec tests Anoob Joseph
2021-09-03 4:46 ` [dpdk-dev] [PATCH v3 1/5] test/crypto: add " Anoob Joseph
2021-09-03 9:38 ` Power, Ciara
2021-09-03 9:46 ` Anoob Joseph
2021-09-03 4:46 ` [dpdk-dev] [PATCH v3 2/5] test/crypto: add combined mode tests Anoob Joseph
2021-09-03 9:42 ` Power, Ciara
2021-09-03 10:04 ` Anoob Joseph
2021-09-03 15:04 ` Power, Ciara
2021-09-03 16:14 ` Anoob Joseph
2021-09-03 4:46 ` [dpdk-dev] [PATCH v3 3/5] test/crypto: add lookaside IPsec ICV corrupt test case Anoob Joseph
2021-09-03 4:46 ` [dpdk-dev] [PATCH v3 4/5] test/crypto: add IV gen tests Anoob Joseph
2021-09-03 4:46 ` [dpdk-dev] [PATCH v3 5/5] test/crypto: add UDP encapsulation test cases Anoob Joseph
2021-09-17 13:15 ` [dpdk-dev] [PATCH v4 0/5] Add lookaside IPsec tests Anoob Joseph
2021-09-17 13:15 ` [dpdk-dev] [PATCH v4 1/5] test/crypto: add " Anoob Joseph
2021-09-21 16:08 ` Akhil Goyal
2021-09-23 4:48 ` Anoob Joseph [this message]
2021-09-23 10:39 ` Power, Ciara
2021-09-23 11:08 ` Anoob Joseph
2021-09-23 11:26 ` Power, Ciara
2021-09-23 11:30 ` Anoob Joseph
2021-09-24 8:42 ` Hemant Agrawal
2021-09-17 13:15 ` [dpdk-dev] [PATCH v4 2/5] test/crypto: add combined mode tests Anoob Joseph
2021-09-21 16:22 ` Akhil Goyal
2021-09-24 7:23 ` Hemant Agrawal
2021-09-24 8:12 ` [dpdk-dev] [EXT] " Anoob Joseph
2021-09-17 13:15 ` [dpdk-dev] [PATCH v4 3/5] test/crypto: add lookaside IPsec ICV corrupt test case Anoob Joseph
2021-09-21 16:25 ` Akhil Goyal
2021-09-24 8:43 ` Hemant Agrawal
2021-09-17 13:15 ` [dpdk-dev] [PATCH v4 4/5] test/crypto: add IV gen tests Anoob Joseph
2021-09-21 16:31 ` Akhil Goyal
2021-09-17 13:15 ` [dpdk-dev] [PATCH v4 5/5] test/crypto: add UDP encapsulation test cases Anoob Joseph
2021-09-21 16:35 ` Akhil Goyal
2021-09-23 13:34 ` [dpdk-dev] [PATCH v4 0/5] Add lookaside IPsec tests Power, Ciara
2021-09-25 15:35 ` [dpdk-dev] [PATCH v5 " Anoob Joseph
2021-09-25 15:35 ` [dpdk-dev] [PATCH v5 1/5] test/crypto: add lookaside IPsec cases Anoob Joseph
2021-09-25 15:35 ` [dpdk-dev] [PATCH v5 2/5] test/crypto: add combined mode " Anoob Joseph
2021-09-25 15:35 ` [dpdk-dev] [PATCH v5 3/5] test/crypto: add lookaside IPsec ICV corrupt test case Anoob Joseph
2021-09-25 15:35 ` [dpdk-dev] [PATCH v5 4/5] test/crypto: add IV gen cases for IPsec Anoob Joseph
2021-09-25 15:35 ` [dpdk-dev] [PATCH v5 5/5] test/crypto: add UDP encapsulated IPsec test cases Anoob Joseph
2021-09-28 7:49 ` [dpdk-dev] [PATCH v5 0/5] Add lookaside IPsec tests Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB4672F3F9E887EDE085B6A1A5DFA39@PH0PR18MB4672.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=ciara.power@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=g.singh@nxp.com \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=konstantin.ananyev@intel.com \
--cc=ktejasree@marvell.com \
--cc=marchana@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).