DPDK patches and discussions
 help / color / mirror / Atom feed
From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: fengchengwen <fengchengwen@huawei.com>,
	Kevin Laatz <kevin.laatz@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"mb@smartsharesystems.com" <mb@smartsharesystems.com>,
	"conor.walsh@intel.com" <conor.walsh@intel.com>,
	Vamsi Krishna Attunuru <vattunuru@marvell.com>,
	"g.singh@nxp.com" <g.singh@nxp.com>,
	"sachin.saxena@oss.nxp.com" <sachin.saxena@oss.nxp.com>,
	"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
	"cheng1.jiang@intel.com" <cheng1.jiang@intel.com>,
	Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>
Subject: RE: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer
Date: Mon, 9 Oct 2023 12:01:17 +0000	[thread overview]
Message-ID: <PH0PR18MB516766AC0C4D22491A0C674FC8CEA@PH0PR18MB5167.namprd18.prod.outlook.com> (raw)
In-Reply-To: <45664b7f-4f85-8c5b-6e24-b4d0d1fcc2a7@huawei.com>

Hi Chengwen,

Ack, I will make the changes in next version of the patch.

Thanks,
Amit Shukla

> -----Original Message-----
> From: fengchengwen <fengchengwen@huawei.com>
> Sent: Monday, October 9, 2023 2:29 PM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>; Kevin Laatz
> <kevin.laatz@intel.com>; Bruce Richardson <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> mb@smartsharesystems.com; conor.walsh@intel.com; Vamsi Krishna
> Attunuru <vattunuru@marvell.com>; g.singh@nxp.com;
> sachin.saxena@oss.nxp.com; hemant.agrawal@nxp.com;
> cheng1.jiang@intel.com; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; Anoob Joseph <anoobj@marvell.com>
> Subject: Re: [EXT] Re: [PATCH v3 1/2] dmadev: offload to free source buffer
> 
> Hi Amit,
> 
>   Rethink again, I suggest use auto-free to denote this feature.
> 
> So we could re-define as:
>   RTE_DMA_CAPA_M2D_AUTO_FREE
>   RTE_DMA_OP_FLAG_AUTO_FREE
> 
> struct rte_dma_auto_free_param {
>       union {
>           struct {
>               struct rte_mempool *pool;
>           } m2d;
>       };
>       uint64_t reserved[2]; /**< Reserved for future fields. */ }; };
> note: because one vchan only support one DMA direction, so we could use
> union.
> 
> struct rte_dma_vchan_conf {
> 	enum rte_dma_direction direction;
> 	struct rte_dma_port_param src_port;
> 	struct rte_dma_port_param dst_port;
> 	struct rte_dma_auto_free_param auto_free; };
> 
> 
> As for later extension, if support other type auto-free, so could:
> 1. add one capa: RTE_DMA_CAPA_XXX_AUTO_FREE 2. modify
> rte_dma_auto_free_param:
>    struct rte_dma_auto_free_param {
>       union {
>           struct {
>               struct rte_mempool *pool;
>           } m2d;
>           struct {
>               // params;
>           } xxx;
>       };
>       uint64_t reserved[2]; /**< Reserved for future fields. */ };
>     };
> 
> 
> Thanks.
> 

<snip>

  reply	other threads:[~2023-10-09 12:01 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-07  8:10 [PATCH v1 0/2] offload support to free dma " Amit Prakash Shukla
2023-09-07  8:10 ` [PATCH v1 1/2] dmadev: offload to free " Amit Prakash Shukla
2023-09-07  9:00   ` Amit Prakash Shukla
2023-09-18 11:12   ` Anoob Joseph
2023-09-07  8:10 ` [PATCH v1 2/2] test/dma: add source buffer offload free test Amit Prakash Shukla
2023-09-19 11:48   ` Anoob Joseph
2023-09-26  8:11     ` Amit Prakash Shukla
2023-09-26 12:17 ` [PATCH v2 0/2] offload support to free dma source buffer Amit Prakash Shukla
2023-09-26 12:17   ` [PATCH v2 1/2] dmadev: offload to free " Amit Prakash Shukla
2023-09-26 12:17   ` [PATCH v2 2/2] test/dma: add source buffer offload free test Amit Prakash Shukla
2023-09-28 11:50   ` [PATCH v3 0/2] offload support to free dma source buffer Amit Prakash Shukla
2023-09-28 11:50     ` [PATCH v3 1/2] dmadev: offload to free " Amit Prakash Shukla
2023-10-07  9:00       ` fengchengwen
2023-10-09  7:00         ` [EXT] " Amit Prakash Shukla
2023-10-09  8:59           ` fengchengwen
2023-10-09 12:01             ` Amit Prakash Shukla [this message]
2023-09-28 11:50     ` [PATCH v3 2/2] test/dma: add source buffer offload free test Amit Prakash Shukla
2023-09-28 12:08       ` Anoob Joseph
2023-10-07  9:32       ` fengchengwen
2023-10-09  7:07         ` [EXT] " Amit Prakash Shukla
2023-09-28 11:59     ` [PATCH v3 0/2] offload support to free dma source buffer Anoob Joseph
2023-10-05  7:21       ` Amit Prakash Shukla
2023-10-09 12:02     ` [PATCH v4 0/2] offload support to auto free dma buffer Amit Prakash Shukla
2023-10-09 12:02       ` [PATCH v4 1/2] dmadev: offload to auto free DMA buffer Amit Prakash Shukla
2023-10-10  1:40         ` fengchengwen
2023-10-16 11:28           ` [EXT] " Amit Prakash Shukla
2023-10-09 12:02       ` [PATCH v4 2/2] test/dma: auto free offload test to " Amit Prakash Shukla
2023-10-17  8:47       ` [PATCH v4 0/2] offload support to auto free dma buffer Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB516766AC0C4D22491A0C674FC8CEA@PH0PR18MB5167.namprd18.prod.outlook.com \
    --to=amitprakashs@marvell.com \
    --cc=anoobj@marvell.com \
    --cc=bruce.richardson@intel.com \
    --cc=cheng1.jiang@intel.com \
    --cc=conor.walsh@intel.com \
    --cc=dev@dpdk.org \
    --cc=fengchengwen@huawei.com \
    --cc=g.singh@nxp.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=kevin.laatz@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=ndabilpuram@marvell.com \
    --cc=sachin.saxena@oss.nxp.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).