From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH v4 3/3] l3fwd-graph: changes to configure pcap capture
Date: Fri, 3 Feb 2023 08:16:33 +0000 [thread overview]
Message-ID: <PH0PR18MB5167BD77044E85114F3C7761C8D79@PH0PR18MB5167.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1NaGAH1+06Cg2Ak=74oRfpkFa7YWceh5z952MFVE0FFLQ@mail.gmail.com>
Thanks Jerin for the feedback. I will make the changes in next version of the patch.
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Tuesday, January 31, 2023 1:45 PM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Kiran Kumar
> Kokkilagadda <kirankumark@marvell.com>; Nithin Kumar Dabilpuram
> <ndabilpuram@marvell.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH v4 3/3] l3fwd-graph: changes to configure pcap
> capture
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, Jan 24, 2023 at 4:53 PM Amit Prakash Shukla
> <amitprakashs@marvell.com> wrote:
> >
> > Added support to configure pcap capture.
> >
> > Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
>
>
> Change the subject as examples/l3fwd-graph:
>
> > ---
> > v2:
> > - Fixed code style issue
> > - Fixed CI compilation issue on github-robot
> >
> > v3:
> > - Code review suggestion from Stephen
> > - Fixed potential memory leak
> >
> > v4:
> > - Code review suggestion from Jerin
> >
> > doc/guides/sample_app_ug/l3_forward_graph.rst | 23 +++++++
> > examples/l3fwd-graph/main.c | 62 ++++++++++++++++++-
> > 2 files changed, 83 insertions(+), 2 deletions(-)
> >
> > diff --git a/doc/guides/sample_app_ug/l3_forward_graph.rst
> > b/doc/guides/sample_app_ug/l3_forward_graph.rst
> > index 0a3e0d44ec..3043dba8e2 100644
> > --- a/doc/guides/sample_app_ug/l3_forward_graph.rst
> > +++ b/doc/guides/sample_app_ug/l3_forward_graph.rst
> > @@ -51,6 +51,9 @@ The application has a number of command line options
> similar to l3fwd::
> > [--max-pkt-len PKTLEN]
> > [--no-numa]
> > [--per-port-pool]
> > + [--pcap-enable]
> > + [--pcap-num-cap]
> > + [--pcap-file-name]
> >
> > Where,
> >
> > @@ -69,6 +72,12 @@ Where,
> >
> > * ``--per-port-pool:`` Optional, set to use independent buffer pools per
> port. Without this option, single buffer pool is used for all ports.
> >
> > +* ``--pcap-enable:`` Optional, Enables packet capture in pcap format on
> each node with mbuf and node metadata.
> > +
> > +* ``--pcap-num-cap:`` Optional, Number of packets to be captured per
> core.
> > +
> > +* ``--pcap-file-name:`` Optional, Pcap filename to capture packets in.
> > +
> > For example, consider a dual processor socket platform with 8
> > physical cores, where cores 0-7 and 16-23 appear on socket 0, while cores
> 8-15 and 24-31 appear on socket 1.
> >
> > @@ -99,6 +108,20 @@ In this command:
> > | | | | |
> >
> > +----------+-----------+-----------+----------------------------------
> > ---+
> >
> > +To enable pcap trace on each graph, use following command:
> > +
> > +.. code-block:: console
> > +
> > + ./<build_dir>/examples/dpdk-l3fwd-graph -l 1,2 -n 4 -- -p 0x3 --
> config="(0,0,1),(1,0,2)" --pcap-enable --pcap-num-cap=<number of packets>
> --pcap-file-name "</filepath/filename>"
>
> </filepath/filename> can be changes as "/path/to/file"
next prev parent reply other threads:[~2023-02-03 8:16 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 12:02 [RFC PATCH] graph: add support for pcap trace for graph Amit Prakash Shukla
2022-12-23 16:47 ` Stephen Hemminger
2023-01-06 10:40 ` [EXT] " Amit Prakash Shukla
2023-01-06 16:41 ` Stephen Hemminger
2023-01-06 18:56 ` Stephen Hemminger
2023-01-10 11:26 ` Amit Prakash Shukla
2023-01-10 11:58 ` [PATCH v1 1/3] pcapng: comment option support for epb Amit Prakash Shukla
2023-01-10 11:58 ` [PATCH v1 2/3] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-01-10 11:58 ` [PATCH v1 3/3] l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-01-10 17:05 ` [PATCH v1 1/3] pcapng: comment option support for epb Stephen Hemminger
2023-01-11 8:53 ` [PATCH v2 " Amit Prakash Shukla
2023-01-11 8:53 ` [PATCH v2 2/3] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-01-11 16:07 ` Stephen Hemminger
2023-01-12 9:57 ` [EXT] " Amit Prakash Shukla
2023-01-12 16:30 ` Stephen Hemminger
2023-01-19 14:37 ` Amit Prakash Shukla
2023-01-19 16:48 ` Stephen Hemminger
2023-01-11 8:53 ` [PATCH v2 3/3] l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-01-12 10:01 ` [PATCH v3 1/3] pcapng: comment option support for epb Amit Prakash Shukla
2023-01-12 10:01 ` [PATCH v3 2/3] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-01-12 12:18 ` Jerin Jacob
2023-01-19 14:21 ` [EXT] " Amit Prakash Shukla
2023-01-12 10:01 ` [PATCH v3 3/3] l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-01-24 11:21 ` [PATCH v4 1/3] pcapng: comment option support for epb Amit Prakash Shukla
2023-01-24 11:21 ` [PATCH v4 2/3] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-01-31 8:06 ` Jerin Jacob
2023-02-03 8:15 ` [EXT] " Amit Prakash Shukla
2023-01-24 11:21 ` [PATCH v4 3/3] l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-01-31 8:14 ` Jerin Jacob
2023-02-03 8:16 ` Amit Prakash Shukla [this message]
2023-02-03 8:19 ` [PATCH v5 1/3] pcapng: comment option support for epb Amit Prakash Shukla
2023-02-03 8:19 ` [PATCH v5 2/3] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-02-09 9:12 ` David Marchand
2023-02-09 9:29 ` [EXT] " Amit Prakash Shukla
2023-02-03 8:19 ` [PATCH v5 3/3] examples/l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-02-09 9:13 ` [PATCH v5 1/3] pcapng: comment option support for epb David Marchand
2023-02-09 16:48 ` Stephen Hemminger
2023-02-09 9:56 ` [PATCH v6 1/4] " Amit Prakash Shukla
2023-02-09 9:56 ` [PATCH v6 2/4] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-02-09 9:56 ` [PATCH v6 3/4] examples/l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-02-09 9:56 ` [PATCH v6 4/4] test/graph: initialize graph param variable Amit Prakash Shukla
2023-02-09 10:03 ` [PATCH v6 1/4] pcapng: comment option support for epb Amit Prakash Shukla
2023-02-09 10:24 ` [PATCH v7 1/3] " Amit Prakash Shukla
2023-02-09 10:24 ` [PATCH v7 2/3] graph: pcap capture for graph nodes Amit Prakash Shukla
2023-02-09 10:24 ` [PATCH v7 3/3] examples/l3fwd-graph: changes to configure pcap capture Amit Prakash Shukla
2023-02-09 17:28 ` Jerin Jacob
2023-02-10 12:18 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB5167BD77044E85114F3C7761C8D79@PH0PR18MB5167.namprd18.prod.outlook.com \
--to=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).