From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <roy.fan.zhang@intel.com>, Ray Kinsella <mdr@ashroe.eu>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: RE: [PATCH] cryptodev: add trace points
Date: Tue, 27 Sep 2022 13:48:45 +0000 [thread overview]
Message-ID: <PH0PR18MB5167C63628606447A5DD0DE9C8559@PH0PR18MB5167.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CO6PR18MB4484B3806F0114487D462D36D8559@CO6PR18MB4484.namprd18.prod.outlook.com>
Hi Akhil,
Thanks for your feedback. I will do the suggested changes in next version of the patch.
> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Tuesday, September 27, 2022 1:37 PM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>; Fan Zhang
> <roy.fan.zhang@intel.com>; Ray Kinsella <mdr@ashroe.eu>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Amit
> Prakash Shukla <amitprakashs@marvell.com>
> Subject: RE: [PATCH] cryptodev: add trace points
>
> > diff --git a/lib/cryptodev/rte_cryptodev_trace.h
> > b/lib/cryptodev/rte_cryptodev_trace.h
> > index a3f6048e7d..84991c5b0a 100644
> > --- a/lib/cryptodev/rte_cryptodev_trace.h
> > +++ b/lib/cryptodev/rte_cryptodev_trace.h
> > @@ -18,6 +18,7 @@ extern "C" {
> > #include <rte_trace_point.h>
> >
> > #include "rte_cryptodev.h"
> > +#include "cryptodev_pmd.h"
>
> We cannot include library internal header into external header.
> We can either have a have a separate file for pmd specific APIs And hide it
> from user or do not allow tracing for pmd APIs.
>
>
> > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
> > index 5aee87c6f7..a788185229 100644
> > --- a/lib/cryptodev/version.map
> > +++ b/lib/cryptodev/version.map
> > @@ -109,6 +109,63 @@ EXPERIMENTAL {
> > #added in 22.07
> > rte_cryptodev_session_event_mdata_set;
> > rte_crypto_asym_ke_strings;
> > +
> > + #added in 22.11
>
>
> > + __rte_cryptodev_trace_pmd_allocate;
> > + __rte_cryptodev_trace_pmd_callback_process;
> > + __rte_cryptodev_trace_pmd_create;
> > + __rte_cryptodev_trace_pmd_create_dev_name;
> > + __rte_cryptodev_trace_pmd_destroy;
> > + __rte_cryptodev_trace_pmd_get_dev;
> > + __rte_cryptodev_trace_pmd_get_named_dev;
> > + __rte_cryptodev_trace_pmd_parse_input_args;
> > + __rte_cryptodev_trace_pmd_probing_finish;
> > + __rte_cryptodev_trace_pmd_release_device;
>
> These can only be internal or just remove these.
next prev parent reply other threads:[~2022-09-27 13:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 17:32 Amit Prakash Shukla
2022-09-27 8:06 ` Akhil Goyal
2022-09-27 13:48 ` Amit Prakash Shukla [this message]
2022-09-28 4:08 ` Jerin Jacob
2022-09-28 17:30 ` [EXT] " Amit Prakash Shukla
2022-09-29 12:35 ` [PATCH v2] " Amit Prakash Shukla
2022-09-30 7:34 ` Jerin Jacob
2022-09-30 18:22 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB5167C63628606447A5DD0DE9C8559@PH0PR18MB5167.namprd18.prod.outlook.com \
--to=amitprakashs@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=mdr@ashroe.eu \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).