From: Amit Prakash Shukla <amitprakashs@marvell.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
Chenbo Xia <chenbo.xia@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Ruifeng.Wang@arm.com" <Ruifeng.Wang@arm.com>
Subject: RE: [EXT] Re: [PATCH v2] vhost: compilation fix for GCC-12
Date: Fri, 2 Sep 2022 15:11:47 +0000 [thread overview]
Message-ID: <PH0PR18MB5167D3A9C006995E8CC11483C87A9@PH0PR18MB5167.namprd18.prod.outlook.com> (raw)
In-Reply-To: <YxH9Yak2gtg2VVuL@debian.me>
Thanks for the feedback.
> -----Original Message-----
> From: Bagas Sanjaya <bagasdotme@gmail.com>
> Sent: Friday, September 2, 2022 6:26 PM
> To: Amit Prakash Shukla <amitprakashs@marvell.com>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; Chenbo Xia
> <chenbo.xia@intel.com>; dev@dpdk.org; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; stable@dpdk.org; Ruifeng.Wang@arm.com
> Subject: [EXT] Re: [PATCH v2] vhost: compilation fix for GCC-12
>
> External Email
>
> ----------------------------------------------------------------------
> On Fri, Sep 02, 2022 at 06:11:52PM +0530, Amit Prakash Shukla wrote:
> > ../lib/vhost/virtio_net.c:941:35: error:
> > 'buf_vec[0].buf_len' may be used uninitialized
> > [-Werror=maybe-uninitialized]
> > 941 | buf_len = buf_vec[vec_idx].buf_len;
> > | ~~~~~~~~~~~~~~~~^~~~~~~~
> > ../lib/vhost/virtio_net.c: In function 'virtio_dev_rx_packed':
> > ../lib/vhost/virtio_net.c:1285:27: note: 'buf_vec' declared here
> > 1285 | struct buf_vector buf_vec[BUF_VECTOR_MAX];
> > | ^~~~~~~
> > cc1: all warnings being treated as errors
> >
> > Fixes: 93520085efda ("vhost: add packed ring single enqueue")
> > Cc: stable@dpdk.org
>
> Please describe what this patch is doing (the current state of code, why it
> errored, and how it is fixing the error). Write the description in imperative
> mood. I don't see the description other than error message above.
I have pushed v3 incorporating your suggestion regarding description.
>
> Also, for stable patches submission, Cc stable@vger.kernel.org.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-09-02 15:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 8:49 [PATCH] " Amit Prakash Shukla
2022-09-02 7:23 ` Ruifeng Wang
2022-09-02 11:57 ` Amit Prakash Shukla
2022-09-02 12:41 ` [PATCH v2] " Amit Prakash Shukla
2022-09-02 12:56 ` Bagas Sanjaya
2022-09-02 15:11 ` Amit Prakash Shukla [this message]
2022-09-02 15:06 ` [PATCH v3] " Amit Prakash Shukla
2022-10-06 7:22 ` Amit Prakash Shukla
2022-10-06 7:24 ` Maxime Coquelin
2022-10-06 8:05 ` [EXT] " Amit Prakash Shukla
2022-10-06 12:35 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB5167D3A9C006995E8CC11483C87A9@PH0PR18MB5167.namprd18.prod.outlook.com \
--to=amitprakashs@marvell.com \
--cc=Ruifeng.Wang@arm.com \
--cc=bagasdotme@gmail.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).