From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Daly, Jeff" <jeffd@silicom-usa.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Douthit <stephend@silicom-usa.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>
Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices
Date: Mon, 23 May 2022 23:22:06 +0000 [thread overview]
Message-ID: <PH7PR11MB5982615774F8EE32A26124E7D7D49@PH7PR11MB5982.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0402MB351779C43163437FC528FD17EAD49@VI1PR0402MB3517.eurprd04.prod.outlook.com>
> -----Original Message-----
> From: Jeff Daly <jeffd@silicom-usa.com>
> Sent: Monday, May 23, 2022 10:14 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; dev@dpdk.org
> Cc: Stephen Douthit <stephend@silicom-usa.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices
>
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, May 23, 2022 1:37 AM
> > To: Jeff Daly <jeffd@silicom-usa.com>; Thomas Monjalon
> > <thomas@monjalon.net>; dev@dpdk.org
> > Cc: Stephen Douthit <stephend@silicom-usa.com>; Yang, Qiming
> > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550
> > devices
> >
> > Caution: This is an external email. Please take care when clicking
> > links or opening attachments.
> >
> >
> > > -----Original Message-----
> > > From: Jeff Daly <jeffd@silicom-usa.com>
> > > Sent: Saturday, May 21, 2022 2:03 AM
> > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Thomas Monjalon
> > > <thomas@monjalon.net>; dev@dpdk.org
> > > Cc: Stephen Douthit <stephend@silicom-usa.com>; Yang, Qiming
> > > <qiming.yang@intel.com>; Wu, Wenjun1 <wenjun1.wu@intel.com>
> > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the
> > > X550 devices
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > > > Sent: Thursday, May 19, 2022 8:15 PM
> > > > To: Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org
> > > > Cc: Stephen Douthit <stephend@silicom-usa.com>; Jeff Daly
> > > > <jeffd@silicom- usa.com>; Yang, Qiming <qiming.yang@intel.com>;
> > > > Wu,
> > > > Wenjun1 <wenjun1.wu@intel.com>
> > > > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the
> > > > X550 devices
> > > >
> > > > Caution: This is an external email. Please take care when clicking
> > > > links or opening attachments.
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > > Sent: Wednesday, April 13, 2022 10:21 PM
> > > > > To: dev@dpdk.org
> > > > > Cc: Stephen Douthit <stephend@silicom-usa.com>; Jeff Daly
> > > > > <jeffd@silicom- usa.com>; Wang, Haiyue <haiyue.wang@intel.com>;
> > > > > Yang, Qiming <qiming.yang@intel.com>; Wu, Wenjun1
> > > > > <wenjun1.wu@intel.com>
> > > > > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the
> > > > > X550 devices
> > > > >
> > > > > Please, could we have a review of this patch?
> > > > > +Cc new ixgbe maintainers
> > > > >
> > > > >
> > > > > 07/03/2022 23:34, jeffd@silicom-usa.com:
> > > > > > From: Stephen Douthit <stephend@silicom-usa.com>
> > > > > >
> > > > > > 1G Cu SFPs are not officially supported on the X552/X553
> > > > > > family of devices but treat them as 1G SX modules since they usually
> work.
> > > > > > Print a warning though since support isn't validated, similar
> > > > > > to what already happens for other unofficially supported SFPs
> > > > > > enabled via the allow_unsupported_sfps parameter inherited
> > > > > > from the mainline
> > > > Linux driver.
> > > > > >
> > > > > > Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
> > > > > > Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
> > > >
> > > > I think we need a devargs for this feature with well documentation
> > > > So, it should not break existing behavior by default, but allow
> > > > people to take risk if they know what they are doing.
> > > >
> > >
> > > there was already a patch submitted to IWL mailing list for this
> > > feature in the base driver, which was rejected.
> > > https://patchwork.ozlabs.org/project/intel-wired-
> > > lan/patch/20220414201329.27714-1-jeffd@silicom-usa.com/
> >
> > OK, thanks for sharing this,
> >
> > But base on the concern of the previous comment
> >
> > " As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules
> > require the use of RX_ILOS and some Intel Ethernet products don't support
> that."
> >
> > We may have a risk to accept the code as default behavior
> >
> > But devargs is allowed in DPDK for device-specific features.
> >
>
> ok, I will submit a revised patch that uses a devargs (or whatever) switch to
> allow the behavior when selected explicitly.
>
> But, can we *please* STOP marking patches as superseded when a follow-up
> patch
> hasn't been submitted yet!? I've marked the patch as 'Changes Requested' for
> now.
Sure, I should follow, thanks to correct his, but a little bit surprise, why this looks like a big deal, it just a shortcut when I expected a new version will come then I skip one status change, I think mailing list already have everything about the patch status for you.
> When I submit a follow-up I will set this one to superseded
Actually you did NOT change the below patch to superseded after you send a new version (I did this) and you didn't reply my last question yet.
https://patchwork.dpdk.org/project/dpdk/list/?series=23046
>
> >
> > >
> > > > Thanks
> > > > Qi
> > > >
> > > >
> > > > > > ---
> > > > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++-
> > > > > > 1 file changed, 13 insertions(+), 1 deletion(-)
> > > > > >
> > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c
> > > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c
> > > > > > index 8810d1658e..8d1bc6c80d 100644
> > > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c
> > > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c
> > > > > > @@ -1538,9 +1538,21 @@ STATIC s32
> > > > > ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool
> > > > > *linear)
> > > > > > case ixgbe_sfp_type_1g_lha_core1:
> > > > > > *linear = false;
> > > > > > break;
> > > > > > - case ixgbe_sfp_type_unknown:
> > > > > > + /* Copper SFPs are not officially supported for x550em
> > > > > > + devices, but
> > > > can
> > > > > > + * often be made to work at fixed 1G speeds. Pretend
> > > > > > + they're
> > 1g_sx
> > > > > > + * modules here to allow g.Fast DSL SFPs to work.
> > > > > > + */
> > > > > > case ixgbe_sfp_type_1g_cu_core0:
> > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP
> > > > > > + is
> > > > > 1g_sx\n");
> > > > > > + *linear = false;
> > > > > > + hw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core0;
> > > > > > + break;
> > > > > > case ixgbe_sfp_type_1g_cu_core1:
> > > > > > + EWARN(hw, "Pretending that unsupported 1g_cu SFP
> > > > > > + is
> > > > > 1g_sx\n");
> > > > > > + *linear = false;
> > > > > > + hw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core1;
> > > > > > + break;
> > > > > > + case ixgbe_sfp_type_unknown:
> > > > > > default:
> > > > > > return IXGBE_ERR_SFP_NOT_SUPPORTED;
> > > > > > }
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
next prev parent reply other threads:[~2022-05-23 23:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 22:34 jeffd
2022-04-13 14:21 ` Thomas Monjalon
2022-05-20 0:14 ` Zhang, Qi Z
2022-05-20 18:02 ` Jeff Daly
2022-05-23 5:36 ` Zhang, Qi Z
2022-05-23 14:13 ` Jeff Daly
2022-05-23 23:22 ` Zhang, Qi Z [this message]
2022-05-25 15:23 ` Jeff Daly
2022-05-26 0:28 ` Zhang, Qi Z
2022-04-14 1:31 ` Wang, Haiyue
2022-04-14 9:42 ` Thomas Monjalon
2022-04-14 12:13 ` Wang, Haiyue
2022-04-14 12:18 ` Thomas Monjalon
2022-04-14 15:11 ` Jeff Daly
2022-04-14 15:43 ` Stephen Hemminger
2022-04-14 17:06 ` Thomas Monjalon
2022-04-19 9:11 ` Morten Brørup
2022-04-19 12:32 ` Wang, Haiyue
2022-04-15 1:10 ` Wang, Haiyue
2022-05-26 20:43 ` [PATCH v2] " Jeff Daly
2022-05-29 22:49 ` Zhang, Qi Z
2022-05-30 13:32 ` Jeff Daly
2022-05-30 13:50 ` Zhang, Qi Z
2022-05-31 12:30 ` Jeff Daly
2022-05-31 13:38 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR11MB5982615774F8EE32A26124E7D7D49@PH7PR11MB5982.namprd11.prod.outlook.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jeffd@silicom-usa.com \
--cc=qiming.yang@intel.com \
--cc=stephend@silicom-usa.com \
--cc=thomas@monjalon.net \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).