From: "Uttarwar, Sunil Prakashrao" <SunilPrakashrao.Uttarwar@amd.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "gakhil@marvell.com" <gakhil@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Somalapuram, Amaranath" <Amaranath.Somalapuram@amd.com>
Subject: RE: [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO
Date: Fri, 13 Jan 2023 12:00:06 +0000 [thread overview]
Message-ID: <PH7PR12MB66942F02386C2B102AD3AEA192C29@PH7PR12MB6694.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221004095132.198777-3-david.marchand@redhat.com>
[Public]
Acked-by: Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>
-----Original Message-----
From: David Marchand <david.marchand@redhat.com>
Sent: Tuesday, October 4, 2022 3:22 PM
To: dev@dpdk.org
Cc: gakhil@marvell.com; Uttarwar, Sunil Prakashrao <SunilPrakashrao.Uttarwar@amd.com>; stable@dpdk.org; Somalapuram, Amaranath <Amaranath.Somalapuram@amd.com>
Subject: [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
uio_fd is unused.
Fixes: 09a0fd736a08 ("crypto/ccp: enable IOMMU")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/crypto/ccp/ccp_dev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index 9c9cb81236..410e62121e 100644
--- a/drivers/crypto/ccp/ccp_dev.c
+++ b/drivers/crypto/ccp/ccp_dev.c
@@ -653,7 +653,6 @@ static int
ccp_probe_device(int ccp_type, struct rte_pci_device *pci_dev) {
struct ccp_device *ccp_dev = NULL;
- int uio_fd = -1;
ccp_dev = rte_zmalloc("ccp_device", sizeof(*ccp_dev),
RTE_CACHE_LINE_SIZE); @@ -671,8 +670,6 @@ ccp_probe_device(int ccp_type, struct rte_pci_device *pci_dev)
return 0;
fail:
CCP_LOG_ERR("CCP Device probe failed");
- if (uio_fd >= 0)
- close(uio_fd);
rte_free(ccp_dev);
return -1;
}
--
2.37.3
next prev parent reply other threads:[~2023-01-13 12:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220909150411.3702860-1-david.marchand@redhat.com>
2022-09-09 15:04 ` [PATCH 1/4] crypto/ccp: remove some printf David Marchand
2022-09-09 15:04 ` [PATCH 2/4] crypto/ccp: remove some dead code for UIO David Marchand
2022-09-09 15:04 ` [PATCH 3/4] crypto/ccp: fix IOVA handling David Marchand
2022-09-09 15:04 ` [PATCH 4/4] crypto/ccp: fix PCI probing David Marchand
[not found] ` <20221004095132.198777-1-david.marchand@redhat.com>
2022-10-04 9:51 ` [PATCH v2 1/4] crypto/ccp: remove some printf David Marchand
2023-01-13 11:58 ` Uttarwar, Sunil Prakashrao
2023-01-30 18:42 ` [EXT] " Akhil Goyal
2022-10-04 9:51 ` [PATCH v2 2/4] crypto/ccp: remove some dead code for UIO David Marchand
2023-01-13 12:00 ` Uttarwar, Sunil Prakashrao [this message]
2022-10-04 9:51 ` [PATCH v2 3/4] crypto/ccp: fix IOVA handling David Marchand
2023-01-13 12:00 ` Uttarwar, Sunil Prakashrao
2022-10-04 9:51 ` [PATCH v2 4/4] crypto/ccp: fix PCI probing David Marchand
2023-03-02 11:43 ` [PATCH v2] " David Marchand
2023-03-06 12:05 ` Uttarwar, Sunil Prakashrao
2023-03-11 18:49 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR12MB66942F02386C2B102AD3AEA192C29@PH7PR12MB6694.namprd12.prod.outlook.com \
--to=sunilprakashrao.uttarwar@amd.com \
--cc=Amaranath.Somalapuram@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).