From: Long Li <longli@microsoft.com>
To: fengchengwen <fengchengwen@huawei.com>,
Ferruh Yigit <ferruh.yigit@xilinx.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Ajay Sharma <sharmaajay@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: RE: [Patch v6 01/18] net/mana: add basic driver, build environment and doc
Date: Fri, 2 Sep 2022 19:45:42 +0000 [thread overview]
Message-ID: <PH7PR21MB3263FC13CD09BFD6DC13334CCE7A9@PH7PR21MB3263.namprd21.prod.outlook.com> (raw)
In-Reply-To: <452b1384-63ba-2eac-6458-152008b66c14@huawei.com>
> Subject: Re: [Patch v6 01/18] net/mana: add basic driver, build environment and
> doc
>
> On 2022/8/31 6:51, longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > MANA is a PCI device. It uses IB verbs to access hardware through the
> > kernel RDMA layer. This patch introduces build environment and basic
> > device probe functions.
> >
> > Signed-off-by: Long Li <longli@microsoft.com>
>
> ...
>
> > +static int mana_mp_primary_handle(const struct rte_mp_msg *mp_msg,
> > + const void *peer)
> > +{
> > + struct rte_eth_dev *dev;
> > + const struct mana_mp_param *param =
> > + (const struct mana_mp_param *)mp_msg->param;
> > + struct rte_mp_msg mp_res = { 0 };
> > + struct mana_mp_param *res = (struct mana_mp_param
> *)mp_res.param;
> > + int ret;
> > + struct mana_priv *priv;
> > +
> > + if (!rte_eth_dev_is_valid_port(param->port_id)) {
> > + DRV_LOG(ERR, "MP handle port ID %u invalid", param->port_id);
> > + return -ENODEV;
> > + }
> > +
> > + dev = &rte_eth_devices[param->port_id];
> > + priv = dev->data->dev_private;
> > +
> > + mp_init_msg(&mp_res, param->type, param->port_id);
> > +
> > + switch (param->type) {
> > + case MANA_MP_REQ_VERBS_CMD_FD:
> > + mp_res.num_fds = 1;
> > + mp_res.fds[0] = priv->ib_ctx->cmd_fd;
>
> The cmd_fd is system level handler?
>
> If it's process private handler, it should not used directly in another process.
According to rte_mp_xxx semantics, the file handle is duplicated to another process. It's not directly used. It's required for secondary process to map to the same doorbell pages.
>
> > + res->result = 0;
> > + ret = rte_mp_reply(&mp_res, peer);
> > + break;
> > +
> > + default:
> > + DRV_LOG(ERR, "Port %u unknown primary MP type %u",
> > + param->port_id, param->type);
> > + ret = -EINVAL;
> > + }
> > +
> > + return ret;
> > +}
> > +
next prev parent reply other threads:[~2022-09-02 19:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 22:51 [Patch v6 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD longli
2022-08-30 22:51 ` [Patch v6 01/18] net/mana: add basic driver, build environment and doc longli
2022-08-31 1:32 ` lihuisong (C)
2022-08-31 18:05 ` Long Li
2022-09-05 7:15 ` lihuisong (C)
2022-09-07 1:36 ` Long Li
2022-09-07 2:16 ` lihuisong (C)
2022-09-07 2:26 ` Long Li
2022-09-07 11:11 ` Ferruh Yigit
2022-09-07 18:12 ` Long Li
2022-09-02 12:09 ` fengchengwen
2022-09-02 19:45 ` Long Li [this message]
2022-09-03 1:44 ` fengchengwen
2022-08-30 22:51 ` [Patch v6 02/18] net/mana: add device configuration and stop longli
2022-08-30 22:51 ` [Patch v6 03/18] net/mana: add function to report support ptypes longli
2022-08-30 22:51 ` [Patch v6 04/18] net/mana: add link update longli
2022-08-30 22:51 ` [Patch v6 05/18] net/mana: add function for device removal interrupts longli
2022-08-30 22:51 ` [Patch v6 06/18] net/mana: add device info longli
2022-09-02 12:11 ` fengchengwen
2022-09-02 19:35 ` Long Li
2022-08-30 22:51 ` [Patch v6 07/18] net/mana: add function to configure RSS longli
2022-08-30 22:51 ` [Patch v6 08/18] net/mana: add function to configure RX queues longli
2022-08-30 22:51 ` [Patch v6 09/18] net/mana: add function to configure TX queues longli
2022-08-30 22:51 ` [Patch v6 10/18] net/mana: implement memory registration longli
2022-08-30 22:51 ` [Patch v6 11/18] net/mana: implement the hardware layer operations longli
2022-08-30 22:51 ` [Patch v6 12/18] net/mana: add function to start/stop TX queues longli
2022-08-30 22:51 ` [Patch v6 13/18] net/mana: add function to start/stop RX queues longli
2022-08-30 22:51 ` [Patch v6 14/18] net/mana: add function to receive packets longli
2022-08-30 22:51 ` [Patch v6 15/18] net/mana: add function to send packets longli
2022-09-02 12:18 ` fengchengwen
2022-09-02 19:40 ` Long Li
2022-08-30 22:51 ` [Patch v6 16/18] net/mana: add function to start/stop device longli
2022-08-30 22:51 ` [Patch v6 17/18] net/mana: add function to report queue stats longli
2022-08-30 22:51 ` [Patch v6 18/18] net/mana: add function to support RX interrupts longli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH7PR21MB3263FC13CD09BFD6DC13334CCE7A9@PH7PR21MB3263.namprd21.prod.outlook.com \
--to=longli@microsoft.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@xilinx.com \
--cc=sharmaajay@microsoft.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).