From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "20230629203720.682f90c3@hermes.local"
<20230629203720.682f90c3@hermes.local>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "hofors@lysator.liu.se" <hofors@lysator.liu.se>,
"dev@dpdk.org" <dev@dpdk.org>,
Suanming Mou <suanmingm@nvidia.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] service: avoid worker lcore exit deadlock
Date: Thu, 6 Jul 2023 11:33:25 +0000 [thread overview]
Message-ID: <PH8PR11MB680334AE568FC1700EAD4069D72CA@PH8PR11MB6803.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230704214339.244271-1-mattias.ronnblom@ericsson.com>
> -----Original Message-----
> From: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> Sent: Tuesday, July 4, 2023 10:44 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>; Stephen Hemminger
> <stephen@networkplumber.org>
> Cc: hofors@lysator.liu.se; dev@dpdk.org; Suanming Mou
> <suanmingm@nvidia.com>; thomas@monjalon.net;
> david.marchand@redhat.com; mattias.ronnblom
> <mattias.ronnblom@ericsson.com>; stable@dpdk.org
> Subject: [PATCH] service: avoid worker lcore exit deadlock
>
> Calling rte_exit() from a worker lcore thread causes a deadlock in
> rte_service_finalize().
>
> This patch makes rte_service_finalize() deadlock-free by avoiding the
> need to synchronize with service lcore threads, which in turn is
> achieved by moving service and per-lcore state from the heap to being
> statically allocated.
Elegant solution to avoiding the malloc/free in cleanup issue.
Thanks for investigating & implementing the solution!
> The BSS segment increases with ~156 kB (on x86_64 with default
> RTE_MAX_LCORE and RTE_SERVICE_NUM_MAX).
>
> According to the service perf autotest, this change also results in a
> slight reduction of service framework overhead.
>
> Fixes: 33666b448f15 ("service: fix crash on exit")
> Cc: harry.van.haaren@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
prev parent reply other threads:[~2023-07-06 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 21:43 Mattias Rönnblom
2023-07-06 11:33 ` Van Haaren, Harry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH8PR11MB680334AE568FC1700EAD4069D72CA@PH8PR11MB6803.namprd11.prod.outlook.com \
--to=harry.van.haaren@intel.com \
--cc=20230629203720.682f90c3@hermes.local \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).