From: "You, KaisenX" <kaisenx.you@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Matz, Olivier" <olivier.matz@6wind.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>,
"zhoumin@loongson.cn" <zhoumin@loongson.cn>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: RE: [PATCH v3] malloc: enhance NUMA affinity heuristic
Date: Tue, 31 Jan 2023 03:23:46 +0000 [thread overview]
Message-ID: <SJ0PR11MB67654299973DAF1207DB7FD6E1D09@SJ0PR11MB6765.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230103133216.961495-1-david.marchand@redhat.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: 2023年1月3日 21:32
> To: dev@dpdk.org
> Cc: Matz, Olivier <olivier.matz@6wind.com>; ferruh.yigit@amd.com; You,
> KaisenX <kaisenx.you@intel.com>; zhoumin@loongson.cn; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: [PATCH v3] malloc: enhance NUMA affinity heuristic
>
> Trying to allocate memory on the first detected numa node has less chance
> to find some memory actually available rather than on the main lcore numa
> node (especially when the DPDK application is started only on one numa
> node).
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v2:
> - add uncommitted local change and fix compilation,
>
> Changes since v1:
> - accomodate for configurations with main lcore running on multiples
> physical cores belonging to different numa,
>
> ---
> lib/eal/common/malloc_heap.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c
> index d7c410b786..3ee19aee15 100644
> --- a/lib/eal/common/malloc_heap.c
> +++ b/lib/eal/common/malloc_heap.c
> @@ -717,6 +717,10 @@ malloc_get_numa_socket(void)
> return socket_id;
> }
>
> + socket_id = rte_lcore_to_socket_id(rte_get_main_lcore());
> + if (socket_id != (unsigned int)SOCKET_ID_ANY)
> + return socket_id;
> +
> return rte_socket_id_by_idx(0);
> }
>
Because the initial "socket_id" of the interrupt thread is not necessarily
"SOCKET_ID_ANY"(-1), in malloc_get_numa_socket(void) function, It may
be returned before the content modified by this patch, resulting in the
subsequent search for memory being performed on the socket that initializes
the unallocated memory.
To avoid this, I will submit the V4 version to fix this problem.
> --
> 2.39.0
next prev parent reply other threads:[~2023-01-31 3:24 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 10:48 [PATCH] " David Marchand
2022-12-21 11:16 ` Bruce Richardson
2022-12-21 13:50 ` Ferruh Yigit
2022-12-21 14:57 ` David Marchand
2022-12-27 9:00 ` zhoumin
2023-01-03 10:56 ` David Marchand
2023-01-03 10:58 ` [PATCH v2] " David Marchand
2023-01-03 13:32 ` [PATCH v3] " David Marchand
2023-01-31 3:23 ` You, KaisenX [this message]
2023-01-31 15:05 ` [PATCH v4] net/iavf:enhance " Kaisen You
2023-01-31 16:05 ` Thomas Monjalon
2023-02-01 5:32 ` You, KaisenX
2023-02-01 12:20 ` [PATCH v5] enhance " Kaisen You
2023-02-01 10:52 ` Jiale, SongX
2023-02-15 14:22 ` Burakov, Anatoly
2023-02-15 14:47 ` Burakov, Anatoly
2023-02-16 2:50 ` You, KaisenX
2023-03-03 14:07 ` Thomas Monjalon
2023-03-09 1:58 ` You, KaisenX
2023-04-13 0:56 ` You, KaisenX
2023-04-19 12:16 ` Thomas Monjalon
2023-04-21 2:34 ` You, KaisenX
2023-04-21 8:12 ` Thomas Monjalon
2023-04-23 6:52 ` You, KaisenX
2023-04-23 8:57 ` You, KaisenX
2023-04-23 13:19 ` Thomas Monjalon
2023-04-25 5:16 ` [PATCH v6] " Kaisen You
2023-04-27 6:57 ` Thomas Monjalon
2023-05-16 5:19 ` You, KaisenX
2023-05-23 2:50 ` [PATCH v7] " Kaisen You
2023-05-23 10:44 ` Burakov, Anatoly
2023-05-26 6:44 ` You, KaisenX
2023-05-23 12:45 ` Burakov, Anatoly
2023-05-26 6:50 ` [PATCH v8] " Kaisen You
2023-05-26 8:45 ` Kaisen You
2023-05-26 14:44 ` Burakov, Anatoly
2023-05-26 17:50 ` Stephen Hemminger
2023-05-29 10:37 ` Burakov, Anatoly
2023-06-01 14:42 ` David Marchand
2023-06-06 14:04 ` Thomas Monjalon
2023-06-12 9:36 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR11MB67654299973DAF1207DB7FD6E1D09@SJ0PR11MB6765.namprd11.prod.outlook.com \
--to=kaisenx.you@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=olivier.matz@6wind.com \
--cc=zhoumin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).