From: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>
To: "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>,
Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: RE: [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API
Date: Wed, 1 Feb 2023 09:45:59 +0000 [thread overview]
Message-ID: <SJ0PR12MB5454952E7C19A9D0B506B793C6D19@SJ0PR12MB5454.namprd12.prod.outlook.com> (raw)
In-Reply-To: <7480062.EvYhyI6sBW@thomas>
> 30/01/2023 18:00, Jiawei Wang:
> > --- a/devtools/libabigail.abignore
> > +++ b/devtools/libabigail.abignore
> > @@ -20,6 +20,11 @@
> > [suppress_file]
> > soname_regexp = ^librte_.*mlx.*glue\.
> >
> > +; Ignore fields inserted in middle padding of rte_eth_txconf
> > +[suppress_type]
> > + name = rte_eth_txconf
> > + has_data_member_inserted_between =
> > +{offset_after(tx_deferred_start), offset_of(offloads)}
>
> You are adding the exception inside
> "Core suppression rules: DO NOT TOUCH".
>
> Please move it at the end in the section "Temporary exceptions till next major
> ABI version"
>
OK, will move.
> Also the rule does not work.
> It should be:
> has_data_member_inserted_between = {offset_of(tx_deferred_start),
> offset_of(offloads)}
>
Thanks, Will change it and send with new version.
>
next prev parent reply other threads:[~2023-02-01 9:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <http://patches.dpdk.org/project/dpdk/cover/20221221102934.13822-1-jiaweiw@nvidia.com/>
2023-01-30 17:00 ` [PATCH v2 0/2] add new PHY affinity in the flow item and " Jiawei Wang
2023-01-30 17:00 ` [PATCH v2 1/2] ethdev: add PHY affinity match item Jiawei Wang
2023-01-31 14:36 ` Ori Kam
2023-02-01 8:50 ` Andrew Rybchenko
2023-02-01 14:59 ` Jiawei(Jonny) Wang
2023-01-30 17:00 ` [PATCH v2 2/2] ethdev: introduce the PHY affinity field in Tx queue API Jiawei Wang
2023-01-31 17:26 ` Thomas Monjalon
2023-02-01 9:45 ` Jiawei(Jonny) Wang [this message]
2023-02-01 9:05 ` Andrew Rybchenko
2023-02-01 15:50 ` Jiawei(Jonny) Wang
2023-02-02 9:28 ` Andrew Rybchenko
2023-02-02 14:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR12MB5454952E7C19A9D0B506B793C6D19@SJ0PR12MB5454.namprd12.prod.outlook.com \
--to=jiaweiw@nvidia.com \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).