From: Chaoyong He <chaoyong.he@corigine.com>
To: Ferruh Yigit <ferruh.yigit@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
Niklas Soderlund <niklas.soderlund@corigine.com>
Subject: RE: [PATCH 2/3] doc: announce bonding data change
Date: Tue, 18 Jul 2023 01:13:35 +0000 [thread overview]
Message-ID: <SJ0PR13MB5545957CF55F5441A244FFA89E38A@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <6fe13e60-ea19-6acc-5f97-25135f899c02@amd.com>
> On 7/14/2023 9:15 AM, Chaoyong He wrote:
> > In order to support inclusive naming, the data structure of bonding
> > 8023 info need to be renamed. Do this through deprecation process now
> > for 23.07.
> >
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > ---
> > doc/guides/rel_notes/deprecation.rst | 3 +++
> > drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
> > drivers/net/bonding/rte_eth_bond_8023ad.h | 4 ++--
> > drivers/net/bonding/rte_eth_bond_pmd.c | 4 ++--
> > 4 files changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index c9477dd0da..5b16b66267 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -165,3 +165,6 @@ Deprecation Notices
> > * bonding: The macro ``RTE_ETH_DEV_BONDED_SLAVE`` will be deprecated
> in
> > DPDK 23.07, and removed in DPDK 23.11. The relevant code can be
> updated using
> > ``RTE_ETH_DEV_BONDING_MEMBER``.
> > + The data structure ``struct rte_eth_bond_8023ad_slave_info`` will
> > + be deprecated in DPDK 23.07, and removed in DPDK 23.11. The
> > + relevant code can be updated using ``struct
> rte_eth_bond_8023ad_member_info``.
>
> <...>
>
> > --- a/drivers/net/bonding/rte_eth_bond_8023ad.h
> > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
> > @@ -141,7 +141,7 @@ struct rte_eth_bond_8023ad_conf {
> > enum rte_bond_8023ad_agg_selection agg_selection; };
> >
> > -struct rte_eth_bond_8023ad_slave_info {
> > +struct rte_eth_bond_8023ad_member_info {
> > enum rte_bond_8023ad_selection selected;
> > uint8_t actor_state;
> > struct port_params actor;
>
> There is no good way to deprecate struct names.
>
> For macros it is possible to keep both old and new ones, old ones will give
> warning but still continue to work, so that is just a heads up for the user.
> But above is rename and will break the application, forcing user to update their
> code.
> And if we will force user to update their code, this should be done on ABI
> break release, v23.11.
>
> That is why I suggest just keep the deprecation notice update, saying that
> struct will be renamed in v23.11, without mentioning from deprecating struct
> in this release etc..
Got it. Thanks for point it out, I will revise in the v2 patch.
next prev parent reply other threads:[~2023-07-18 1:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-14 8:15 [PATCH 0/3] announce bonding macro and function change Chaoyong He
2023-07-14 8:15 ` [PATCH 1/3] doc: announce bonding macro change Chaoyong He
2023-07-17 15:13 ` Ferruh Yigit
2023-07-18 1:17 ` Chaoyong He
2023-07-14 8:15 ` [PATCH 2/3] doc: announce bonding data change Chaoyong He
2023-07-17 15:03 ` Ferruh Yigit
2023-07-18 1:13 ` Chaoyong He [this message]
2023-07-14 8:15 ` [PATCH 3/3] doc: announce bonding function change Chaoyong He
2023-07-17 15:13 ` Ferruh Yigit
2023-07-18 1:15 ` Chaoyong He
2023-07-17 15:14 ` [PATCH 0/3] announce bonding macro and " Ferruh Yigit
2023-07-18 1:48 ` [PATCH v2 " Chaoyong He
2023-07-18 1:48 ` [PATCH v2 1/3] doc: announce bonding macro change Chaoyong He
2023-07-18 8:09 ` Ferruh Yigit
2023-07-18 1:48 ` [PATCH v2 2/3] doc: announce bonding data change Chaoyong He
2023-07-18 8:05 ` Ferruh Yigit
2023-07-18 1:48 ` [PATCH v2 3/3] doc: announce bonding function change Chaoyong He
2023-07-18 8:05 ` Ferruh Yigit
2023-07-18 8:28 ` [PATCH v3 0/3] announce bonding macro and " Chaoyong He
2023-07-18 8:28 ` [PATCH v3 1/3] doc: announce bonding macro change Chaoyong He
2023-07-18 11:39 ` Ferruh Yigit
2023-07-18 15:53 ` Stephen Hemminger
2023-07-19 1:24 ` lihuisong (C)
2023-07-26 11:47 ` Morten Brørup
2023-07-18 8:28 ` [PATCH v3 2/3] doc: announce bonding data change Chaoyong He
2023-07-18 11:40 ` Ferruh Yigit
2023-07-18 15:53 ` Stephen Hemminger
2023-07-19 1:32 ` lihuisong (C)
2023-07-18 8:28 ` [PATCH v3 3/3] doc: announce bonding function change Chaoyong He
2023-07-18 11:40 ` Ferruh Yigit
2023-07-18 15:52 ` Stephen Hemminger
2023-07-19 1:31 ` lihuisong (C)
2023-07-19 1:37 ` Chaoyong He
2023-07-19 1:53 ` lihuisong (C)
2023-07-26 9:06 ` [PATCH v3 0/3] announce bonding macro and " Chaoyong He
2023-07-28 13:54 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB5545957CF55F5441A244FFA89E38A@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).