From: Chaoyong He <chaoyong.he@corigine.com>
To: Harman Kalra <hkalra@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@amd.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
Yuying Zhang <Yuying.Zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Subject: RE: [PATCH v4 1/1] ethdev: parsing multiple representor devargs string
Date: Mon, 22 Jan 2024 10:10:38 +0000 [thread overview]
Message-ID: <SJ0PR13MB5545CBD0921867CA62216B9F9E752@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <BN9PR18MB42045A0D6ACBF0C1422FF4B7C5752@BN9PR18MB4204.namprd18.prod.outlook.com>
>
> Hi Chaoyong,
>
> Please see responses inline
>
>
> <snip>
>
> > > return ret;
> > > }
> > >
> > ...
> > > a/drivers/net/nfp/flower/nfp_flower_representor.c
> > > b/drivers/net/nfp/flower/nfp_flower_representor.c
> > > index 5f7c1fa737..63fe37c8d7 100644
> > > --- a/drivers/net/nfp/flower/nfp_flower_representor.c
> > > +++ b/drivers/net/nfp/flower/nfp_flower_representor.c
> > > @@ -792,8 +792,8 @@ nfp_flower_repr_create(struct
> nfp_app_fw_flower
> > > *app_fw_flower)
> > >
> > > /* Now parse PCI device args passed for representor info */
> > > if (pci_dev->device.devargs != NULL) {
> > > - ret = rte_eth_devargs_parse(pci_dev->device.devargs->args,
> > > ð_da);
> > > - if (ret != 0) {
> > > + ret =
> > > + rte_eth_devargs_parse(pci_dev->device.devargs->args,
> > > ð_da, 1);
> > > + if (ret < 0) {
> > > PMD_INIT_LOG(ERR, "devarg parse failed");
> > > return -EINVAL;
> > > }
> >
> > Sorry, I don't quite understand why change 'ret != 0' to 'ret < 0'?
> > Compare return value with 0 or NULL is the specification for our PMD,
> > we prefer not to change it if don't have a good reason.
> > Thanks.
>
> To support multiple representors under one PCI BDF, "eth_devargs args"
> parameter passed to rte_eth_devargs_parse() is now an array which gets
> populated with multiple "struct rte_eth_devargs" elements viz different pfvf
> representor devargs.
>
> We are proposing a change to the return value of this API, I.e. negative means
> error condition and positive value refers to no of "struct rte_eth_devargs"
> elements populated. So it can't be zero, else we wont know how many
> elements were populated in the array.
>
> Thanks
> Harman
>
Got it, thanks to make it clear.
Then it looks good to me.
> >
> > > --
> > > 2.18.0
next prev parent reply other threads:[~2024-01-22 10:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 6:44 [PATCH 0/2] multiple representors in one device Harman Kalra
2024-01-11 6:44 ` [PATCH 1/2] ethdev: parsing multiple representor devargs string Harman Kalra
2024-01-12 7:25 ` Andrew Rybchenko
2024-01-12 9:37 ` [EXT] " Harman Kalra
2024-01-12 12:42 ` David Marchand
2024-01-15 16:01 ` [EXT] " Harman Kalra
2024-01-11 6:44 ` [PATCH 2/2] doc: multiple representors in one device Harman Kalra
2024-01-12 7:26 ` Andrew Rybchenko
2024-01-15 16:01 ` [EXT] " Harman Kalra
2024-01-15 15:57 ` [PATCH v2 0/1] " Harman Kalra
2024-01-15 15:57 ` [PATCH v2 1/1] ethdev: parsing multiple representor devargs string Harman Kalra
2024-01-16 9:55 ` [PATCH v3 0/1] multiple representors in one device Harman Kalra
2024-01-16 9:55 ` [PATCH v3 1/1] ethdev: parsing multiple representor devargs string Harman Kalra
2024-01-17 8:47 ` Andrew Rybchenko
2024-01-21 19:30 ` [EXT] " Harman Kalra
2024-01-21 19:19 ` [PATCH v4 0/1] multiple representors in one device Harman Kalra
2024-01-21 19:19 ` [PATCH v4 1/1] ethdev: parsing multiple representor devargs string Harman Kalra
2024-01-22 1:13 ` Chaoyong He
2024-01-22 9:07 ` Harman Kalra
2024-01-22 10:10 ` Chaoyong He [this message]
2024-01-25 5:28 ` Harman Kalra
2024-01-26 13:43 ` Ferruh Yigit
2024-01-29 18:20 ` [EXT] " Harman Kalra
2024-01-30 23:09 ` Ferruh Yigit
2024-02-01 10:10 ` Harman Kalra
2024-02-01 10:02 ` [PATCH v5 0/2] multiple representors in one device Harman Kalra
2024-02-01 10:02 ` [PATCH v5 1/2] ethdev: parsing multiple representor devargs string Harman Kalra
2024-02-01 10:02 ` [PATCH v5 2/2] test/devargs: add eth devargs parse cases Harman Kalra
2024-02-01 18:35 ` [PATCH v5 0/2] multiple representors in one device Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB5545CBD0921867CA62216B9F9E752@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=Yuying.Zhang@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ferruh.yigit@amd.com \
--cc=hkalra@marvell.com \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
--cc=wenjun1.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).