From: Chaoyong He <chaoyong.he@corigine.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
oss-drivers <oss-drivers@corigine.com>,
Niklas Soderlund <niklas.soderlund@corigine.com>,
Long Wu <Long.Wu@nephogine.com>,
James Hershaw <james.hershaw@corigine.com>
Subject: RE: [PATCH] net/bonding: replace master/slave to main/member
Date: Thu, 18 May 2023 03:26:27 +0000 [thread overview]
Message-ID: <SJ0PR13MB5545D7D45AC53F6DD9F759E69E7F9@SJ0PR13MB5545.namprd13.prod.outlook.com> (raw)
In-Reply-To: <20230517075238.6ff09c8b@hermes.local>
> On Wed, 17 May 2023 14:59:05 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
>
> > This patch replaces the usage of the word 'master/slave' with more
> > appropriate word 'main/member' in bonding PMD as well as in its docs
> > and examples. Also the test app and testpmd were modified to use the
> > new wording.
> >
> > The bonding PMD's public API was modified according to the changes in
> > word:
> > rte_eth_bond_8023ad_slave_info is now called
> > rte_eth_bond_8023ad_member_info, rte_eth_bond_active_slaves_get is
> now
> > called rte_eth_bond_active_members_get, rte_eth_bond_slave_add is now
> > called rte_eth_bond_member_add, rte_eth_bond_slave_remove is now
> > called rte_eth_bond_member_remove, rte_eth_bond_slaves_get is now
> > called rte_eth_bond_members_get.
> >
> > Also the macro RTE_ETH_DEV_BONDED_SLAVE was renamed to
> > RTE_ETH_DEV_BONDED_MEMBER.
> >
> > Signed-off-by: Long Wu <long.wu@corigine.com>
> > Acked-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> > Reviewed-by: James Hershaw <james.hershaw@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> > ---
>
> This looks great.
>
> I had started on this and chose the new names as parent and child, but that
> choice was arbitrary. Did some background research and
>
> ============ ================== ============== ===============
> Origin Feature Name Aggregate Name Device Name
> ============ ================== ============== ===============
> IEEE 802.1AX Link Aggregation aggregator port
> Linux Bonding master slave
> FreeBSD Link Aggregate lagg laggport
> Windows Teaming team
> OpenVswitch Bonding bond members
> Solaris Link Aggregate aggregation datalink
> Cisco EtherChannel group channel
> Juniper Aggregate Ethernet lag interface lag link
> Arista Port Channel group channel
> SONiC LAG portchannel member
> ============ ================== ============== ===============
>
>
> You also need to modify how this is done since it ends up being an API change.
>
> My version of the patch had some of that, if you want here it is.
Thanks for your kindly review and advice, we will revise and send out a v2 patch ASAP.
next prev parent reply other threads:[~2023-05-18 3:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 6:59 Chaoyong He
2023-05-17 14:52 ` Stephen Hemminger
2023-05-18 3:26 ` Chaoyong He [this message]
2023-05-18 6:32 ` [PATCH v2] " Chaoyong He
2023-05-18 7:01 ` [PATCH v3] " Chaoyong He
2023-05-18 8:44 ` [PATCH v4] " Chaoyong He
2023-05-18 15:39 ` Stephen Hemminger
2023-06-02 15:05 ` Ferruh Yigit
2023-08-16 6:27 ` [PATCH v5 0/2] " Chaoyong He
2023-08-16 6:27 ` [PATCH v5 1/2] ethdev: remove bonding deprecated macro Chaoyong He
2023-08-17 2:28 ` lihuisong (C)
2023-08-16 6:27 ` [PATCH v5 2/2] net/bonding: replace master/slave to main/member Chaoyong He
2023-08-16 14:42 ` Stephen Hemminger
2023-08-17 2:36 ` lihuisong (C)
2023-08-18 2:44 ` [PATCH] app/test: fix reference to master in bonding test Stephen Hemminger
2023-08-21 15:59 ` Tyler Retzlaff
2023-09-21 16:10 ` Ferruh Yigit
2023-09-20 14:00 ` [PATCH v5 0/2] replace master/slave to main/member Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR13MB5545D7D45AC53F6DD9F759E69E7F9@SJ0PR13MB5545.namprd13.prod.outlook.com \
--to=chaoyong.he@corigine.com \
--cc=Long.Wu@nephogine.com \
--cc=dev@dpdk.org \
--cc=james.hershaw@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).