DPDK patches and discussions
 help / color / mirror / Atom feed
From: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ray Kinsella <mdr@ashroe.eu>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api
Date: Thu, 7 Jul 2022 13:38:41 +0000	[thread overview]
Message-ID: <SJ0PR18MB441316DDE6875571E39719EAC1839@SJ0PR18MB4413.namprd18.prod.outlook.com> (raw)
In-Reply-To: <74f0f801-46a9-c407-e6df-ccd48ac1d817@oktetlabs.ru>



-----Original Message-----
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> 
Sent: Thursday, July 7, 2022 6:23 PM
To: Satha Koteswara Rao Kottidi <skoteshwar@marvell.com>; Ray Kinsella <mdr@ashroe.eu>
Cc: dev@dpdk.org
Subject: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

External Email

----------------------------------------------------------------------
On 7/1/22 18:32, skoteshwar@marvell.com wrote:
> From: Satha Rao <skoteshwar@marvell.com>
> 
> rte_eth_set_queue_rate_limit argument rate modified to uint64_t to 
> support more than 64Gbps.
> 
> Signed-off-by: Satha Rao <skoteshwar@marvell.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst 
> b/doc/guides/rel_notes/deprecation.rst
> index 4e5b23c..5bf2b72 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -125,3 +125,8 @@ Deprecation Notices
>     applications should be updated to use the ``dmadev`` library instead,
>     with the underlying HW-functionality being provided by the ``ioat`` or
>     ``idxd`` dma drivers
> +
> +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes ``rate`` in Mbps.
> +  This parameter declared as uint16_t, queue rate limited to 64Gbps. 
> +``rate``
> +  parameter will be modified to uint64_t in DPDK 22.11 so that it can 
> +work for
> +  more than 64Gbps.

I fully agree that uint16_t is not enough, but I'd like to understand the reason behind uint64_t vs uint32_t. It looks like uint32_t is more than enough.

>> yes uint32_t is enough, proposed uint64_t so that the rate in TM shaper profile is also uint64_t in bps

  reply	other threads:[~2022-07-07 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-01 15:32 skoteshwar
2022-07-07 12:52 ` Andrew Rybchenko
2022-07-07 13:38   ` Satha Koteswara Rao Kottidi [this message]
2022-07-12 13:10     ` [EXT] " Satha Koteswara Rao Kottidi
2022-07-12 14:04     ` Thomas Monjalon
2022-07-13  4:04       ` Satha Koteswara Rao Kottidi
2022-07-13  6:26 ` [PATCH v2] " skoteshwar
2022-07-13  6:46   ` Jerin Jacob
2022-07-15 13:25 ` [PATCH v3] doc: announce changes to rte_eth_set_queue_rate_limit API skoteshwar
2022-07-15 14:23   ` Andrew Rybchenko
2022-07-15 16:29     ` Ajit Khaparde
2022-07-16 18:05       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR18MB441316DDE6875571E39719EAC1839@SJ0PR18MB4413.namprd18.prod.outlook.com \
    --to=skoteshwar@marvell.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=mdr@ashroe.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).