From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Ruifeng Wang <ruifeng.wang@arm.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"gavin.hu@arm.com" <gavin.hu@arm.com>,
"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
"juraj.linkes@pantheon.tech" <juraj.linkes@pantheon.tech>,
"nd@arm.com" <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v1] test: fix ipsec unit test segfault
Date: Mon, 23 Mar 2020 12:21:00 +0000 [thread overview]
Message-ID: <SN6PR11MB25586F457083B226D2C33C589AF00@SN6PR11MB2558.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200320080520.144952-1-ruifeng.wang@arm.com>
>
> Segfault was observed when running ipsec unit test:
>
> + TestCase [10] : test_ipsec_replay_inb_repeat_null_null_wrapper
> succeeded
> + TestCase [11] : test_ipsec_replay_inb_inside_burst_null_null_wrapper
> succeeded
> + TestCase [12] : test_ipsec_crypto_inb_burst_2sa_null_null_wrapper
> succeeded
> + TestCase [13] : test_ipsec_crypto_inb_burst_2sa_4grp_null_null_wrapper
> succeeded
> Segmentation fault
>
> Data corruption happens due to incorrect destroy of session. Security
> session needs process different from crypto session.
>
> Destroy corresponding sessions according to different security actions.
>
> Fixes: 05fe65eb66b2 ("test/ipsec: introduce functional test")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> app/test/test_ipsec.c | 33 ++++++++++++++++++++++++++++++---
> 1 file changed, 30 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
> index 9e1447293..79d00d7e0 100644
> --- a/app/test/test_ipsec.c
> +++ b/app/test/test_ipsec.c
> @@ -1167,6 +1167,34 @@ test_ipsec_dump_buffers(struct ipsec_unitest_params *ut_params, int i)
> }
> }
>
> +static void
> +destroy_dummy_sec_session(struct ipsec_unitest_params *ut,
> + uint32_t j)
> +{
> + rte_security_session_destroy(&dummy_sec_ctx,
> + ut->ss[j].security.ses);
> + ut->ss[j].security.ctx = NULL;
> +}
> +
> +static void
> +destroy_crypto_session(struct ipsec_unitest_params *ut,
> + uint8_t crypto_dev, uint32_t j)
> +{
> + rte_cryptodev_sym_session_clear(crypto_dev, ut->ss[j].crypto.ses);
> + rte_cryptodev_sym_session_free(ut->ss[j].crypto.ses);
> + memset(&ut->ss[j], 0, sizeof(ut->ss[j]));
> +}
> +
> +static void
> +destroy_session(struct ipsec_unitest_params *ut,
> + uint8_t crypto_dev, uint32_t j)
> +{
> + if (ut->ss[j].type == RTE_SECURITY_ACTION_TYPE_NONE)
> + return destroy_crypto_session(ut, crypto_dev, j);
> + else
> + return destroy_dummy_sec_session(ut, j);
> +}
> +
> static void
> destroy_sa(uint32_t j)
> {
> @@ -1175,9 +1203,8 @@ destroy_sa(uint32_t j)
>
> rte_ipsec_sa_fini(ut->ss[j].sa);
> rte_free(ut->ss[j].sa);
> - rte_cryptodev_sym_session_clear(ts->valid_dev, ut->ss[j].crypto.ses);
> - rte_cryptodev_sym_session_free(ut->ss[j].crypto.ses);
> - memset(&ut->ss[j], 0, sizeof(ut->ss[j]));
> +
> + destroy_session(ut, ts->valid_dev, j);
> }
>
> static int
> --
Good catch, thanks for the fix.
As a nit caption should probably be: "test/ipsec: fix ..."
Tested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.17.1
next prev parent reply other threads:[~2020-03-23 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-20 8:05 Ruifeng Wang
2020-03-23 12:21 ` Ananyev, Konstantin [this message]
2020-03-25 19:03 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB25586F457083B226D2C33C589AF00@SN6PR11MB2558.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=juraj.linkes@pantheon.tech \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).