From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "O'loingsigh, Mairtin" <mairtin.oloingsigh@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Ryan, Brendan" <brendan.ryan@intel.com>,
"Coyle, David" <david.coyle@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/2] net: add CRC run-time checks and AVX512/VPCLMULQDQ based CRC
Date: Fri, 9 Oct 2020 18:35:58 +0000 [thread overview]
Message-ID: <SN6PR11MB31019ABC8860CBC98BFC1C3384080@SN6PR11MB3101.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201009135045.8505-1-mairtin.oloingsigh@intel.com>
> -----Original Message-----
> From: O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Sent: Friday, October 9, 2020 2:51 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: dev@dpdk.org; Ryan, Brendan <brendan.ryan@intel.com>; O'loingsigh,
> Mairtin <mairtin.oloingsigh@intel.com>; Coyle, David <david.coyle@intel.com>
> Subject: [PATCH v5 0/2] net: add CRC run-time checks and
> AVX512/VPCLMULQDQ based CRC
>
> This patchset makes two significant enhancements to the CRC modules of the
> rte_net library:
>
> 1) Adds run-time selection of the optimal architecture-specific CRC path.
> Previously the selection was solely made at compile-time, meaning it
> could only be built and run on the same generation of CPU. Adding
> run-time selection ability means this can be used from distro packages
> and/or DPDK can be compiled on an older CPU and run on a newer CPU.
> 2) Adds an optimized CRC implementation based on the AVX512 and
> VPCLMULQDQ instruction sets.
>
> For further details, please see the commit messages of the individual patches.
>
> v5:
> * Tidied-up the ifdef checks for RTE_ARCH_* and compiler support of CRC
> paths, as per review comments:
> * All ifdef checks removed from API function definitions and moved into
> helper functions.
>
> v4:
> * Fixed build issue when older version of meson is used (0.47.1).
> * Addressed review comments:
> * remove Intel copyright header from neon CRC file.
> * tidy-up of register initialisation.
>
> v3:
> * Re-submitted v2 as encountered problems when originally submitting it.
>
> v2:
> * Added support for run-time selection of optimal architecture-specific
> CRC, based on v1 review comment.
> * Added full working AVX512/VPCLMULQDQ support for CRC32-Ethernet and
> CRC16-CCITT.
>
> v1:
> * Initial version, with incomplete AVX512/VPCLMULQDQ support for
> CRC32-Ethernet only.
>
> Mairtin o Loingsigh (2):
> net: add run-time architecture specific CRC selection
> net: add support for AVX512/VPCLMULQDQ based CRC
>
> app/test/test_crc.c | 11 +-
> config/x86/meson.build | 6 +-
> doc/guides/rel_notes/release_20_11.rst | 6 +
> lib/librte_net/meson.build | 89 ++++-
> lib/librte_net/net_crc.h | 45 +++
> lib/librte_net/net_crc_avx512.c | 423 ++++++++++++++++++++++
> lib/librte_net/{net_crc_neon.h => net_crc_neon.c} | 26 +-
> lib/librte_net/{net_crc_sse.h => net_crc_sse.c} | 34 +-
> lib/librte_net/rte_net_crc.c | 162 +++++++--
> lib/librte_net/rte_net_crc.h | 4 +-
> 10 files changed, 722 insertions(+), 84 deletions(-) create mode 100644
> lib/librte_net/net_crc.h create mode 100644 lib/librte_net/net_crc_avx512.c
> rename lib/librte_net/{net_crc_neon.h => net_crc_neon.c} (95%) rename
> lib/librte_net/{net_crc_sse.h => net_crc_sse.c} (94%)
>
> --
> 2.12.3
Series-Reviewed-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2020-10-09 18:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 15:35 [dpdk-dev] [PATCH v3 " Mairtin o Loingsigh
2020-09-29 15:36 ` [dpdk-dev] [PATCH v3 1/2] net: add run-time architecture specific CRC selection Mairtin o Loingsigh
2020-10-02 15:17 ` Singh, Jasvinder
2020-10-06 16:38 ` O'loingsigh, Mairtin
2020-09-29 15:36 ` [dpdk-dev] [PATCH v3 2/2] net: add support for AVX512/VPCLMULQDQ based CRC Mairtin o Loingsigh
2020-10-05 13:20 ` De Lara Guarch, Pablo
2020-10-05 13:38 ` O'loingsigh, Mairtin
2020-10-06 16:23 ` [dpdk-dev] [PATCH v4 0/2] net: add CRC run-time checks and " Mairtin o Loingsigh
2020-10-06 16:23 ` [dpdk-dev] [PATCH v4 1/2] net: add run-time architecture specific CRC selection Mairtin o Loingsigh
2020-10-07 14:59 ` Ananyev, Konstantin
2020-10-09 14:04 ` Coyle, David
2020-10-10 12:42 ` Ananyev, Konstantin
2020-10-06 16:23 ` [dpdk-dev] [PATCH v4 2/2] net: add support for AVX512/VPCLMULQDQ based CRC Mairtin o Loingsigh
2020-10-07 9:26 ` [dpdk-dev] [PATCH v4 0/2] net: add CRC run-time checks and " David Marchand
2020-10-09 13:50 ` [dpdk-dev] [PATCH v5 " Mairtin o Loingsigh
2020-10-09 13:50 ` [dpdk-dev] [PATCH v5 1/2] net: add run-time architecture specific CRC selection Mairtin o Loingsigh
2020-10-09 16:22 ` Singh, Jasvinder
2020-10-10 9:34 ` Ruifeng Wang
2020-10-13 9:07 ` Bruce Richardson
2020-10-09 13:50 ` [dpdk-dev] [PATCH v5 2/2] net: add support for AVX512/VPCLMULQDQ based CRC Mairtin o Loingsigh
2020-10-09 16:24 ` Singh, Jasvinder
2020-10-09 18:35 ` De Lara Guarch, Pablo [this message]
2020-10-13 18:47 ` [dpdk-dev] [PATCH v5 0/2] net: add CRC run-time checks and " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB31019ABC8860CBC98BFC1C3384080@SN6PR11MB3101.namprd11.prod.outlook.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=brendan.ryan@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.coyle@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=mairtin.oloingsigh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).