From: "Kearney, Tadhg" <tadhg.kearney@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Hunt, David" <david.hunt@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>
Subject: RE: [PATCH v2 1/3] power: add uncore API to power library
Date: Tue, 26 Jul 2022 16:21:16 +0000 [thread overview]
Message-ID: <SN6PR11MB3119A5645D8043CB788D412FF0949@SN6PR11MB3119.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YtkV9V/xOWTwtIOG@bricha3-MOBL.ger.corp.intel.com>
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
*snip*
> > > +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1)
> > > +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32)
> >
> > Check if these flags should be added to other platforms.
> >
>
> I think we need some explanation as to what these values are for, and how
> they should be set for various platforms.
Kernel does support sysfs uncore interface, as in below:
"To control uncore frequency, a sysfs interface is provided in the directory: /sys/devices/system/cpu/intel_uncore_frequency/.
There is one directory for each package and die combination as the scope of uncore scaling control is per die in multiple die/package SoCs or per package for single die per package SoCs. The name represents the scope of control. For example: 'package_00_die_00' is for package id 0 and die 0."
The macros 'RTE_MAX_NUMA_DIE' and 'RTE_MAX_UNCORE_FREQS' were first introduced as we needed to impose limits on cpu die number and how many uncore frequencies would be allowed for a system.
> Are they always these values, or
No, they differ from system to system.
> should they be determined programmatically at build time?
Retrieving information about die and number of uncore frequencies is not possible as we do not have a direct interface in Linux which would give this information.
With all this, better to remove these macros altogether from config path and instead figure out number of dies during run time, by iterating through package and die files from the sysfs file 'package_*_die_*',
for systems that support sysfs uncore path. We would then give error with systems that do not contain sysfs uncore path.
Regards, Tadhg
next prev parent reply other threads:[~2022-07-26 16:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 14:07 [PATCH v2 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-07-13 14:07 ` [PATCH v2 1/3] power: add uncore API to power library Tadhg Kearney
2022-07-20 16:10 ` Pattan, Reshma
2022-07-21 9:01 ` Bruce Richardson
2022-07-26 16:21 ` Kearney, Tadhg [this message]
2022-07-13 14:07 ` [PATCH v2 2/3] test/power: add unit tests for uncore API Tadhg Kearney
2022-07-13 14:07 ` [PATCH v2 3/3] l3fwd-power: add option to call " Tadhg Kearney
2022-07-21 12:15 ` Pattan, Reshma
2022-07-21 16:48 ` Pattan, Reshma
2022-09-06 10:51 ` Hunt, David
2022-09-19 9:05 ` [PATCH v3 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-09-19 9:05 ` [PATCH v3 1/3] power: add uncore frequency control API to the power library Tadhg Kearney
2022-09-19 9:05 ` [PATCH v3 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-09-19 9:05 ` [PATCH v3 3/3] test/power: add unit tests for " Tadhg Kearney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3119A5645D8043CB788D412FF0949@SN6PR11MB3119.namprd11.prod.outlook.com \
--to=tadhg.kearney@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).