From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Gaoxiang Liu <gaoxiangliu0@163.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed
Date: Thu, 23 Jun 2022 03:03:10 +0000 [thread overview]
Message-ID: <SN6PR11MB350440D5270135FAAF2C81C29CB59@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <3603f2dd.5f97.1818bd20f65.Coremail.gaoxiangliu0@163.com>
Hi Gaoxiang,
> From: Gaoxiang Liu <gaoxiangliu0@163.com>
> Sent: Wednesday, June 22, 2022 10:30 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org
> Subject: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed
>
>
> Hi, Chen bo, Maxime,
> Please help to review the patch below.
Maxime or I will review it when we have time. But please note that you sent the patch multiple times and did not update the version. So patchwork shows multiple patches and we will need to check which one is the latest. This will of course increase our overhead to review.
Please update the version number or update the patchwork next time. This will also help your patch get reviewed ASAP.
Thanks,
Chenbo
> Thanks.
> Gaoxiang.
-------- Forwarding messages --------
From: "Gaoxiang Liu" <mailto:gaoxiangliu0@163.com>
Date: 2022-06-22 09:19:44
To: mailto:maxime.coquelin@redhat.com,chenbo.xia@intel.com
Cc: mailto:dev@dpdk.org,liugaoxiang@huawei.com,"Gaoxiang Liu" <mailto:gaoxiangliu0@163.com>,stable@dpdk.org
Subject: [PATCH v2] vhost: fix avail idx update error when desc copy failed
When copy_desc_to_mbuf function failed, i added 1.
And last_avail_idx added i, other than i - 1.
It may cause that the first mbuf in mbuf-list is dropped,
the second mbuf in mbuf-list is received in the following
rx procedure.
And The pkt_len of the second mbuf is zero, resulting in
segment fault when parsing the mbuf.
Fixes: 0fd5608ef97f ("vhost: handle mbuf allocation failure")
Cc: mailto:stable@dpdk.org
Signed-off-by: Gaoxiang Liu <mailto:liugaoxiang@huawei.com>
---
v2:
* Fixed other idx update errors.
---
lib/vhost/virtio_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c
index 68a26eb17d..eb254e1024 100644
--- a/lib/vhost/virtio_net.c
+++ b/lib/vhost/virtio_net.c
@@ -2850,11 +2850,11 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,
if (dropped)
rte_pktmbuf_free_bulk(&pkts[i - 1], count - i + 1);
- vq->last_avail_idx += i;
+ vq->last_avail_idx += i - dropped;
do_data_copy_dequeue(vq);
- if (unlikely(i < count))
- vq->shadow_used_idx = i;
+ if (unlikely((i - dropped) < count))
+ vq->shadow_used_idx = i - dropped;
if (likely(vq->shadow_used_idx)) {
flush_shadow_used_ring_split(dev, vq);
vhost_vring_call_split(dev, vq);
--
2.32.0
prev parent reply other threads:[~2022-06-23 3:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 14:30 Gaoxiang Liu
2022-06-23 3:03 ` Xia, Chenbo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB350440D5270135FAAF2C81C29CB59@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=gaoxiangliu0@163.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).