From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Ding, Xuan" <xuan.ding@intel.com>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>
Subject: RE: [PATCH v3] doc: clean vhost async path doc
Date: Thu, 23 Jun 2022 03:11:59 +0000 [thread overview]
Message-ID: <SN6PR11MB3504635BEB7BEDC2277DABAB9CB59@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220622014556.105081-1-xuan.ding@intel.com>
> -----Original Message-----
> From: Ding, Xuan <xuan.ding@intel.com>
> Sent: Wednesday, June 22, 2022 9:46 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>
> Subject: [PATCH v3] doc: clean vhost async path doc
>
> From: Xuan Ding <xuan.ding@intel.com>
>
> This patch moves the 'Recommended IOVA mode in async datapath'
> section under 'Vhost asynchronous data path' as a sub-section,
> which makes the doc cleaner.
>
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> Reviewed-by: Jiayu Hu <jiayu.hu@intel.com>
Patch seems good. But it needs to be applied after
http://patchwork.dpdk.org/project/dpdk/patch/20220621072131.14756-1-xuan.ding@intel.com/
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
> ---
> v3:
> * add Reviewd-by
>
> v2:
> * fix a typo in commit log
> ---
> doc/guides/prog_guide/vhost_lib.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/doc/guides/prog_guide/vhost_lib.rst
> b/doc/guides/prog_guide/vhost_lib.rst
> index 628db3fc38..e93673ce68 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -488,11 +488,11 @@ support sharing DMA channels among vrings.
> not poll completed will cause the DMA ring to be full, which will
> result in packet loss eventually.
>
> -Recommended IOVA mode in async datapath
> ----------------------------------------
> +* Recommended IOVA mode in async datapath
>
> -When DMA devices are bound to VFIO driver, VA mode is recommended.
> -For PA mode, page by page mapping may exceed IOMMU's max capability,
> -better to use 1G guest hugepage.
> + When DMA devices are bound to VFIO driver, VA mode is recommended.
> + For PA mode, page by page mapping may exceed IOMMU's max capability,
> + better to use 1G guest hugepage.
>
> -For UIO driver, any VFIO related error message can be ignored.
> + For UIO driver or kernel driver, any VFIO related error messages
> + can be ignored.
> --
> 2.17.1
next prev parent reply other threads:[~2022-06-23 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 1:35 [PATCH] " xuan.ding
2022-06-22 1:41 ` [PATCH v2] " xuan.ding
2022-06-22 1:42 ` [PATCH] " Hu, Jiayu
2022-06-22 1:45 ` [PATCH v3] " xuan.ding
2022-06-23 3:11 ` Xia, Chenbo [this message]
2022-07-01 13:56 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504635BEB7BEDC2277DABAB9CB59@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=xuan.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).