patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"ktraynor@redhat.com" <ktraynor@redhat.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2] vhost: decrease log level for unimplemented requests
Date: Tue, 7 Feb 2023 02:57:54 +0000	[thread overview]
Message-ID: <SN6PR11MB350474E38A6ABEF0A9FB18029CDB9@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230206150733.108910-1-maxime.coquelin@redhat.com>

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Monday, February 6, 2023 11:08 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; ktraynor@redhat.com;
> david.marchand@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>; stable@dpdk.org
> Subject: [PATCH v2] vhost: decrease log level for unimplemented requests
> 
> This patch changes VHOST_USER_SET_VRING_ERR and
> VHOST_USER_SET_LOG_FD "not implemented" log levels from
> INFO to DEBUG, as implementing these requests is not
> mandatory. Having them being displayed at INFO level
> may induce some confusion to the end-user.
> 
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in
> functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/vhost/vhost_user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 8f33d5f4d9..551908df8e 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct
> virtio_net **pdev,
> 
>  	if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
>  		close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
> 
>  	return RTE_VHOST_MSG_RESULT_OK;
>  }
> @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net
> **pdev,
>  		return RTE_VHOST_MSG_RESULT_ERR;
> 
>  	close(ctx->fds[0]);
> -	VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n");
> +	VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n");
> 
>  	return RTE_VHOST_MSG_RESULT_OK;
>  }
> --
> 2.39.1

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com> 

  reply	other threads:[~2023-02-07  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 15:07 Maxime Coquelin
2023-02-07  2:57 ` Xia, Chenbo [this message]
2023-02-07 10:18 ` Kevin Traynor
2023-02-09 12:13 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB350474E38A6ABEF0A9FB18029CDB9@SN6PR11MB3504.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).