From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, YuanX" <yuanx.wang@intel.com>,
"Ding, Xuan" <xuan.ding@intel.com>,
"ferruh.yigit@xilinx.com" <ferruh.yigit@xilinx.com>
Subject: RE: [PATCH 2/4] vhost: restore device information in log messages
Date: Wed, 29 Jun 2022 13:34:27 +0000 [thread overview]
Message-ID: <SN6PR11MB3504B2AC2AEB435C151CFB1A9CBB9@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220627092728.78214-3-david.marchand@redhat.com>
Hi David,
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, June 27, 2022 5:27 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Wang,
> YuanX <yuanx.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> Subject: [PATCH 2/4] vhost: restore device information in log messages
>
> device information in the log messages was dropped.
>
> Fixes: 52ade97e3641 ("vhost: fix physical address mapping")
Should we add cc-stable tag in this case as it's 22.03 commit?
Last time when I asked Ferruh, he said although now we don't maintain
non-LTS release, we should still add this tag. Not sure this changed
or not.
For the patch:
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/vhost_user.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 2b9a3b69fa..f324f822d6 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -144,7 +144,8 @@ async_dma_map(struct virtio_net *dev, bool do_map)
> return;
>
> /* DMA mapping errors won't stop
> VHOST_USER_SET_MEM_TABLE. */
> - VHOST_LOG_CONFIG(ERR, "DMA engine map failed\n");
> + VHOST_LOG_CONFIG(ERR, "(%s) DMA engine map
> failed\n",
> + dev->ifname);
> }
> }
>
> @@ -160,7 +161,8 @@ async_dma_map(struct virtio_net *dev, bool do_map)
> if (rte_errno == EINVAL)
> return;
>
> - VHOST_LOG_CONFIG(ERR, "DMA engine unmap failed\n");
> + VHOST_LOG_CONFIG(ERR, "(%s) DMA engine unmap
> failed\n",
> + dev->ifname);
> }
> }
> }
> @@ -945,7 +947,8 @@ add_one_guest_page(struct virtio_net *dev, uint64_t
> guest_phys_addr,
> dev->max_guest_pages * sizeof(*page),
> RTE_CACHE_LINE_SIZE);
> if (dev->guest_pages == NULL) {
> - VHOST_LOG_CONFIG(ERR, "cannot realloc guest_pages\n");
> + VHOST_LOG_CONFIG(ERR, "(%s) cannot realloc
> guest_pages\n",
> + dev->ifname);
> rte_free(old_pages);
> return -1;
> }
> --
> 2.36.1
next prev parent reply other threads:[~2022-06-29 13:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 9:27 [PATCH 0/4] Vhost logs fixes and improvement David Marchand
2022-06-27 9:27 ` [PATCH 1/4] vhost: add some trailing newline in log messages David Marchand
2022-06-29 13:28 ` Xia, Chenbo
2022-06-27 9:27 ` [PATCH 2/4] vhost: restore device information " David Marchand
2022-06-29 13:34 ` Xia, Chenbo [this message]
2022-06-29 13:45 ` David Marchand
2022-06-29 13:49 ` Xia, Chenbo
2022-06-27 9:27 ` [PATCH 3/4] vhost: improve some datapath " David Marchand
2022-06-30 16:07 ` Maxime Coquelin
2022-06-27 9:27 ` [PATCH 4/4] vhost: prefix logs with context David Marchand
2022-06-30 16:13 ` Maxime Coquelin
2022-07-01 7:13 ` David Marchand
2022-07-01 7:56 ` Maxime Coquelin
2022-07-01 7:55 ` [PATCH v2 0/4] Vhost logs fixes and improvement David Marchand
2022-07-01 7:55 ` [PATCH v2 1/4] vhost: add some trailing newline in log messages David Marchand
2022-07-01 7:55 ` [PATCH v2 2/4] vhost: restore device information " David Marchand
2022-07-01 7:55 ` [PATCH v2 3/4] vhost: improve some datapath " David Marchand
2022-07-01 7:55 ` [PATCH v2 4/4] vhost: prefix logs with context David Marchand
2022-07-01 8:00 ` Maxime Coquelin
2022-07-01 13:20 ` [PATCH v3] " David Marchand
2022-07-01 14:00 ` Maxime Coquelin
2022-07-01 14:00 ` [PATCH v2 0/4] Vhost logs fixes and improvement Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504B2AC2AEB435C151CFB1A9CBB9@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=maxime.coquelin@redhat.com \
--cc=xuan.ding@intel.com \
--cc=yuanx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).