From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Hao Chen <chenh@yusur.tech>,
"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"houyl@yusur.tech" <houyl@yusur.tech>,
"zy@yusur.tech" <zy@yusur.tech>
Subject: RE: [PATCH v2] vhost: enable CONFIG feature for vdpa
Date: Thu, 3 Nov 2022 03:27:29 +0000 [thread overview]
Message-ID: <SN6PR11MB3504DBBCD909ABA8B39467729C389@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221011025435.3769-1-chenh@yusur.tech>
> -----Original Message-----
> From: Hao Chen <chenh@yusur.tech>
> Sent: Tuesday, October 11, 2022 10:55 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; houyl@yusur.tech; zy@yusur.tech
> Subject: [PATCH v2] vhost: enable CONFIG feature for vdpa
>
> Enable this feature, so that libvirt or qemu can call vdpa vendor
> driver's ops '.get_config' through 'vhost_net_get_config' to get
> the mac address of the vdpa hardware without manual configuration.
>
> v1->v2:
> Move VHOST_USER_PROTOCOL_F_CONFIG from VHOST_USER_PROTOCOL_FEATURES
> to function 'rte_vhost_driver_get_protocol_features'.
Don't add above version info to commit log.
Refer to below link about where to add the info.
http://patchwork.dpdk.org/project/dpdk/patch/20221102111713.507-1-anoobj@marvell.com/
>
> Signed-off-by: Hao Chen <chenh@yusur.tech>
> ---
> lib/vhost/socket.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
> index a8df2d484a..df8f26a5bd 100644
> --- a/lib/vhost/socket.c
> +++ b/lib/vhost/socket.c
> @@ -808,6 +808,10 @@ rte_vhost_driver_get_protocol_features(const char
> *path,
> *protocol_features = vsocket->protocol_features
> & vdpa_protocol_features;
>
> + /* Get the unique features of vdpa */
> + if (vdpa_protocol_features & (1ULL << VHOST_USER_PROTOCOL_F_CONFIG))
> + *protocol_features |= (1ULL << VHOST_USER_PROTOCOL_F_CONFIG);
> +
This makes think about what should 'vsocket->protocol_features' mean.
If we do like above, for every new protocol feature that some vdpa device can support
but built-in vhost-net can't support, such logic is needed.
Maybe we should define something like base protocol features that vhost lib
supports and some features for backend-specific. So for vdpa case, just do
'base_feature | vdpa_protocol_features'.
In current VHOST_USER_PROTOCOL_FEATURES, some are general feature that vhost lib
supports, but some seems not (like VHOST_USER_PROTOCOL_F_CRYPTO_SESSION).
@Maxime, what do you think?
Thanks,
Chenbo
> unlock_exit:
> pthread_mutex_unlock(&vhost_user.mutex);
> return ret;
> --
> 2.34.1
prev parent reply other threads:[~2022-11-03 3:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 2:54 Hao Chen
2022-11-03 3:27 ` Xia, Chenbo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504DBBCD909ABA8B39467729C389@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=chenh@yusur.tech \
--cc=dev@dpdk.org \
--cc=houyl@yusur.tech \
--cc=maxime.coquelin@redhat.com \
--cc=zy@yusur.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).