From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>,
Eelco Chaudron <echaudro@redhat.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick
Date: Thu, 1 Jun 2023 02:18:20 +0000 [thread overview]
Message-ID: <SN6PR11MB3504FAB146A5E6D3A03044C29C499@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <11c40eca-5847-dfb4-470d-7da86fe7e51e@redhat.com>
> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Wednesday, May 31, 2023 5:29 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Eelco Chaudron <echaudro@redhat.com>;
> david.marchand@redhat.com
> Cc: dev@dpdk.org
> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt
> kick
>
>
>
> On 5/31/23 08:19, Xia, Chenbo wrote:
> >> -----Original Message-----
> >> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> >> Sent: Tuesday, May 30, 2023 11:17 PM
> >> To: Thomas Monjalon <thomas@monjalon.net>; Eelco Chaudron
> >> <echaudro@redhat.com>; Xia, Chenbo <chenbo.xia@intel.com>;
> >> david.marchand@redhat.com
> >> Cc: dev@dpdk.org
> >> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the
> interrupt
> >> kick
> >>
> >>
> >>
> >> On 5/30/23 15:16, Thomas Monjalon wrote:
> >>> 30/05/2023 15:02, Maxime Coquelin:
> >>>>
> >>>> On 5/17/23 11:09, Eelco Chaudron wrote:
> >>>>> This patch adds an operation callback which gets called every time
> the
> >>>>> library wants to call eventfd_write(). This eventfd_write() call
> could
> >>>>> result in a system call, which could potentially block the PMD
> thread.
> >>>>>
> >>>>> The callback function can decide whether it's ok to handle the
> >>>>> eventfd_write() now or have the newly introduced function,
> >>>>> rte_vhost_notify_guest(), called at a later time.
> >>>>>
> >>>>> This can be used by 3rd party applications, like OVS, to avoid
> system
> >>>>> calls being called as part of the PMD threads.
> >>>>>
> >>>>> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> >>>>> ---
> >>>>> lib/vhost/meson.build | 2 ++
> >>>>> lib/vhost/rte_vhost.h | 23 +++++++++++++++++-
> >>>>> lib/vhost/socket.c | 63
> >> ++++++++++++++++++++++++++++++++++++++++++++++---
> >>>>> lib/vhost/version.map | 9 +++++++
> >>>>> lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++
> >>>>> lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++---
> ---
> >> -------
> >>>>> 6 files changed, 171 insertions(+), 22 deletions(-)
> >>>>>
> >>>>
> >>>>
> >>>> The patch looks good to me, but that's the first time we use function
> >>>> versioning in Vhost library, so I'd like another pair of eyes to be
> >> sure
> >>>> I don't miss anything.
> >>>>
> >>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >>>>
> >>>> Thomas, do we need to mention it somewhere in the release note?
> >>>
> >>> If compatibility is kept, I think we don't need to mention it.
> >>>
> >>>
> >>
> >> Thanks Thomas for the information.
> >>
> >> Maxime
> >
> > About release note, except the versioning, there is also one new API
> introduced
> > in this patch, so we still need to mention this in release note
>
> Right, good catch.
> Eelco, let me know what you would put, I'll add it while applying (No
> need for a new revision).
Btw, the vhost_lib.rst also needs a new item..
Thanks,
Chenbo
>
> Thanks,
> Maxime
>
> > Thanks,
> > Chenbo
next prev parent reply other threads:[~2023-06-01 2:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 9:08 [PATCH v3 0/4] " Eelco Chaudron
2023-05-17 9:08 ` [PATCH v3 1/4] vhost: change vhost_virtqueue access lock to a read/write one Eelco Chaudron
2023-05-17 17:33 ` Maxime Coquelin
2023-05-18 14:46 ` Eelco Chaudron
2023-05-31 6:37 ` Xia, Chenbo
2023-05-31 9:27 ` Maxime Coquelin
2023-05-31 11:13 ` Eelco Chaudron
2023-06-01 1:45 ` Xia, Chenbo
2023-05-17 9:08 ` [PATCH v3 2/4] vhost: make the guest_notifications statistic counter atomic Eelco Chaudron
2023-05-30 12:52 ` Maxime Coquelin
2023-05-31 7:03 ` Xia, Chenbo
2023-05-17 9:09 ` [PATCH v3 3/4] vhost: fix invalid call FD handling Eelco Chaudron
2023-05-30 12:54 ` Maxime Coquelin
2023-05-31 6:12 ` Xia, Chenbo
2023-05-31 9:30 ` Maxime Coquelin
2023-05-17 9:09 ` [PATCH v3 4/4] vhost: add device op to offload the interrupt kick Eelco Chaudron
2023-05-30 13:02 ` Maxime Coquelin
2023-05-30 13:16 ` Thomas Monjalon
2023-05-30 15:16 ` Maxime Coquelin
2023-05-31 6:19 ` Xia, Chenbo
2023-05-31 9:29 ` Maxime Coquelin
2023-05-31 11:21 ` Eelco Chaudron
2023-06-01 2:18 ` Xia, Chenbo [this message]
2023-06-01 8:15 ` Eelco Chaudron
2023-06-01 8:29 ` Maxime Coquelin
2023-06-01 8:49 ` Eelco Chaudron
2023-06-01 8:53 ` Maxime Coquelin
2023-05-31 11:49 ` David Marchand
2023-05-31 12:01 ` David Marchand
2023-05-31 12:48 ` Maxime Coquelin
2023-05-31 13:13 ` Eelco Chaudron
2023-05-31 14:12 ` David Marchand
2023-05-31 14:18 ` Maxime Coquelin
2023-06-01 20:00 ` [PATCH v3 0/4] " Maxime Coquelin
2023-06-02 6:20 ` Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3504FAB146A5E6D3A03044C29C499@SN6PR11MB3504.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=echaudro@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).