From: "Yan, Zhirun" <zhirun.yan@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerinj@marvell.com" <jerinj@marvell.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch
Date: Wed, 20 Mar 2024 08:42:52 +0000 [thread overview]
Message-ID: <SN7PR11MB6775FD59D8744D410FBA500485332@SN7PR11MB6775.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MW3PR11MB458717E8B6677B46D92A7CCCE3332@MW3PR11MB4587.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Wu, Jingjing <jingjing.wu@intel.com>
> Sent: Wednesday, March 20, 2024 2:25 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>; dev@dpdk.org
> Cc: jerinj@marvell.com; pbhagavatula@marvell.com; stable@dpdk.org
> Subject: RE: [PATCH] graph: fix head move when graph walk in mcore dispatch
>
>
> > > /* skip the src nodes which not bind with current worker */
> > > if ((int32_t)head < 0 && node->dispatch.lcore_id != graph-
> > > >dispatch.lcore_id)
> > > continue;
> > > -
> > > + head++;
> > If current src node not bind with current core, It will go into infinite loop.
> > This line would have no chance to run.
>
> Seems reasonable, it might be OK to change "head<0" to "head <1" the condition
> check?
No. "head<0" means it is src node.
All src node would put before head = 0. "Head<1" is confused.
You could find the details of graph reel under rte_graph_walk_rtc() in lib/graph/rte_graph_model_rtc.h
I guess if there are some src node missed, it may be caused by wrong config, for example, the missed src node not pin to a lcore.
Use rte_graph_model_mcore_dispatch_node_lcore_affinity_set() to pin the src node first.
next prev parent reply other threads:[~2024-03-20 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 14:14 Jingjing Wu
2024-03-20 3:33 ` Yan, Zhirun
2024-03-20 6:25 ` Wu, Jingjing
2024-03-20 8:42 ` Yan, Zhirun [this message]
2024-03-21 3:39 ` Wu, Jingjing
2024-03-21 5:34 ` Yan, Zhirun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN7PR11MB6775FD59D8744D410FBA500485332@SN7PR11MB6775.namprd11.prod.outlook.com \
--to=zhirun.yan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).