DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Jiang, Cheng1" <cheng1.jiang@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
	"thomas@monjalon.net" <thomas@monjalon.net>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Hu, Jiayu" <jiayu.hu@intel.com>,
	"Ding, Xuan" <xuan.ding@intel.com>,
	"Ma, WenwuX" <wenwux.ma@intel.com>,
	"Wang, YuanX" <yuanx.wang@intel.com>,
	"Yang, YvonneX" <yvonnex.yang@intel.com>,
	"He,  Xingguang" <xingguang.he@intel.com>
Subject: RE: [RFC] app/dma-perf: introduce dma-perf application
Date: Mon, 19 Sep 2022 08:09:57 +0000	[thread overview]
Message-ID: <SN7PR11MB7019FF3CD3162E912B408291DC4D9@SN7PR11MB7019.namprd11.prod.outlook.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D8731D@smartserver.smartshare.dk>

Hi,

Replies are inline.

> -----Original Message-----
> From: Morten Brørup <mb@smartsharesystems.com>
> Sent: Friday, September 16, 2022 3:36 PM
> To: Jiang, Cheng1 <cheng1.jiang@intel.com>; thomas@monjalon.net;
> Richardson, Bruce <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; Ding, Xuan
> <xuan.ding@intel.com>; Ma, WenwuX <wenwux.ma@intel.com>; Wang,
> YuanX <yuanx.wang@intel.com>; Yang, YvonneX
> <yvonnex.yang@intel.com>; He, Xingguang <xingguang.he@intel.com>
> Subject: RE: [RFC] app/dma-perf: introduce dma-perf application
> 
> > From: Cheng Jiang [mailto:cheng1.jiang@intel.com]
> > Sent: Thursday, 15 September 2022 17.48
> >
> > There are many high-performance DMA devices supported in DPDK now,
> and
> > these DMA devices can also be integrated into other modules of DPDK as
> > accelerators, such as Vhost. Before integrating DMA into applications,
> > developers need to know the performance of these DMA devices in
> > various scenarios and the performance of CPUs in the same scenario,
> > such as different buffer lengths. Only in this way can we know the
> > target performance of the application accelerated by using them. This
> > patch introduces a high-performance testing tool, which supports
> > comparing the performance of CPU and DMA in different scenarios
> > automatically with a pre-set config file. Memory Copy performance test
> > are supported for now.
> >
> > Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> > Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> > ---
> >  app/meson.build               |   1 +
> >  app/test-dma-perf/benchmark.c | 537
> > ++++++++++++++++++++++++++++++++++
> >  app/test-dma-perf/benchmark.h |  12 +  app/test-dma-perf/config.ini
> > |  61 ++++
> >  app/test-dma-perf/main.c      | 399 +++++++++++++++++++++++++
> >  app/test-dma-perf/main.h      |  55 ++++
> >  app/test-dma-perf/meson.build |  16 +
> >  7 files changed, 1081 insertions(+)
> >  create mode 100644 app/test-dma-perf/benchmark.c  create mode 100644
> > app/test-dma-perf/benchmark.h  create mode 100644
> > app/test-dma-perf/config.ini  create mode 100644
> > app/test-dma-perf/main.c  create mode 100644 app/test-dma-perf/main.h
> > create mode 100644 app/test-dma-perf/meson.build
> >
> 
> Excellent, thank you!

Sure, thanks!!

> 
> Is there any reason for making this a separate application, instead of part of
> the /app/test/ application?

> 
> NB: Someone could have asked the same question about test-compress-dev
> and similar applications... ;-)

First of all, this application is specifically used to test the performance of DMA device, and does not involve functional testing.
So I'm not sure whether it is suitable for the app/test.
Secondly, the configuration and switching of many test scenarios are involved here, so we think it may be a more appropriate to be an independent application.

> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>

Thanks for your acknowledgement.
Cheng

  reply	other threads:[~2022-09-19  8:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 15:47 Cheng Jiang
2022-09-16  7:36 ` Morten Brørup
2022-09-19  8:09   ` Jiang, Cheng1 [this message]
2022-09-19  8:19     ` Morten Brørup
2022-09-19 11:39 ` [RFC v2] " Cheng Jiang
2022-10-18  6:42 ` [RFC v3] " Cheng Jiang
2022-10-21 13:28   ` David Marchand
2022-10-25  2:17     ` Jiang, Cheng1
2022-10-25  4:34 ` [RFC v4] " Cheng Jiang
2022-10-25  5:19 ` [RFC v5] " Cheng Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN7PR11MB7019FF3CD3162E912B408291DC4D9@SN7PR11MB7019.namprd11.prod.outlook.com \
    --to=cheng1.jiang@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jiayu.hu@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=thomas@monjalon.net \
    --cc=wenwux.ma@intel.com \
    --cc=xingguang.he@intel.com \
    --cc=xuan.ding@intel.com \
    --cc=yuanx.wang@intel.com \
    --cc=yvonnex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).