From: Akhil Goyal <akhil.goyal@nxp.com>
To: Anoob Joseph <anoobj@marvell.com>,
Arek Kusztal <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "fiona.trahe@intel.com" <fiona.trahe@intel.com>,
Shally Verma <shallyv@marvell.com>
Subject: Re: [dpdk-dev] [EXT] [PATCH v5] cryptodev: extend api of asymmetric crypto by session-less
Date: Tue, 15 Oct 2019 10:05:14 +0000 [thread overview]
Message-ID: <VE1PR04MB66391F450E7735437A489D0BE6930@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <MN2PR18MB2877980C74FDCB9406E754D7DF900@MN2PR18MB2877.namprd18.prod.outlook.com>
Updated Title to "cryptodev: update asymmetric crypto op for session-less"
>
> Hi Arek,
>
> Minor suggestion inline. Not a blocker issue.
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
>
> > This commit adds asymmetric session-less option to rte_crypto_asym_op.
> > Feature flag for session-less is added to rte_cryptodev.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > v2:
> > - added union
> > v3:
> > - added entry into feature matrix
> > - added information to prog_guide
> > v4:
> > - fixed formatting
> > - fixed grammar
> > v5:
> > - added release note
> >
> > doc/guides/cryptodevs/features/default.ini | 1 +
> > doc/guides/prog_guide/cryptodev_lib.rst | 9 ++++++++-
> > doc/guides/rel_notes/release_19_11.rst | 5 +++++
> > lib/librte_cryptodev/rte_crypto_asym.h | 9 +++++++--
> > lib/librte_cryptodev/rte_cryptodev.h | 2 ++
> > 5 files changed, 23 insertions(+), 3 deletions(-)
> >
> > diff --git a/doc/guides/cryptodevs/features/default.ini
> > b/doc/guides/cryptodevs/features/default.ini
> > index d3ee1af..b7f9a0a 100644
> > --- a/doc/guides/cryptodevs/features/default.ini
> > +++ b/doc/guides/cryptodevs/features/default.ini
> > @@ -26,6 +26,7 @@ OOP LB In LB Out =
> > RSA PRIV OP KEY EXP =
> > RSA PRIV OP KEY QT =
> > Digest encrypted =
> > +Asymmetric sessionless =
> >
> > ;
> > ; Supported crypto algorithms of a default crypto driver.
> > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst
> > b/doc/guides/prog_guide/cryptodev_lib.rst
> > index 9719944..d420220 100644
> > --- a/doc/guides/prog_guide/cryptodev_lib.rst
> > +++ b/doc/guides/prog_guide/cryptodev_lib.rst
> > @@ -876,7 +876,14 @@ private asymmetric session data. Once this is done,
> > session should be freed usin
> >
> > Asymmetric Sessionless Support
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > -Currently asymmetric crypto framework does not support sessionless.
> > +Asymmetric crypto framework supports session-less operations.
> > +
> > +Fields that should be set by user are:
> > +
> > +Member xform of struct rte_crypto_asym_op should point to the user
> > created rte_crypto_asym_xform.
> > +Note that this rte_crypto_asym_xform should be immutable for the
> > lifetime of associated crypto_op.
> > +
> > +Member sess_type of rte_crypto_op should be set to
> > RTE_CRYPTO_OP_SESSIONLESS.
> >
> > Transforms and Transform Chaining
> > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > diff --git a/doc/guides/rel_notes/release_19_11.rst
> > b/doc/guides/rel_notes/release_19_11.rst
> > index 02fc8fb..4ede7e8 100644
> > --- a/doc/guides/rel_notes/release_19_11.rst
> > +++ b/doc/guides/rel_notes/release_19_11.rst
> > @@ -85,6 +85,11 @@ New Features
> > Added stateful decompression support in the Intel QuickAssist Technology
> > PMD.
> > Please note that stateful compression is not supported.
> >
> > +* **Added cryptodev API to use asymmetric session-less operation.**
> > +
> > + Added session-less option to cryptodev asymmetric API. It works the
> > + same way as symmetric crypto does namely xform is used directly by the
> > crypto op.
> > +
>
> [Anoob] The above line could be confusing. I guess you will need a comma after
> "crypto does".
>
> It works the same way as symmetric crypto does, namely xform is used directly
> by the crypto op.
>
> [Even "does" may not be required]
Updated release notes as
+* **Added cryptodev asymmetric session-less operation.**
+
+ Added session-less option to cryptodev asymmetric structure. It works the same
+ way as symmetric crypto, corresponding xform is used directly by the crypto op.
+
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
Applied to dpdk-next-crypto
Thanks
prev parent reply other threads:[~2019-10-15 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 11:02 [dpdk-dev] " Arek Kusztal
2019-10-14 3:39 ` [dpdk-dev] [EXT] " Anoob Joseph
2019-10-15 10:05 ` Akhil Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB66391F450E7735437A489D0BE6930@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).