From: Akhil Goyal <akhil.goyal@nxp.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ipsec: support multi-segment packets
Date: Thu, 20 Jun 2019 12:46:18 +0000 [thread overview]
Message-ID: <VE1PR04MB66395F637E740C5D9D930A7FE6E40@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20190531000006.13918-1-konstantin.ananyev@intel.com>
Hi Konstantin,
>
> Add support for packets that consist of multiple segments.
> Take into account that trailer bytes (padding, ESP tail, ICV)
> can spawn across multiple segments.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
Which all action types does this patch work well with?
Will it work for lookaside none and inline crypto case both?
For the other 2, ipsec lib is not used.
Also how can the SG support be tested?
>
> v1 -> v2:
> merge with latest mainline
> fix build problem for RTE_BUILD_SHARED_LIB=y
> update programmer's guide
>
> doc/guides/prog_guide/ipsec_lib.rst | 1 -
> lib/librte_ipsec/Makefile | 3 +-
> lib/librte_ipsec/esp_inb.c | 148 +++++++++++++++++++++-------
> lib/librte_ipsec/misc.h | 61 ++++++++++++
> 4 files changed, 175 insertions(+), 38 deletions(-)
>
> diff --git a/doc/guides/prog_guide/ipsec_lib.rst
> b/doc/guides/prog_guide/ipsec_lib.rst
> index 6fc08886f..63b75b652 100644
> --- a/doc/guides/prog_guide/ipsec_lib.rst
> +++ b/doc/guides/prog_guide/ipsec_lib.rst
> @@ -162,7 +162,6 @@ Limitations
> The following features are not properly supported in the current version:
>
> * ESP transport mode for IPv6 packets with extension headers.
> -* Multi-segment packets.
> * Updates of the fields in inner IP header for tunnel mode
> (as described in RFC 4301, section 5.1.2).
> * Hard/soft limit for SA lifetime (time interval/byte count).
> diff --git a/lib/librte_ipsec/Makefile b/lib/librte_ipsec/Makefile
> index e80926baa..22f29d98a 100644
> --- a/lib/librte_ipsec/Makefile
> +++ b/lib/librte_ipsec/Makefile
> @@ -9,7 +9,8 @@ LIB = librte_ipsec.a
> CFLAGS += -O3
> CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR)
> CFLAGS += -DALLOW_EXPERIMENTAL_API
> -LDLIBS += -lrte_eal -lrte_mbuf -lrte_net -lrte_cryptodev -lrte_security
> +LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_net
> +LDLIBS += -lrte_cryptodev -lrte_security
>
I believe this build dependency should also be updated in meson.build file as well.
> EXPORT_MAP := rte_ipsec_version.map
>
> diff --git a/lib/librte_ipsec/esp_inb.c b/lib/librte_ipsec/esp_inb.c
> index 3e12ca103..819d2bf25 100644
> --- a/lib/librte_ipsec/esp_inb.c
> +++ b/lib/librte_ipsec/esp_inb.c
> @@ -104,6 +104,34 @@ inb_cop_prepare(struct rte_crypto_op *cop,
> }
> }
>
next prev parent reply other threads:[~2019-06-20 12:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 18:23 [dpdk-dev] [PATCH] " Konstantin Ananyev
2019-05-31 0:00 ` [dpdk-dev] [PATCH v2] " Konstantin Ananyev
2019-06-20 12:46 ` Akhil Goyal [this message]
2019-06-20 14:29 ` Ananyev, Konstantin
2019-06-25 12:51 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB66395F637E740C5D9D930A7FE6E40@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).